Attention is currently required from: Robert Zieba, Raul Rangel, Jason Nien, Karthik Ramasubramanian.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68325 )
Change subject: mb/google/skyrim: Store XHCI PCI BARs
......................................................................
Patch Set 11: Code-Review+2
(1 comment)
File src/mainboard/google/skyrim/mainboard.c:
https://review.coreboot.org/c/coreboot/+/68325/comment/6a30d2f6_7cede94e
PS6, Line 138:
What's the concern with not returning early? If ELOG isn't selected then the BARs will be stored, bu […]
This suggestion was to eliminate the need to protect the smm_pci_bar_store_fill_bars() declaration with #IF CONFIG(ELOG).
If you return early, that's not needed.
This is moot after the refactoring though.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68325
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I529f541a8932267a8825773ddc582beafb27da63
Gerrit-Change-Number: 68325
Gerrit-PatchSet: 11
Gerrit-Owner: Robert Zieba
robertzieba@google.com
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Robert Zieba
robertzieba@google.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Thu, 01 Dec 2022 21:20:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Robert Zieba
robertzieba@google.com
Comment-In-Reply-To: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-MessageType: comment