Hello Felix Singer,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/44179
to review the following change.
Change subject: payloads/coreinfo: Fix `make clean` ......................................................................
payloads/coreinfo: Fix `make clean`
After `make clean` a new build should not be based on stale artifacts. Hence we have to remove them.
Change-Id: I18292c674986078d991668124193b6aa31234d47 Signed-off-by: Nico Huber nico.huber@secunet.com --- M payloads/coreinfo/Makefile 1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/44179/1
diff --git a/payloads/coreinfo/Makefile b/payloads/coreinfo/Makefile index 4171796..898b12b 100644 --- a/payloads/coreinfo/Makefile +++ b/payloads/coreinfo/Makefile @@ -128,10 +128,9 @@ else
clean: - rm -rf build/*.elf build/*.o .xcompile + rm -rf build lpbuild .xcompile
distclean: clean - rm -rf build lpbuild rm -f .config* lp.config*
.PHONY: clean distclean
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44179 )
Change subject: payloads/coreinfo: Fix `make clean` ......................................................................
Patch Set 1: Code-Review+2
Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44179 )
Change subject: payloads/coreinfo: Fix `make clean` ......................................................................
payloads/coreinfo: Fix `make clean`
After `make clean` a new build should not be based on stale artifacts. Hence we have to remove them.
Change-Id: I18292c674986078d991668124193b6aa31234d47 Signed-off-by: Nico Huber nico.huber@secunet.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/44179 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M payloads/coreinfo/Makefile 1 file changed, 1 insertion(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/payloads/coreinfo/Makefile b/payloads/coreinfo/Makefile index 4171796..898b12b 100644 --- a/payloads/coreinfo/Makefile +++ b/payloads/coreinfo/Makefile @@ -128,10 +128,9 @@ else
clean: - rm -rf build/*.elf build/*.o .xcompile + rm -rf build lpbuild .xcompile
distclean: clean - rm -rf build lpbuild rm -f .config* lp.config*
.PHONY: clean distclean
-
Angel Pons (Code Review) -
Nico Huber (Code Review)