Change in coreboot[master]: UPTREAM: mb/google/volteer: Fix VCM and EEPROM configs for ov8856 wor...

[Daniel Kang (Code Review)]

Daniel Kang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42048 )

Change subject: UPTREAM: mb/google/volteer: Fix VCM and EEPROM configs for ov8856 world-facing camera
......................................................................

UPTREAM: mb/google/volteer: Fix VCM and EEPROM configs for ov8856
world-facing camera

Volteer proto 2 camera module's VCM and EEPROM configs.

BUG=b:148428976
BRANCH=none
TEST=Build and boot volteer proto 2 board. Start a camera app
and check user-facing camera functionalities.

Signed-off-by: Daniel Kang 
Change-Id: I792608f86a59b16545dfa4edf6508de7a444bb26
---
M src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl
1 file changed, 6 insertions(+), 6 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/42048/1

diff --git a/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl b/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl
index 777ab7a..a5756626 100644
--- a/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl
+++ b/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl
@@ -331,8 +331,8 @@
    Device (VCM0)
    {
    	Name (_HID, "PRP0001")  /* _HID: Hardware ID */
-		Name (_UID, 0x03)  /* _UID: Unique ID */
-		Name (_DDN, "GT9769 VCM")  /* _DDN: DOS Device Name */
+		Name (_UID, 0x00)  /* _UID: Unique ID */
+		Name (_DDN, "DW9768 VCM")  /* _DDN: DOS Device Name */
    	Method (_STA, 0, NotSerialized)  /* _STA: Status */
    	{
    		Return (0x0F)
@@ -364,7 +364,7 @@
    			Package (0x02)
    			{
    				"compatible",
-					"giantec,gt9769-vcm"
+					"dongwoon,dw9768"
    			}
    		}
    	})
@@ -372,8 +372,8 @@
    Device (NVM0)
    {
    	Name (_HID, "PRP0001")  // _HID: Hardware ID
-		Name (_UID, 0x03)  // _UID: Unique ID
-		Name (_DDN, "GT9769 EEPROM")  // _DDN: DOS Device Name
+		Name (_UID, 0x01)  // _UID: Unique ID
+		Name (_DDN, "AT24 EEPROM")  // _DDN: DOS Device Name
    	Method (_STA, 0, NotSerialized)  // _STA: Status
    	{
    		Return (0x0F)
@@ -425,7 +425,7 @@
    			Package (0x02)
    			{
    				"compatible",
-					"giantec,gt9769-eeprom"
+					"atmel,24c1024"
    			}
    		}
    	})

[Daniel H Kang (Code Review)]

Daniel H Kang has uploaded a new patch set (#2) to the change originally created by Daniel Kang. ( https://review.coreboot.org/c/coreboot/+/42048 )

Change subject: UPTREAM: mb/google/volteer: Fix VCM and EEPROM configs for ov8856 world-facing camera
......................................................................

UPTREAM: mb/google/volteer: Fix VCM and EEPROM configs for ov8856
world-facing camera

Volteer proto 2 camera module's VCM and EEPROM configs.

BUG=b:158188369
BRANCH=none
TEST=Build and boot volteer proto 2 board. Start a camera app
and check user-facing camera functionalities.

Signed-off-by: Daniel Kang 
Change-Id: I792608f86a59b16545dfa4edf6508de7a444bb26
---
M src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl
1 file changed, 6 insertions(+), 6 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/42048/2

[Daniel H Kang (Code Review)]

Daniel H Kang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42048 )

Change subject: UPTREAM: mb/google/volteer: Fix VCM and EEPROM configs for ov8856 world-facing camera
......................................................................

Patch Set 2: Code-Review+1

[Wonkyu Kim (Code Review)]

Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42048 )

Change subject: UPTREAM: mb/google/volteer: Fix VCM and EEPROM configs for ov8856 world-facing camera
......................................................................

Patch Set 2: Code-Review+1

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42048 )

Change subject: UPTREAM: mb/google/volteer: Fix VCM and EEPROM configs for ov8856 world-facing camera
......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/c/coreboot/+/42048/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/42048/2//COMMIT_MSG@7 
PS2, Line 7: UPTREAM
This *is* upstream 😊 please remove

https://review.coreboot.org/c/coreboot/+/42048/2//COMMIT_MSG@10 
PS2, Line 10: Volteer proto 2 camera module's VCM and EEPROM configs.
suggestion: Current version of Volteer has a different camera than previous revisions and its MIPI camera ACPI definitions need to be updated to match.

Change in coreboot[master]: UPSTREAM: mb/google/volteer: Fix VCM and EEPROM configs for ov8856 wo...

[Daniel H Kang (Code Review)]

Daniel H Kang has uploaded a new patch set (#3) to the change originally created by Daniel Kang. ( https://review.coreboot.org/c/coreboot/+/42048 )

Change subject: UPSTREAM: mb/google/volteer: Fix VCM and EEPROM configs for ov8856 world-facing camera
......................................................................

UPSTREAM: mb/google/volteer: Fix VCM and EEPROM configs for ov8856
world-facing camera

Volteer proto 2 camera module's VCM and EEPROM configs.

BUG=b:158188369
BRANCH=none
TEST=Build and boot volteer proto 2 board. Start a camera app
and check user-facing camera functionalities.

Signed-off-by: Daniel Kang 
Change-Id: I792608f86a59b16545dfa4edf6508de7a444bb26
---
M src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl
1 file changed, 6 insertions(+), 6 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/42048/3

Change in coreboot[master]: mb/google/volteer: Fix VCM and EEPROM configs for ov8856 world-facing...

[Daniel H Kang (Code Review)]

Daniel H Kang has uploaded a new patch set (#4) to the change originally created by Daniel Kang. ( https://review.coreboot.org/c/coreboot/+/42048 )

Change subject: mb/google/volteer: Fix VCM and EEPROM configs for ov8856 world-facing camera
......................................................................

mb/google/volteer: Fix VCM and EEPROM configs for ov8856
world-facing camera

Volteer proto 2 camera module's VCM and EEPROM configs.

BUG=b:158188369
BRANCH=none
TEST=Build and boot volteer proto 2 board. Start a camera app
and check user-facing camera functionalities.

Signed-off-by: Daniel Kang 
Change-Id: I792608f86a59b16545dfa4edf6508de7a444bb26
---
M src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl
1 file changed, 6 insertions(+), 6 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/42048/4

Change in coreboot[master]: mb/google/volteer: Fix VCM and EEPROM configs for ov8856 world-facing...

[Daniel H Kang (Code Review)]

Daniel H Kang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42048 )

Change subject: mb/google/volteer: Fix VCM and EEPROM configs for ov8856 world-facing camera
......................................................................

Patch Set 4:

(2 comments)

https://review.coreboot.org/c/coreboot/+/42048/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/42048/2//COMMIT_MSG@7 
PS2, Line 7: UPTREAM
> This *is* upstream 😊 please remove

Done

https://review.coreboot.org/c/coreboot/+/42048/2//COMMIT_MSG@10 
PS2, Line 10: Volteer proto 2 camera module's VCM and EEPROM configs.
> suggestion: Current version of Volteer has a different camera than previous revisions and its MIPI c […]

Hi Tim,
The camera definitions are correct but only VCM and EEPROM configs were not matching to Volteer proto 2, and also proto 1 because the world-facing camera (RCAM) is the same for both revisions.

Change in coreboot[master]: mb/google/volteer: Fix VCM and EEPROM configs for ov8856 world-facing...

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42048 )

Change subject: mb/google/volteer: Fix VCM and EEPROM configs for ov8856 world-facing camera
......................................................................

Patch Set 4:

(2 comments)

https://review.coreboot.org/c/coreboot/+/42048/4//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/42048/4//COMMIT_MSG@8 
PS4, Line 8: world-facing camera
you can just remove the "world-facing camera" part

https://review.coreboot.org/c/coreboot/+/42048/4//COMMIT_MSG@10 
PS4, Line 10: Volteer proto 2 camera module's VCM and EEPROM configs.
Can you add something like the config was incorrect, and this updates it to the correct values?

Change in coreboot[master]: mb/google/volteer: Fix VCM and EEPROM configs for ov8856

[Daniel H Kang (Code Review)]

Daniel H Kang has uploaded a new patch set (#5) to the change originally created by Daniel Kang. ( https://review.coreboot.org/c/coreboot/+/42048 )

Change subject: mb/google/volteer: Fix VCM and EEPROM configs for ov8856
......................................................................

mb/google/volteer: Fix VCM and EEPROM configs for ov8856

Volteer proto 2 camera module's VCM and EEPROM configs.

BUG=b:158188369
BRANCH=none
TEST=Build and boot volteer proto 2 board. Start a camera app
and check user-facing camera functionalities.

Signed-off-by: Daniel Kang 
Change-Id: I792608f86a59b16545dfa4edf6508de7a444bb26
---
M src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl
1 file changed, 6 insertions(+), 6 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/42048/5

Change in coreboot[master]: mb/google/volteer: Change VCM and EEPROM configs for ov8856

[Daniel H Kang (Code Review)]

Daniel H Kang has uploaded a new patch set (#6) to the change originally created by Daniel Kang. ( https://review.coreboot.org/c/coreboot/+/42048 )

Change subject: mb/google/volteer: Change VCM and EEPROM configs for ov8856
......................................................................

mb/google/volteer: Change VCM and EEPROM configs for ov8856

TGL RVP and Volteer use ov8856 camera module from different vendors.
TGL RVP from Foxlink and Volteer from Sunny. ov8856 sensor is identical
for the two modules but VCM and EEPROM are different. Originally,
Volteer ACPI was set to align with Sunny module, GT9679. But it turned
out GT9679 is compatible with Foxlink's DW9768. So Volteer camera ACPI
configuration doesn't need to keep GT9679.

BUG=b:158188369
BRANCH=none
TEST=Build and boot volteer proto 2 board. Start a camera app
and check user-facing camera functionalities.

Signed-off-by: Daniel Kang 
Change-Id: I792608f86a59b16545dfa4edf6508de7a444bb26
---
M src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl
1 file changed, 6 insertions(+), 6 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/42048/6

Change in coreboot[master]: mb/google/volteer: Change VCM and EEPROM configs for ov8856

[Daniel H Kang (Code Review)]

Daniel H Kang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42048 )

Change subject: mb/google/volteer: Change VCM and EEPROM configs for ov8856
......................................................................

Patch Set 6:

(2 comments)

https://review.coreboot.org/c/coreboot/+/42048/4//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/42048/4//COMMIT_MSG@8 
PS4, Line 8: world-facing camera
> you can just remove the "world-facing camera" part

Done

https://review.coreboot.org/c/coreboot/+/42048/4//COMMIT_MSG@10 
PS4, Line 10: Volteer proto 2 camera module's VCM and EEPROM configs.
> Can you add something like the config was incorrect, and this updates it to the correct values?

Done

Change in coreboot[master]: mb/google/volteer: Change VCM and EEPROM configs for ov8856

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42048 )

Change subject: mb/google/volteer: Change VCM and EEPROM configs for ov8856
......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42048/6/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl:

https://review.coreboot.org/c/coreboot/+/42048/6/src/mainboard/google/voltee... 
PS6, Line 367: dw9768
In the linux kernel, I only see dw9714 and dw9807-vcm. It looks like the driver for dw9768 isn't upstreamed yet. Which driver does this bind to?

Change in coreboot[master]: mb/google/volteer: Change VCM and EEPROM configs for ov8856

[Daniel H Kang (Code Review)]

Daniel H Kang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42048 )

Change subject: mb/google/volteer: Change VCM and EEPROM configs for ov8856
......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42048/6/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl:

https://review.coreboot.org/c/coreboot/+/42048/6/src/mainboard/google/voltee... 
PS6, Line 367: dw9768
> In the linux kernel, I only see dw9714 and dw9807-vcm. […]

Yes. The code is still under review in the community. And it is back-ported to chromium gerrit.  https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/2....

Change in coreboot[master]: mb/google/volteer: Change VCM and EEPROM configs for ov8856

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42048 )

Change subject: mb/google/volteer: Change VCM and EEPROM configs for ov8856
......................................................................

Patch Set 6: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/42048/6/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl:

https://review.coreboot.org/c/coreboot/+/42048/6/src/mainboard/google/voltee... 
PS6, Line 367: dw9768
> Yes. The code is still under review in the community. And it is back-ported to chromium gerrit. […]

Thank you!

Change in coreboot[master]: mb/google/volteer: Change VCM and EEPROM configs for ov8856

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42048 )

Change subject: mb/google/volteer: Change VCM and EEPROM configs for ov8856
......................................................................

mb/google/volteer: Change VCM and EEPROM configs for ov8856

TGL RVP and Volteer use ov8856 camera module from different vendors.
TGL RVP from Foxlink and Volteer from Sunny. ov8856 sensor is identical
for the two modules but VCM and EEPROM are different. Originally,
Volteer ACPI was set to align with Sunny module, GT9679. But it turned
out GT9679 is compatible with Foxlink's DW9768. So Volteer camera ACPI
configuration doesn't need to keep GT9679.

BUG=b:158188369
BRANCH=none
TEST=Build and boot volteer proto 2 board. Start a camera app
and check user-facing camera functionalities.

Signed-off-by: Daniel Kang 
Change-Id: I792608f86a59b16545dfa4edf6508de7a444bb26
Reviewed-on: https://review.coreboot.org/c/coreboot/+/42048
Tested-by: build bot (Jenkins) 
Reviewed-by: Tim Wawrzynczak 
Reviewed-by: Daniel H Kang 
Reviewed-by: Wonkyu Kim 
---
M src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl
1 file changed, 6 insertions(+), 6 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Wonkyu Kim: Looks good to me, but someone else must approve
  Tim Wawrzynczak: Looks good to me, approved
  Daniel H Kang: Looks good to me, but someone else must approve

diff --git a/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl b/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl
index 777ab7a..a5756626 100644
--- a/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl
+++ b/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl
@@ -331,8 +331,8 @@
    Device (VCM0)
    {
    	Name (_HID, "PRP0001")  /* _HID: Hardware ID */
-		Name (_UID, 0x03)  /* _UID: Unique ID */
-		Name (_DDN, "GT9769 VCM")  /* _DDN: DOS Device Name */
+		Name (_UID, 0x00)  /* _UID: Unique ID */
+		Name (_DDN, "DW9768 VCM")  /* _DDN: DOS Device Name */
    	Method (_STA, 0, NotSerialized)  /* _STA: Status */
    	{
    		Return (0x0F)
@@ -364,7 +364,7 @@
    			Package (0x02)
    			{
    				"compatible",
-					"giantec,gt9769-vcm"
+					"dongwoon,dw9768"
    			}
    		}
    	})
@@ -372,8 +372,8 @@
    Device (NVM0)
    {
    	Name (_HID, "PRP0001")  // _HID: Hardware ID
-		Name (_UID, 0x03)  // _UID: Unique ID
-		Name (_DDN, "GT9769 EEPROM")  // _DDN: DOS Device Name
+		Name (_UID, 0x01)  // _UID: Unique ID
+		Name (_DDN, "AT24 EEPROM")  // _DDN: DOS Device Name
    	Method (_STA, 0, NotSerialized)  // _STA: Status
    	{
    		Return (0x0F)
@@ -425,7 +425,7 @@
    			Package (0x02)
    			{
    				"compatible",
-					"giantec,gt9769-eeprom"
+					"atmel,24c1024"
    			}
    		}
    	})