[S] Change in coreboot[main]: mb/google/brya/var/xol: Change touchpad I2C interrupt type to GPIO_INT

[SH Kim (Code Review)]

Attention is currently required from: Dinesh Gehlot, Edward Doan, Eric Lai, Jamie Chen, Kapil Porwal, Nick Vaccaro, Nick Vaccaro, Subrata Banik, YH Lin.

SH Kim has posted comments on this change by SH Kim. ( https://review.coreboot.org/c/coreboot/+/83346?usp=email )

Change subject: mb/google/brya/var/xol: Change touchpad I2C interrupt type to GPIO_INT
......................................................................

Patch Set 5:

(3 comments)

File src/mainboard/google/brya/variants/xol/gpio.c:

https://review.coreboot.org/c/coreboot/+/83346/comment/24fe8ec9_b64c1b86?usp... :
PS1, Line 123: 	PAD_CFG_GPI_INT_LOCK(GPP_F14, NONE, LEVEL, LOCK_CONFIG),
> I'm not sure where that clip came from, but the GPP_F14 gpio is not locked in mainboard/google/brya/ […]

LOCK_CONFIG for GPP_F14 has been removed from baseboard/brya due to this: https://partnerissuetracker.corp.google.com/issues/346917118#comment16

And I removed LOCK_CONFIG from this CL after that comment.

File src/mainboard/google/brya/variants/xol/gpio.c:

https://review.coreboot.org/c/coreboot/+/83346/comment/f77008a8_76217c13?usp... :
PS5, Line 128: LEVEL
> Isn't this signal active-low?

There is no LEVEL_LOW or INVERT option for PAD_CFG_GPI_INT macro. I think OS driver can set it's invert property by refering to the ACPI interrupt property from "ACPI_GPIO_IRQ_LEVEL_LOW_WAKE(GPP_F14)" in overridetree.cb.

File src/mainboard/google/brya/variants/xol/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/83346/comment/4c1a047f_828b9e2c?usp... :
PS1, Line 347: 				register "generic.detect" = "1"
> Won't this enable the interrupt? (IIRC, the touchpad is powered directly off of a power rail, so no  […]

Just had some test for the scenario you mentioned.
- Keep making touchpad input during booting with 5 times of "reboot" command and 5 times of ec reset
- With/without this change, I couldn't find such issue on my test.

From the test result, touchpad interrupt before kernel could be another story with the issue we are focussing on this change.