Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40232 )
Change subject: soc/intel/tigerlake/acpi: Fix typo ......................................................................
soc/intel/tigerlake/acpi: Fix typo
HSA -> HDA (High Definition Audio)
Change-Id: Ic0e6ad7b26105fdd6eca6cd11edcf2236e5c7123 Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/soc/intel/tigerlake/acpi/pci_irqs.asl 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/40232/1
diff --git a/src/soc/intel/tigerlake/acpi/pci_irqs.asl b/src/soc/intel/tigerlake/acpi/pci_irqs.asl index 7f632ba..62520b1 100644 --- a/src/soc/intel/tigerlake/acpi/pci_irqs.asl +++ b/src/soc/intel/tigerlake/acpi/pci_irqs.asl @@ -16,7 +16,7 @@ #include <soc/irq.h>
Name (PICP, Package () { - /* D31:HSA, SMBUS, TraceHUB */ + /* D31:HDA, SMBUS, TraceHUB */ Package(){0x001FFFFF, 3, 0, HDA_IRQ }, Package(){0x001FFFFF, 4, 0, SMBUS_IRQ }, Package(){0x001FFFFF, 7, 0, TRACEHUB_IRQ }, @@ -89,7 +89,7 @@ })
Name (PICN, Package () { - /* D31:HSA, SMBUS, TraceHUB*/ + /* D31:HDA, SMBUS, TraceHUB*/ Package () { 0x001FFFFF, 3, 0, 11 }, Package () { 0x001FFFFF, 4, 0, 11 }, Package () { 0x001FFFFF, 7, 0, 11 },
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40232 )
Change subject: soc/intel/tigerlake/acpi: Fix typo ......................................................................
Patch Set 1: Code-Review+2
Checked, this is the only place with this typo. Thanks!
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40232 )
Change subject: soc/intel/tigerlake/acpi: Fix typo ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/40232/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40232/1//COMMIT_MSG@7 PS1, Line 7: soc/intel/tigerlake/acpi: Fix typo
Fix typo in HDA in comment
Hello V Sowmya, build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Paul Menzel, Angel Pons, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40232
to look at the new patch set (#2).
Change subject: soc/intel/tigerlake/acpi: Fix typo in HDA in comment ......................................................................
soc/intel/tigerlake/acpi: Fix typo in HDA in comment
HSA -> HDA (High Definition Audio)
Change-Id: Ic0e6ad7b26105fdd6eca6cd11edcf2236e5c7123 Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/soc/intel/tigerlake/acpi/pci_irqs.asl 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/40232/2
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40232 )
Change subject: soc/intel/tigerlake/acpi: Fix typo in HDA in comment ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40232/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40232/1//COMMIT_MSG@7 PS1, Line 7: soc/intel/tigerlake/acpi: Fix typo
Fix typo in HDA in comment
Ack
Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40232 )
Change subject: soc/intel/tigerlake/acpi: Fix typo in HDA in comment ......................................................................
soc/intel/tigerlake/acpi: Fix typo in HDA in comment
HSA -> HDA (High Definition Audio)
Change-Id: Ic0e6ad7b26105fdd6eca6cd11edcf2236e5c7123 Signed-off-by: Subrata Banik subrata.banik@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/40232 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net --- M src/soc/intel/tigerlake/acpi/pci_irqs.asl 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved
diff --git a/src/soc/intel/tigerlake/acpi/pci_irqs.asl b/src/soc/intel/tigerlake/acpi/pci_irqs.asl index 7f632ba..62520b1 100644 --- a/src/soc/intel/tigerlake/acpi/pci_irqs.asl +++ b/src/soc/intel/tigerlake/acpi/pci_irqs.asl @@ -16,7 +16,7 @@ #include <soc/irq.h>
Name (PICP, Package () { - /* D31:HSA, SMBUS, TraceHUB */ + /* D31:HDA, SMBUS, TraceHUB */ Package(){0x001FFFFF, 3, 0, HDA_IRQ }, Package(){0x001FFFFF, 4, 0, SMBUS_IRQ }, Package(){0x001FFFFF, 7, 0, TRACEHUB_IRQ }, @@ -89,7 +89,7 @@ })
Name (PICN, Package () { - /* D31:HSA, SMBUS, TraceHUB*/ + /* D31:HDA, SMBUS, TraceHUB*/ Package () { 0x001FFFFF, 3, 0, 11 }, Package () { 0x001FFFFF, 4, 0, 11 }, Package () { 0x001FFFFF, 7, 0, 11 },
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40232 )
Change subject: soc/intel/tigerlake/acpi: Fix typo in HDA in comment ......................................................................
Patch Set 3:
Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3 Emulation targets: EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/2157 EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2156 EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2155
Please note: This test is under development and might not be accurate at all!