Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Subrata Banik. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55205 )
Change subject: mb/intel/adlrvp: Use device aliases ......................................................................
Patch Set 2:
(8 comments)
File src/mainboard/intel/adlrvp/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/55205/comment/3399877b_418f3745 PS2, Line 320: device pci 10.0 off end : device pci 10.1 off end : device pci 10.6 off end # THC0 : device pci 10.7 off end # THC1 chipset.cb only has the first two:
device pci 10.0 alias thc0 off end device pci 10.1 alias thc1 off end
https://review.coreboot.org/c/coreboot/+/55205/comment/fc6fa6a2_94dc8cb0 PS2, Line 324: device pci 11.0 off end : device pci 11.1 off end : device pci 11.2 off end : device pci 11.3 off end : device pci 11.4 off end : device pci 11.5 off end chipset.cb doesn't have any of these. Do these PCI devices exist at all?
https://review.coreboot.org/c/coreboot/+/55205/comment/7bddcd8a_509b3687 PS2, Line 331: device pci 12.5 off end chipset.cb doesn't have this
https://review.coreboot.org/c/coreboot/+/55205/comment/9e0d3644_19142ecb PS2, Line 334: device pci 13.1 off end chipset.cb doesn't have this
https://review.coreboot.org/c/coreboot/+/55205/comment/6dad0a6d_beeaacb3 PS2, Line 362: device pci 16.2 off end # CSME : device pci 16.3 off end # CSME These two devices don't appear in chipset.cb for some reason. On older platforms, these used to be IDE-R and KT, respectively.
https://review.coreboot.org/c/coreboot/+/55205/comment/549a8e89_92b3fd5d PS2, Line 317: chip drivers/usb/acpi : register "desc" = ""Root Hub"" : register "type" = "UPC_TYPE_HUB" : device usb 0.0 on : chip drivers/usb/acpi : register "desc" = ""Bluetooth"" : register "type" = "UPC_TYPE_INTERNAL" : device usb 2.9 on end : end : end : end chipset.cb also has a `chip drivers/usb/acpi` with stuff inside. Shouldn't this be updated too?
https://review.coreboot.org/c/coreboot/+/55205/comment/9e34c572_5d0d478d PS2, Line 352: device ref pch_espi on end alderlake chipset.cb already enables this:
device pci 1f.0 alias pch_espi on end
https://review.coreboot.org/c/coreboot/+/55205/comment/8dcab8c8_0de3dd38 PS2, Line 366: device ref fast_spi on end alderlake chipset.cb already enables this:
device pci 1f.5 alias fast_spi on end
-
Angel Pons (Code Review)