Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/57227 )
Change subject: mb/intel/kblrvp: Drop commented-out SD card config ......................................................................
mb/intel/kblrvp: Drop commented-out SD card config
This is most likely a copy-paste remnant, and will never be needed for RVP8: the SDXC device does not exist on PCH-H (and RVP8 uses a PCH-H).
Change-Id: I69059a88dcdb032beaab5fb03981dccbae0db02e Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/57227 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Michael Niewöhner foss@mniewoehner.de --- M src/mainboard/intel/kblrvp/variants/rvp8/overridetree.cb 1 file changed, 0 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Michael Niewöhner: Looks good to me, approved
diff --git a/src/mainboard/intel/kblrvp/variants/rvp8/overridetree.cb b/src/mainboard/intel/kblrvp/variants/rvp8/overridetree.cb index 17d4486..00690fa 100644 --- a/src/mainboard/intel/kblrvp/variants/rvp8/overridetree.cb +++ b/src/mainboard/intel/kblrvp/variants/rvp8/overridetree.cb @@ -155,9 +155,6 @@ .tdp_pl2_override = 25, }"
- # Use default SD card detect GPIO configuration - #register "sdcard_cd_gpio" = "GPP_D10" - device domain 0 on device pci 17.0 on end # SATA device pci 19.2 off end # I2C #4
1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one.