Jonathan Zhang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44091 )
Change subject: soc/intel/xeon_sp/cpx: configure STACK_SIZE ......................................................................
soc/intel/xeon_sp/cpx: configure STACK_SIZE
Before this change, we have this problem (boot log from DeltaLake config A server): Jumping to boot code at 0x00040000(0x755f6000) Stack overrun on CPU0 (address 0x7574a000 overwritten). Increase stack from current 4096 bytes ERROR: BUG ENCOUNTERED at file 'src/lib/stack.c', line 43 Linux version 4.16.18
Configure STACK_SIZE to make it larger to fix above problem.
Now, we have this boot log: BS: BS_PAYLOAD_LOAD exit times (exec / console): 326 / 21727 ms Jumping to boot code at 0x00040000(0x752f2000) CPU0: stack: 0x75746000 - 0x7574a000, lowest used address 0x7574681c, stack used: 14308 bytes Linux version 4.16.18
TESTED=booted YV3 config A to target OS.
Signed-off-by: Jonathan Zhang jonzhang@fb.com
Change-Id: Ia04a3ee0cd37177ecab65469855a1cf920742458 --- M src/soc/intel/xeon_sp/cpx/Kconfig 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/44091/1
diff --git a/src/soc/intel/xeon_sp/cpx/Kconfig b/src/soc/intel/xeon_sp/cpx/Kconfig index 93098e8..0df9847 100644 --- a/src/soc/intel/xeon_sp/cpx/Kconfig +++ b/src/soc/intel/xeon_sp/cpx/Kconfig @@ -56,6 +56,10 @@ hex default 0x80000
+config STACK_SIZE + hex + default 0x4000 + config FSP_TEMP_RAM_SIZE hex depends on FSP_USES_CB_STACK
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44091 )
Change subject: soc/intel/xeon_sp/cpx: configure STACK_SIZE ......................................................................
Patch Set 1: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/44091/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44091/1//COMMIT_MSG@21 PS1, Line 21: 14308 note to self: there's some headroom, new maximum is 16384
https://review.coreboot.org/c/coreboot/+/44091/1//COMMIT_MSG@27 PS1, Line 27: nit: no blank line between sign-off and change-id
Patrick Georgi has uploaded a new patch set (#2) to the change originally created by Jonathan Zhang. ( https://review.coreboot.org/c/coreboot/+/44091 )
Change subject: soc/intel/xeon_sp/cpx: configure STACK_SIZE ......................................................................
soc/intel/xeon_sp/cpx: configure STACK_SIZE
Before this change, we have this problem (boot log from DeltaLake config A server): Jumping to boot code at 0x00040000(0x755f6000) Stack overrun on CPU0 (address 0x7574a000 overwritten). Increase stack from current 4096 bytes ERROR: BUG ENCOUNTERED at file 'src/lib/stack.c', line 43 Linux version 4.16.18
Configure STACK_SIZE to make it larger to fix above problem.
Now, we have this boot log: BS: BS_PAYLOAD_LOAD exit times (exec / console): 326 / 21727 ms Jumping to boot code at 0x00040000(0x752f2000) CPU0: stack: 0x75746000 - 0x7574a000, lowest used address 0x7574681c, stack used: 14308 bytes Linux version 4.16.18
TESTED=booted YV3 config A to target OS.
Signed-off-by: Jonathan Zhang jonzhang@fb.com Change-Id: Ia04a3ee0cd37177ecab65469855a1cf920742458 --- M src/soc/intel/xeon_sp/cpx/Kconfig 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/44091/2
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44091 )
Change subject: soc/intel/xeon_sp/cpx: configure STACK_SIZE ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44091/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44091/1//COMMIT_MSG@27 PS1, Line 27:
nit: no blank line between sign-off and change-id
Done
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44091 )
Change subject: soc/intel/xeon_sp/cpx: configure STACK_SIZE ......................................................................
soc/intel/xeon_sp/cpx: configure STACK_SIZE
Before this change, we have this problem (boot log from DeltaLake config A server): Jumping to boot code at 0x00040000(0x755f6000) Stack overrun on CPU0 (address 0x7574a000 overwritten). Increase stack from current 4096 bytes ERROR: BUG ENCOUNTERED at file 'src/lib/stack.c', line 43 Linux version 4.16.18
Configure STACK_SIZE to make it larger to fix above problem.
Now, we have this boot log: BS: BS_PAYLOAD_LOAD exit times (exec / console): 326 / 21727 ms Jumping to boot code at 0x00040000(0x752f2000) CPU0: stack: 0x75746000 - 0x7574a000, lowest used address 0x7574681c, stack used: 14308 bytes Linux version 4.16.18
TESTED=booted YV3 config A to target OS.
Signed-off-by: Jonathan Zhang jonzhang@fb.com Change-Id: Ia04a3ee0cd37177ecab65469855a1cf920742458 Reviewed-on: https://review.coreboot.org/c/coreboot/+/44091 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/soc/intel/xeon_sp/cpx/Kconfig 1 file changed, 4 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/soc/intel/xeon_sp/cpx/Kconfig b/src/soc/intel/xeon_sp/cpx/Kconfig index 93098e8..0df9847 100644 --- a/src/soc/intel/xeon_sp/cpx/Kconfig +++ b/src/soc/intel/xeon_sp/cpx/Kconfig @@ -56,6 +56,10 @@ hex default 0x80000
+config STACK_SIZE + hex + default 0x4000 + config FSP_TEMP_RAM_SIZE hex depends on FSP_USES_CB_STACK
-
Angel Pons (Code Review) -
Jonathan Zhang (Code Review)
-
Patrick Georgi (Code Review)