Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35500 )
Change subject: sc7180: Add UART support
......................................................................
Patch Set 35:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35500/26/src/soc/qualcomm/sc7180/qu...
File src/soc/qualcomm/sc7180/qupv3_uart.c:
https://review.coreboot.org/c/coreboot/+/35500/26/src/soc/qualcomm/sc7180/qu...
PS26, Line 65: #ifndef __VERSTAGE__
This change is made by considering the case, if firmware is updated and to load the updated firmware […]
No, please don't do that. We don't want to reload the firmware in every stage just in case. If we ever ship an RW update that needs to fix QUP firmware (which I hope should be unlikely after shipping), we will address that explicitly (we need to anyway because we would need to re-run qupv3_fw_init() and then reload all the QUPs, right?).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35500
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6494daa108197c030577ac86dab71f9ca6c21bdb
Gerrit-Change-Number: 35500
Gerrit-PatchSet: 35
Gerrit-Owner: mturney mturney
mturney@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Akash Asthana
akashast@qualcomm.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Roja Rani Yarubandi
c_rojay@qualcomm.corp-partner.google.com
Gerrit-CC: Satya Priya Kakitapalli
c_skakit@qualcomm.corp-partner.google.com
Gerrit-Comment-Date: Thu, 06 Feb 2020 01:55:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Roja Rani Yarubandi
c_rojay@qualcomm.corp-partner.google.com
Gerrit-MessageType: comment