Change in coreboot[master]: mb/google/hatch: Configure SATA DEVSLP pad reset config to PLT_RST
Aamir Bohra has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35307 )
Change subject: mb/google/hatch: Configure SATA DEVSLP pad reset config to PLT_RST ......................................................................
mb/google/hatch: Configure SATA DEVSLP pad reset config to PLT_RST
Change-Id: Ia12174e3254153dbca55070f5daf84fd8aac51d0 Signed-off-by: Aamir Bohra aamir.bohra@intel.com --- M src/mainboard/google/hatch/variants/baseboard/devicetree.cb 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/35307/1
diff --git a/src/mainboard/google/hatch/variants/baseboard/devicetree.cb b/src/mainboard/google/hatch/variants/baseboard/devicetree.cb index 8b5fc1a..866a2e5 100644 --- a/src/mainboard/google/hatch/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/hatch/variants/baseboard/devicetree.cb @@ -24,6 +24,8 @@ register "SataMode" = "Sata_AHCI" register "SataPortsEnable[1]" = "1" register "SataPortsDevSlp[1]" = "1" + # Configure devslp pad reset to PLT_RST + register "SataPortsDevSlpResetConfig[1]" = "5" register "satapwroptimize" = "1" # Enable System Agent dynamic frequency register "SaGv" = "SaGv_Enabled"
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35307 )
Change subject: mb/google/hatch: Configure SATA DEVSLP pad reset config to PLT_RST ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35307/3/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/35307/3/src/mainboard/google/hatch/... PS3, Line 28: 5 Could we get macro for this? (like SataMode has Sata_AHCI above?) RESET_PLTRST ? or something like that?
Hello Subrata Banik, Tim Wawrzynczak, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35307
to look at the new patch set (#4).
Change subject: mb/google/hatch: Configure SATA DEVSLP pad reset config to PLT_RST ......................................................................
mb/google/hatch: Configure SATA DEVSLP pad reset config to PLT_RST
BUG=b:133000685
Change-Id: Ia12174e3254153dbca55070f5daf84fd8aac51d0 Signed-off-by: Aamir Bohra aamir.bohra@intel.com --- M src/mainboard/google/hatch/variants/baseboard/devicetree.cb 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/35307/4
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35307 )
Change subject: mb/google/hatch: Configure SATA DEVSLP pad reset config to PLT_RST ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35307/3/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/35307/3/src/mainboard/google/hatch/... PS3, Line 28: 5
Could we get macro for this? (like SataMode has Sata_AHCI above?) RESET_PLTRST ? or something like […]
Ok, Done.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35307 )
Change subject: mb/google/hatch: Configure SATA DEVSLP pad reset config to PLT_RST ......................................................................
Patch Set 4: Code-Review+2
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35307 )
Change subject: mb/google/hatch: Configure SATA DEVSLP pad reset config to PLT_RST ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35307/3/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/35307/3/src/mainboard/google/hatch/... PS3, Line 28: 5
Ok, Done.
Done
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35307 )
Change subject: mb/google/hatch: Configure SATA DEVSLP pad reset config to PLT_RST ......................................................................
Patch Set 4: Code-Review+2
V Sowmya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35307 )
Change subject: mb/google/hatch: Configure SATA DEVSLP pad reset config to PLT_RST ......................................................................
Patch Set 4: Code-Review+2
Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35307 )
Change subject: mb/google/hatch: Configure SATA DEVSLP pad reset config to PLT_RST ......................................................................
mb/google/hatch: Configure SATA DEVSLP pad reset config to PLT_RST
BUG=b:133000685
Change-Id: Ia12174e3254153dbca55070f5daf84fd8aac51d0 Signed-off-by: Aamir Bohra aamir.bohra@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/35307 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-by: Subrata Banik subrata.banik@intel.com Reviewed-by: V Sowmya v.sowmya@intel.com --- M src/mainboard/google/hatch/variants/baseboard/devicetree.cb 1 file changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Subrata Banik: Looks good to me, approved V Sowmya: Looks good to me, approved Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/mainboard/google/hatch/variants/baseboard/devicetree.cb b/src/mainboard/google/hatch/variants/baseboard/devicetree.cb index 8b5fc1a..7382209 100644 --- a/src/mainboard/google/hatch/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/hatch/variants/baseboard/devicetree.cb @@ -24,6 +24,8 @@ register "SataMode" = "Sata_AHCI" register "SataPortsEnable[1]" = "1" register "SataPortsDevSlp[1]" = "1" + # Configure devslp pad reset to PLT_RST + register "SataPortsDevSlpResetConfig[1]" = "SataDevSlpPlatformReset" register "satapwroptimize" = "1" # Enable System Agent dynamic frequency register "SaGv" = "SaGv_Enabled"
-
Aamir Bohra (Code Review) -
Furquan Shaikh (Code Review)
-
Subrata Banik (Code Review)
-
Tim Wawrzynczak (Code Review)
-
V Sowmya (Code Review)