Change in coreboot[master]: mb/lenovo/{x230, x230s}: Disable SuperSpeed capabilities for wwan usb

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Bill XIE (Code Review)

18 May 2020 18 May '20

9:42 a.m.

Bill XIE has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41505 )

Change subject: mb/lenovo/{x230, x230s}: Disable SuperSpeed capabilities for wwan usb ......................................................................

mb/lenovo/{x230, x230s}: Disable SuperSpeed capabilities for wwan usb

Although on ThinkPads with Panther Point PCH the usb port inside wwan socket is usually wired to XHCI, it has actually no SuperSpeed lines, so maybe it is okay to disable SuperSpeed capabilities, and wire them to EHCI #2 by making use of XUSB2PRM and USB3PRM.

This applies to both variants of x230 and t430s, and should to X1 Carbon Gen1, which I do not possess.

Change-Id: Ia8d27be84e4dbfa0efed506b9fc010e7f4d6ba23 Signed-off-by: Bill XIE persmule@hardenedlinux.org --- M src/mainboard/lenovo/x230/devicetree.cb 1 file changed, 3 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/41505/1

diff --git a/src/mainboard/lenovo/x230/devicetree.cb b/src/mainboard/lenovo/x230/devicetree.cb index 3a8e5fe..b4247d1 100644 --- a/src/mainboard/lenovo/x230/devicetree.cb +++ b/src/mainboard/lenovo/x230/devicetree.cb @@ -58,8 +58,9 @@ register "gen2_dec" = "0x0c15e1" register "gen4_dec" = "0x0c06a1"

- register "xhci_switchable_ports" = "0xf" - register "superspeed_capable_ports" = "0xf" + # Wire port 4 (wwan usb) to ehci for it lacks superspeed components + register "xhci_switchable_ports" = "0x7" + register "superspeed_capable_ports" = "0x7" register "xhci_overcurrent_mapping" = "0x4000201"

# Enable zero-based linear PCIe root port functions

Attachments:

attachment.htm (text/html — 3.5 KB)

Show replies by date

Bill XIE (Code Review)

18 May 18 May

10:16 a.m.

Hello Alexander Couzens, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/41505

to look at the new patch set (#2).

Change subject: mb/lenovo/{x230, x230s}: Disable SuperSpeed capabilities for wwan usb ......................................................................

mb/lenovo/{x230, x230s}: Disable SuperSpeed capabilities for wwan usb

This applies to both variants of x230 and t430s, and should to X1 Carbon Gen1, which I do not possess, as well.

Change-Id: Ia8d27be84e4dbfa0efed506b9fc010e7f4d6ba23 Signed-off-by: Bill XIE persmule@hardenedlinux.org --- M src/mainboard/lenovo/x230/devicetree.cb 1 file changed, 3 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/41505/2

Bill XIE (Code Review)

10:29 a.m.

Hello build bot (Jenkins), Alexander Couzens, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/41505

to look at the new patch set (#3).

Change subject: mb/lenovo/{x230, x230s}: Disable SuperSpeed capabilities for wwan usb ......................................................................

mb/lenovo/{x230, x230s}: Disable SuperSpeed capabilities for wwan usb

This applies to both variants of x230 and t430s, and should to X1 Carbon Gen1, which I do not possess, as well.

Change-Id: Ia8d27be84e4dbfa0efed506b9fc010e7f4d6ba23 Signed-off-by: Bill XIE persmule@hardenedlinux.org --- M src/mainboard/lenovo/x230/devicetree.cb 1 file changed, 3 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/41505/3

Angel Pons (Code Review)

19 May 19 May

3:59 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41505 )

Change subject: mb/lenovo/{x230, x230s}: Disable SuperSpeed capabilities for wwan usb ......................................................................

Patch Set 6: Code-Review+1

(3 comments)

https://review.coreboot.org/c/coreboot/+/41505/6//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/41505/6//COMMIT_MSG@7 PS6, Line 7: usb USB

https://review.coreboot.org/c/coreboot/+/41505/6//COMMIT_MSG@7 PS6, Line 7: wwan WWAN

https://review.coreboot.org/c/coreboot/+/41505/6/src/mainboard/lenovo/x230/d... File src/mainboard/lenovo/x230/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/41505/6/src/mainboard/lenovo/x230/d... PS6, Line 61: Wire port 4 (wwan usb) to ehci for it lacks superspeed components Maybe say:

Do not enable xHCI Port 4 since WWAN USB is EHCI-only

-- To view, visit https://review.coreboot.org/c/coreboot/+/41505 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia8d27be84e4dbfa0efed506b9fc010e7f4d6ba23 Gerrit-Change-Number: 41505 Gerrit-PatchSet: 6 Gerrit-Owner: Bill XIE persmule@hardenedlinux.org Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 19 May 2020 15:59:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Bill XIE (Code Review)

20 May 20 May

2:27 p.m.

Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41505 )

Change subject: mb/lenovo/{x230, x230s}: Disable SuperSpeed capabilities for wwan usb ......................................................................

Patch Set 6:

(2 comments)

https://review.coreboot.org/c/coreboot/+/41505/6//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/41505/6//COMMIT_MSG@7 PS6, Line 7: usb

...

USB

Done

https://review.coreboot.org/c/coreboot/+/41505/6//COMMIT_MSG@7 PS6, Line 7: wwan

...

WWAN

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/41505 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia8d27be84e4dbfa0efed506b9fc010e7f4d6ba23 Gerrit-Change-Number: 41505 Gerrit-PatchSet: 6 Gerrit-Owner: Bill XIE persmule@hardenedlinux.org Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 20 May 2020 14:27:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Bill XIE (Code Review)

2:30 p.m.

New subject: Change in coreboot[master]: mb/lenovo/{x230, x230s}: Disable SuperSpeed capabilities for WWAN USB

Hello build bot (Jenkins), Angel Pons, Alexander Couzens, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/41505

to look at the new patch set (#7).

Change subject: mb/lenovo/{x230, x230s}: Disable SuperSpeed capabilities for WWAN USB ......................................................................

mb/lenovo/{x230, x230s}: Disable SuperSpeed capabilities for WWAN USB

This applies to both variants of x230 and t430s, and should to X1 Carbon Gen1, which I do not possess, as well.

Change-Id: Ia8d27be84e4dbfa0efed506b9fc010e7f4d6ba23 Signed-off-by: Bill XIE persmule@hardenedlinux.org --- M src/mainboard/lenovo/x230/devicetree.cb 1 file changed, 3 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/41505/7

-- To view, visit https://review.coreboot.org/c/coreboot/+/41505 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia8d27be84e4dbfa0efed506b9fc010e7f4d6ba23 Gerrit-Change-Number: 41505 Gerrit-PatchSet: 7 Gerrit-Owner: Bill XIE persmule@hardenedlinux.org Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Bill XIE (Code Review)

2:35 p.m.

New subject: Change in coreboot[master]: mb/lenovo/{x230, x230s}: Disable SuperSpeed capabilities for WWAN USB

Hello build bot (Jenkins), Angel Pons, Alexander Couzens, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/41505

to look at the new patch set (#8).

Change subject: mb/lenovo/{x230, x230s}: Disable SuperSpeed capabilities for WWAN USB ......................................................................

mb/lenovo/{x230, x230s}: Disable SuperSpeed capabilities for WWAN USB

This applies to both variants of x230 and t430s, and should to X1 Carbon Gen1, which I do not possess, as well.

Change-Id: Ia8d27be84e4dbfa0efed506b9fc010e7f4d6ba23 Signed-off-by: Bill XIE persmule@hardenedlinux.org --- M src/mainboard/lenovo/x230/devicetree.cb 1 file changed, 3 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/41505/8

-- To view, visit https://review.coreboot.org/c/coreboot/+/41505 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia8d27be84e4dbfa0efed506b9fc010e7f4d6ba23 Gerrit-Change-Number: 41505 Gerrit-PatchSet: 8 Gerrit-Owner: Bill XIE persmule@hardenedlinux.org Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Bill XIE (Code Review)

2:36 p.m.

New subject: Change in coreboot[master]: mb/lenovo/{x230, x230s}: Disable SuperSpeed capabilities for WWAN USB

Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41505 )

Change subject: mb/lenovo/{x230, x230s}: Disable SuperSpeed capabilities for WWAN USB ......................................................................

Patch Set 8:

(1 comment)

https://review.coreboot.org/c/coreboot/+/41505/6/src/mainboard/lenovo/x230/d... File src/mainboard/lenovo/x230/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/41505/6/src/mainboard/lenovo/x230/d... PS6, Line 61: Wire port 4 (wwan usb) to ehci for it lacks superspeed components

...

Maybe say: […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/41505 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia8d27be84e4dbfa0efed506b9fc010e7f4d6ba23 Gerrit-Change-Number: 41505 Gerrit-PatchSet: 8 Gerrit-Owner: Bill XIE persmule@hardenedlinux.org Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 20 May 2020 14:36:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Alexander Couzens (Code Review)

10:36 p.m.

New subject: Change in coreboot[master]: mb/lenovo/{x230, x230s}: Disable SuperSpeed capabilities for WWAN USB

Alexander Couzens has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41505 )

Change subject: mb/lenovo/{x230, x230s}: Disable SuperSpeed capabilities for WWAN USB ......................................................................

Patch Set 8:

(1 comment)

https://review.coreboot.org/c/coreboot/+/41505/8/src/mainboard/lenovo/x230/d... File src/mainboard/lenovo/x230/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/41505/8/src/mainboard/lenovo/x230/d... PS8, Line 61: # Do not enable xHCI Port 4 since WWAN USB is EHCI-only Can you write which ports has USB3 instead?

-- To view, visit https://review.coreboot.org/c/coreboot/+/41505 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia8d27be84e4dbfa0efed506b9fc010e7f4d6ba23 Gerrit-Change-Number: 41505 Gerrit-PatchSet: 8 Gerrit-Owner: Bill XIE persmule@hardenedlinux.org Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 20 May 2020 22:36:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Angel Pons (Code Review)

11:13 p.m.

New subject: Change in coreboot[master]: mb/lenovo/{x230, x230s}: Disable SuperSpeed capabilities for WWAN USB

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41505 )

Change subject: mb/lenovo/{x230, x230s}: Disable SuperSpeed capabilities for WWAN USB ......................................................................

Patch Set 8:

(1 comment)

https://review.coreboot.org/c/coreboot/+/41505/8/src/mainboard/lenovo/x230/d... File src/mainboard/lenovo/x230/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/41505/8/src/mainboard/lenovo/x230/d... PS8, Line 61: # Do not enable xHCI Port 4 since WWAN USB is EHCI-only

...

Can you write which ports has USB3 instead?

The remaining three, as per schematics?

-- To view, visit https://review.coreboot.org/c/coreboot/+/41505 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia8d27be84e4dbfa0efed506b9fc010e7f4d6ba23 Gerrit-Change-Number: 41505 Gerrit-PatchSet: 8 Gerrit-Owner: Bill XIE persmule@hardenedlinux.org Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 20 May 2020 23:13:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Alexander Couzens lynxis@fe80.eu Gerrit-MessageType: comment

Angel Pons (Code Review)

11:13 p.m.

New subject: Change in coreboot[master]: mb/lenovo/{x230, x230s}: Disable SuperSpeed capabilities for WWAN USB

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41505 )

Change subject: mb/lenovo/{x230, x230s}: Disable SuperSpeed capabilities for WWAN USB ......................................................................

Patch Set 8: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/41505 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia8d27be84e4dbfa0efed506b9fc010e7f4d6ba23 Gerrit-Change-Number: 41505 Gerrit-PatchSet: 8 Gerrit-Owner: Bill XIE persmule@hardenedlinux.org Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 20 May 2020 23:13:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Alexander Couzens (Code Review)

21 May 21 May

10:48 p.m.

New subject: Change in coreboot[master]: mb/lenovo/{x230, x230s}: Disable SuperSpeed capabilities for WWAN USB

Alexander Couzens has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41505 )

Change subject: mb/lenovo/{x230, x230s}: Disable SuperSpeed capabilities for WWAN USB ......................................................................

Patch Set 8: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/41505/8/src/mainboard/lenovo/x230/d... File src/mainboard/lenovo/x230/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/41505/8/src/mainboard/lenovo/x230/d... PS8, Line 61: # Do not enable xHCI Port 4 since WWAN USB is EHCI-only

...

The remaining three, as per schematics?

yes.

-- To view, visit https://review.coreboot.org/c/coreboot/+/41505 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia8d27be84e4dbfa0efed506b9fc010e7f4d6ba23 Gerrit-Change-Number: 41505 Gerrit-PatchSet: 8 Gerrit-Owner: Bill XIE persmule@hardenedlinux.org Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 21 May 2020 22:48:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Comment-In-Reply-To: Alexander Couzens lynxis@fe80.eu Gerrit-MessageType: comment

Paul Menzel (Code Review)

25 May 25 May

9:06 a.m.

New subject: Change in coreboot[master]: mb/lenovo/{x230, x230s}: Disable SuperSpeed capabilities for WWAN USB

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41505 )

Change subject: mb/lenovo/{x230, x230s}: Disable SuperSpeed capabilities for WWAN USB ......................................................................

Patch Set 10:

(1 comment)

https://review.coreboot.org/c/coreboot/+/41505/10//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/41505/10//COMMIT_MSG@14 PS10, Line 14: and t430s How it’s mentioned here, I’d expect the commit to change the T430s in some way.

-- To view, visit https://review.coreboot.org/c/coreboot/+/41505 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia8d27be84e4dbfa0efed506b9fc010e7f4d6ba23 Gerrit-Change-Number: 41505 Gerrit-PatchSet: 10 Gerrit-Owner: Bill XIE persmule@hardenedlinux.org Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 25 May 2020 09:06:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Bill XIE (Code Review)

26 May 26 May

9:48 a.m.

New subject: Change in coreboot[master]: mb/lenovo/{x230, x230s}: Disable SuperSpeed capabilities for WWAN USB

Hello build bot (Jenkins), Angel Pons, Alexander Couzens, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/41505

to look at the new patch set (#11).

Change subject: mb/lenovo/{x230, x230s}: Disable SuperSpeed capabilities for WWAN USB ......................................................................

mb/lenovo/{x230, x230s}: Disable SuperSpeed capabilities for WWAN USB

This applies to both variants of x230.

Change-Id: Ia8d27be84e4dbfa0efed506b9fc010e7f4d6ba23 Signed-off-by: Bill XIE persmule@hardenedlinux.org --- M 3rdparty/libgfxinit M src/mainboard/lenovo/x230/devicetree.cb 2 files changed, 4 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/41505/11

-- To view, visit https://review.coreboot.org/c/coreboot/+/41505 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia8d27be84e4dbfa0efed506b9fc010e7f4d6ba23 Gerrit-Change-Number: 41505 Gerrit-PatchSet: 11 Gerrit-Owner: Bill XIE persmule@hardenedlinux.org Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Bill XIE (Code Review)

9:52 a.m.

New subject: Change in coreboot[master]: mb/lenovo/{x230, x230s}: Disable SuperSpeed capabilities for WWAN USB

Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41505 )

Change subject: mb/lenovo/{x230, x230s}: Disable SuperSpeed capabilities for WWAN USB ......................................................................

Patch Set 11:

(1 comment)

https://review.coreboot.org/c/coreboot/+/41505/10//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/41505/10//COMMIT_MSG@14 PS10, Line 14: and t430s

...

How it’s mentioned here, I’d expect the commit to change the T430s in some way.

Removed. Actually, it is almost done on T430s, by me, though probably committed dirtily. I mentioned it just because it may be widespread among ThinkPads.

-- To view, visit https://review.coreboot.org/c/coreboot/+/41505 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia8d27be84e4dbfa0efed506b9fc010e7f4d6ba23 Gerrit-Change-Number: 41505 Gerrit-PatchSet: 11 Gerrit-Owner: Bill XIE persmule@hardenedlinux.org Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 26 May 2020 09:52:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Patrick Rudolph (Code Review)

6 Jun 6 Jun

6:11 a.m.

New subject: Change in coreboot[master]: mb/lenovo/{x230, x230s}: Disable SuperSpeed capabilities for WWAN USB

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41505 )

Change subject: mb/lenovo/{x230, x230s}: Disable SuperSpeed capabilities for WWAN USB ......................................................................

Patch Set 15: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/41505 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia8d27be84e4dbfa0efed506b9fc010e7f4d6ba23 Gerrit-Change-Number: 41505 Gerrit-PatchSet: 15 Gerrit-Owner: Bill XIE persmule@hardenedlinux.org Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sat, 06 Jun 2020 06:11:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Bill XIE (Code Review)

24 Jun 24 Jun

6:21 a.m.

New subject: Change in coreboot[master]: mb/lenovo/{x230, x230s}: Disable SuperSpeed capabilities for WWAN USB

Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41505 )

Change subject: mb/lenovo/{x230, x230s}: Disable SuperSpeed capabilities for WWAN USB ......................................................................

Patch Set 19:

(1 comment)

https://review.coreboot.org/c/coreboot/+/41505/8/src/mainboard/lenovo/x230/d... File src/mainboard/lenovo/x230/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/41505/8/src/mainboard/lenovo/x230/d... PS8, Line 61: # Do not enable xHCI Port 4 since WWAN USB is EHCI-only

...

yes.

The port mapping is commented in variants/x230s/early_init.c.

-- To view, visit https://review.coreboot.org/c/coreboot/+/41505 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia8d27be84e4dbfa0efed506b9fc010e7f4d6ba23 Gerrit-Change-Number: 41505 Gerrit-PatchSet: 19 Gerrit-Owner: Bill XIE persmule@hardenedlinux.org Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 24 Jun 2020 06:21:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Comment-In-Reply-To: Alexander Couzens lynxis@fe80.eu Gerrit-MessageType: comment

Patrick Georgi (Code Review)

29 Jun 29 Jun

3:51 p.m.

New subject: Change in coreboot[master]: mb/lenovo/{x230, x230s}: Disable SuperSpeed capabilities for WWAN USB

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41505 )

Change subject: mb/lenovo/{x230, x230s}: Disable SuperSpeed capabilities for WWAN USB ......................................................................

mb/lenovo/{x230, x230s}: Disable SuperSpeed capabilities for WWAN USB

This applies to both variants of x230.

Change-Id: Ia8d27be84e4dbfa0efed506b9fc010e7f4d6ba23 Signed-off-by: Bill XIE persmule@hardenedlinux.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/41505 Reviewed-by: Patrick Rudolph siro@das-labor.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/lenovo/x230/devicetree.cb 1 file changed, 3 insertions(+), 2 deletions(-)

Approvals: build bot (Jenkins): Verified Patrick Rudolph: Looks good to me, approved

diff --git a/src/mainboard/lenovo/x230/devicetree.cb b/src/mainboard/lenovo/x230/devicetree.cb index 3a8e5fe..085b4e1 100644 --- a/src/mainboard/lenovo/x230/devicetree.cb +++ b/src/mainboard/lenovo/x230/devicetree.cb @@ -58,8 +58,9 @@ register "gen2_dec" = "0x0c15e1" register "gen4_dec" = "0x0c06a1"

- register "xhci_switchable_ports" = "0xf" - register "superspeed_capable_ports" = "0xf" + # Do not enable xHCI Port 4 since WWAN USB is EHCI-only + register "xhci_switchable_ports" = "0x7" + register "superspeed_capable_ports" = "0x7" register "xhci_overcurrent_mapping" = "0x4000201"

# Enable zero-based linear PCIe root port functions

-- To view, visit https://review.coreboot.org/c/coreboot/+/41505 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia8d27be84e4dbfa0efed506b9fc010e7f4d6ba23 Gerrit-Change-Number: 41505 Gerrit-PatchSet: 21 Gerrit-Owner: Bill XIE persmule@hardenedlinux.org Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1556

days inactive

1598

days old

coreboot-gerrit@coreboot.org

17 comments

6 participants

tags (0)

participants (6)

Alexander Couzens (Code Review)
Angel Pons (Code Review)
Bill XIE (Code Review)
Patrick Georgi (Code Review)
Patrick Rudolph (Code Review)
Paul Menzel (Code Review)