Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/63216 )
Change subject: soc/amd/common/block/i2c/i23c_pad_def.h: fix off by one in define ......................................................................
soc/amd/common/block/i2c/i23c_pad_def.h: fix off by one in define
I23C_PAD_CTRL_SLEW_N_SHIFT is 6 and not 7 which matches both with the PPR #57243 revision 1.53 and with I23C_PAD_CTRL_SLEW_N_MASK which covers both bits 6 and 7.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: I622717bebaffe34b6df5e578b082dc10e2a98256 Reviewed-on: https://review.coreboot.org/c/coreboot/+/63216 Reviewed-by: Karthik Ramasubramanian kramasub@google.com Reviewed-by: Raul Rangel rrangel@chromium.org Reviewed-by: Fred Reitberger reitbergerfred@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/amd/common/block/i2c/i23c_pad_def.h 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Raul Rangel: Looks good to me, approved Karthik Ramasubramanian: Looks good to me, approved Fred Reitberger: Looks good to me, but someone else must approve
diff --git a/src/soc/amd/common/block/i2c/i23c_pad_def.h b/src/soc/amd/common/block/i2c/i23c_pad_def.h index 8973a0c..ae7f3d6 100644 --- a/src/soc/amd/common/block/i2c/i23c_pad_def.h +++ b/src/soc/amd/common/block/i2c/i23c_pad_def.h @@ -17,7 +17,7 @@ #define I23C_PAD_CTRL_RX_SEL_OFF (0 << I23C_PAD_CTRL_RX_SHIFT) #define I23C_PAD_CTRL_RX_SEL_ON (3 << I23C_PAD_CTRL_RX_SHIFT) #define I23C_PAD_CTRL_SLEW_N_MASK (BIT(6) | BIT(7)) -#define I23C_PAD_CTRL_SLEW_N_SHIFT 7 +#define I23C_PAD_CTRL_SLEW_N_SHIFT 6 #define I23C_PAD_CTRL_SLEW_N_DIS (0 << I23C_PAD_CTRL_SLEW_N_SHIFT) #define I23C_PAD_CTRL_SLEW_N_FAST (3 << I23C_PAD_CTRL_SLEW_N_SHIFT) #define I23C_PAD_CTRL_FALLSLEW_SEL_MASK (BIT(8) | BIT(9))