Attention is currently required from: Henry Sun, Paul Menzel.
Tao Xia has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55035 )
Change subject: mb/google/dedede/var/sasukette: Modify the touch pad I2C address
......................................................................
Patch Set 4:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/55035/comment/42998829_1ad56ee2
PS3, Line 7: slave
Nit: slave -> I2C just as an effort to use inclusive language.
Done
https://review.coreboot.org/c/coreboot/+/55035/comment/b905303a_82fdd367
PS3, Line 9: slave
Same comment as above.
Done
https://review.coreboot.org/c/coreboot/+/55035/comment/2c82e7aa_22ce5c6b
PS3, Line 10:
Nit: remove extra space at the end of the line.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55035
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If0bd80baa27dfeb7bcb43f0ca4b02e1228e372a6
Gerrit-Change-Number: 55035
Gerrit-PatchSet: 4
Gerrit-Owner: Tao Xia
xiatao5@huaqin.corp-partner.google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: zanxi chen
chenzanxi@huaqin.corp-partner.google.com
Gerrit-CC: Jessie Xu
xuyanan@huaqin.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Wed, 02 Jun 2021 01:46:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment