Attention is currently required from: Bora Guvendik, Furquan Shaikh, Sumeet R Pawnikar, Karthik Ramasubramanian.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57462 )
Change subject: mb/intel/adlrvp: set power limits dynamically for thermal
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/57462/comment/0d39431f_c2cf3d9f
PS2, Line 9: Set power limit values dynamically based on CPU TDP and PCI ID of SKU.
Please add, where you got the values from.
File src/mainboard/intel/adlrvp/include/baseboard/variants.h:
https://review.coreboot.org/c/coreboot/+/57462/comment/56594491_cd85e627
PS2, Line 42: uint16_t mchid;
Why not the native type unsigned int?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57462
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8ba901fe7c978aad43b85a860c71b33bfbff2ff5
Gerrit-Change-Number: 57462
Gerrit-PatchSet: 2
Gerrit-Owner: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Tue, 14 Sep 2021 08:47:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment