Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42733 )
Change subject: sb/amd/pi/hudson: Enable use of common GPIO API ......................................................................
Patch Set 12: Code-Review+2
(4 comments)
https://review.coreboot.org/c/coreboot/+/42733/11//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42733/11//COMMIT_MSG@7 PS11, Line 7: sb/amd/pi/hudson: Fixes for common GPIO API
i find this a bit misleading; the commit adds the amd soc common gpio code to the build
Done
https://review.coreboot.org/c/coreboot/+/42733/8/src/southbridge/amd/pi/huds... File src/southbridge/amd/pi/hudson/soc/smi.h:
PS8:
I think it was the same question as with <soc/gpio. […]
Done
https://review.coreboot.org/c/coreboot/+/42733/8/src/southbridge/amd/pi/huds... PS8, Line 4: #define __SOC_SMI_H__
Drop __
Done
https://review.coreboot.org/c/coreboot/+/42733/8/src/southbridge/amd/pi/huds... PS8, Line 7: /* FIXME: Copies from stoneyridge now. */
Resolve before merge
Done
-
Felix Held (Code Review)