HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41331 )
Change subject: src/soc/qualcomm: Remove direct 'include <soc/gpio.h>' ......................................................................
src/soc/qualcomm: Remove direct 'include <soc/gpio.h>'
Don't directly include <soc/gpio.h>. All code using GPIO features should always and only include <gpio.h>, which should indirectly include the SoC-specific <soc/gpio.h>.
Change-Id: I4b34bde72d9464963d7829a7f97bf807b2925923 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/soc/qualcomm/ipq40xx/i2c.c M src/soc/qualcomm/qcs405/blsp.c M src/soc/qualcomm/qcs405/i2c.c M src/soc/qualcomm/qcs405/qup.c M src/soc/qualcomm/sc7180/qspi.c M src/soc/qualcomm/sc7180/qupv3_spi.c M src/soc/qualcomm/sdm845/qspi.c 7 files changed, 7 insertions(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/41331/1
diff --git a/src/soc/qualcomm/ipq40xx/i2c.c b/src/soc/qualcomm/ipq40xx/i2c.c index e2cda11..2d92497 100644 --- a/src/soc/qualcomm/ipq40xx/i2c.c +++ b/src/soc/qualcomm/ipq40xx/i2c.c @@ -5,7 +5,7 @@ #include <string.h> #include <soc/blsp.h> #include <soc/qup.h> -#include <soc/gpio.h> +#include <gpio.h>
static qup_config_t blsp1_qup0_config = { QUP_MINICORE_I2C_MASTER, diff --git a/src/soc/qualcomm/qcs405/blsp.c b/src/soc/qualcomm/qcs405/blsp.c index 7fb4954..e1b94e95 100644 --- a/src/soc/qualcomm/qcs405/blsp.c +++ b/src/soc/qualcomm/qcs405/blsp.c @@ -2,7 +2,7 @@
#include <device/mmio.h> #include <soc/blsp.h> -#include <soc/gpio.h> +#include <gpio.h> #include <soc/iomap.h> #include <soc/clock.h>
diff --git a/src/soc/qualcomm/qcs405/i2c.c b/src/soc/qualcomm/qcs405/i2c.c index 85af6e4..6c558cc 100644 --- a/src/soc/qualcomm/qcs405/i2c.c +++ b/src/soc/qualcomm/qcs405/i2c.c @@ -6,7 +6,7 @@ #include <string.h> #include <soc/blsp.h> #include <soc/qup.h> -#include <soc/gpio.h> +#include <gpio.h>
static qup_config_t blsp1_qup0_config = { QUP_MINICORE_I2C_MASTER, diff --git a/src/soc/qualcomm/qcs405/qup.c b/src/soc/qualcomm/qcs405/qup.c index 3ba4ba6..894bf42 100644 --- a/src/soc/qualcomm/qcs405/qup.c +++ b/src/soc/qualcomm/qcs405/qup.c @@ -3,7 +3,7 @@ #include <device/mmio.h> #include <console/console.h> #include <delay.h> -#include <soc/gpio.h> +#include <gpio.h> #include <soc/iomap.h> #include <soc/qup.h>
diff --git a/src/soc/qualcomm/sc7180/qspi.c b/src/soc/qualcomm/sc7180/qspi.c index 10038e4..b776f7d 100644 --- a/src/soc/qualcomm/sc7180/qspi.c +++ b/src/soc/qualcomm/sc7180/qspi.c @@ -6,11 +6,10 @@ #include <device/mmio.h> #include <soc/addressmap.h> #include <soc/qspi.h> -#include <soc/gpio.h> +#include <gpio.h> #include <soc/clock.h> #include <symbols.h> #include <assert.h> -#include <gpio.h> #include <string.h>
#define CACHE_LINE_SIZE 64 diff --git a/src/soc/qualcomm/sc7180/qupv3_spi.c b/src/soc/qualcomm/sc7180/qupv3_spi.c index c3827ef..47fbaf7 100644 --- a/src/soc/qualcomm/sc7180/qupv3_spi.c +++ b/src/soc/qualcomm/sc7180/qupv3_spi.c @@ -4,7 +4,7 @@ #include <delay.h> #include <lib.h> #include <soc/clock.h> -#include <soc/gpio.h> +#include <gpio.h> #include <soc/qcom_qup_se.h> #include <soc/qupv3_config.h> #include <soc/qupv3_spi.h> diff --git a/src/soc/qualcomm/sdm845/qspi.c b/src/soc/qualcomm/sdm845/qspi.c index 8c98316..772f7a2 100644 --- a/src/soc/qualcomm/sdm845/qspi.c +++ b/src/soc/qualcomm/sdm845/qspi.c @@ -6,11 +6,10 @@ #include <device/mmio.h> #include <soc/addressmap.h> #include <soc/qspi.h> -#include <soc/gpio.h> +#include <gpio.h> #include <soc/clock.h> #include <symbols.h> #include <assert.h> -#include <gpio.h> #include <string.h>
#define CACHE_LINE_SIZE 64
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/41331 )
Change subject: src/soc/qualcomm: Remove direct 'include <soc/gpio.h>' ......................................................................
Abandoned
see #41324
-
HAOUAS Elyes (Code Review)