Attention is currently required from: Arthur Heymans, Lance Zhao, Nico Huber.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62573 )
Change subject: coreboot_tables.c: Expose the ACPI RSDP
......................................................................
Patch Set 2:
(1 comment)
File src/commonlib/include/commonlib/coreboot_tables.h:
https://review.coreboot.org/c/coreboot/+/62573/comment/7229f0b2_bd4fc002
PS1, Line 586: uint64_t
(in C pointers are aligned, right?)
Says who? x86 supports misaligned everything by design! The compilers just keep trying to shave off every possible bit everywhere making every assumption they possibly can.... that is so frustrating...
But I think that deserves a broader discussion.
Agreed, maybe that would be an interesting topic for upcoming GSoC...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62573
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I591312a2c48f0cbbb03b2787e4b365e9c932afff
Gerrit-Change-Number: 62573
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Thu, 03 Mar 2022 22:30:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment