Attention is currently required from: Patrick Rudolph, Christian Walter.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74951 )
Change subject: [DO NOT SUBMIT] use Hermes to test CFR code
......................................................................
Patch Set 1:
(1 comment)
File src/drivers/option/cfr.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175462):
https://review.coreboot.org/c/coreboot/+/74951/comment/847363ba_bdb472d7
PS1, Line 228: printk(BIOS_DEBUG, "static __attribute__((aligned(4))) uint8_t cfr_raw_data[] = {");
Prefer __aligned(4) over __attribute__((aligned(4)))
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74951
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I60327235794a4b6615a737f0b4a46a3337f0ddaa
Gerrit-Change-Number: 74951
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Comment-Date: Wed, 03 May 2023 17:58:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment