Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36565 )
Change subject: soc/intel/common: pmclib: add API to get ETR register MMCONF address ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36565/1/src/soc/intel/common/block/... File src/soc/intel/common/block/include/intelblocks/pmclib.h:
https://review.coreboot.org/c/coreboot/+/36565/1/src/soc/intel/common/block/... PS1, Line 173: uintptr_t Why is this not a pointer? If common code should use it, it will also make assumptions on the register width....