Attention is currently required from: Jason Glenesk, Matt DeVillier, Martin Roth, Fred Reitberger, Felix Held.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67301 )
Change subject: soc/amd/common/block/apob: Add hashed APOB support
......................................................................
Patch Set 2: Code-Review+1
(3 comments)
File src/soc/amd/common/block/apob/apob_cache.c:
https://review.coreboot.org/c/coreboot/+/67301/comment/bd3a6441_2302ed84
PS2, Line 22: RW_MRC_HASH
Curious if we can just place the hash at the end of the APCB so we can reuse the `RW_MRC_CACHE`? Or do we not have enough space?
https://review.coreboot.org/c/coreboot/+/67301/comment/0efe88e8_8d3455f1
PS2, Line 162: sizeof(hash)
I would add an assert somewhere that verifies `sizeof(has) <= DEFAULT_MRC_HASH_SIZE`
https://review.coreboot.org/c/coreboot/+/67301/comment/fae00537_cf01339e
PS2, Line 233: memcmp
Add a `!update_needed && `. No reason to read the APOB if we already determined if it needs to be updated.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/67301
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I241968b115aaf41af63445410660bdd5199ceaba
Gerrit-Change-Number: 67301
Gerrit-PatchSet: 2
Gerrit-Owner: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 01 Sep 2022 20:24:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment