Attention is currently required from: Raul Rangel, Aaron Durbin, Furquan Shaikh, Marshall Dawson, Julius Werner, Eric Peers.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56048 )
Change subject: lib/future: Implement Futures API
......................................................................
Patch Set 4:
(1 comment)
File src/lib/future.c:
https://review.coreboot.org/c/coreboot/+/56048/comment/513fac40_994a6bea
PS2, Line 68: state = futures[i]->poll(futures[i], false);
So I was tempted to add a bunch of debug style information in the the futures object. […]
I'll leave it up to you - i think it might be useful to print something when a task actually gets executed, but not when it just checks to see if anything needs to happen. I'd be good with this happening later too, so we can actually decide whether or not it's needed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56048
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I350aebcd07024a00b90495bf937f8bca5193d02f
Gerrit-Change-Number: 56048
Gerrit-PatchSet: 4
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Peers
epeers@google.com
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Aaron Durbin
adurbin@gmail.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Eric Peers
epeers@google.com
Gerrit-Comment-Date: Wed, 07 Jul 2021 18:11:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Gerrit-MessageType: comment