Ravi Kumar Bokka has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35508 )
Change subject: trogdor: SoC makefile blob support ......................................................................
Patch Set 88:
(6 comments)
https://review.coreboot.org/c/coreboot/+/35508/87//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35508/87//COMMIT_MSG@7 PS87, Line 7: trogdor: SoC makefile BLOB support
Please make it a statement by using a verb (in imperative mood).
Done
https://review.coreboot.org/c/coreboot/+/35508/87//COMMIT_MSG@7 PS87, Line 7: BLOB
blob
Done
https://review.coreboot.org/c/coreboot/+/35508/87//COMMIT_MSG@8 PS87, Line 8:
Please elaborate what blobs are added, and what they are.
Done
https://review.coreboot.org/c/coreboot/+/35508/84/src/soc/qualcomm/sc7180/Ma... File src/soc/qualcomm/sc7180/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/35508/84/src/soc/qualcomm/sc7180/Ma... PS84, Line 78: none
All of these others should be okay using $(CBFS_COMPRESS_FLAG), not $(CBFS_PRERAM_COMPRESS_FLAG). […]
Done
https://review.coreboot.org/c/coreboot/+/35508/84/src/soc/qualcomm/sc7180/Ma... PS84, Line 95: none
$(CBFS_COMPRESS_FLAG) again
Done
https://review.coreboot.org/c/coreboot/+/35508/84/src/soc/qualcomm/sc7180/Ma... PS84, Line 103: none
$(CBFS_COMPRESS_FLAG)
Done
-
Ravi Kumar Bokka (Code Review)