Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45604 )
Change subject: include/azalia: Add new macro to configure pins as NC ......................................................................
include/azalia: Add new macro to configure pins as NC
Change-Id: I740d0d756599688165458a9c6e925d5d94754bb2 Signed-off-by: Felix Singer felix.singer@secunet.com --- M src/include/device/azalia_device.h 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/45604/1
diff --git a/src/include/device/azalia_device.h b/src/include/device/azalia_device.h index d510123..f7dfd71 100644 --- a/src/include/device/azalia_device.h +++ b/src/include/device/azalia_device.h @@ -138,4 +138,6 @@ (((codec) << 28) | (0x01722 << 8) | (((val) >> 16) & 0xff)), \ (((codec) << 28) | (0x01723 << 8) | (((val) >> 24) & 0xff))
+#define PIN_CFG_NC(n) (0x411111f0 | (n & 0xf)) + #endif /* DEVICE_AZALIA_H */
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45604 )
Change subject: include/azalia: Add new macro to configure pins as NC ......................................................................
Patch Set 1: Code-Review+2
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45604 )
Change subject: include/azalia: Add new macro to configure pins as NC ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/45604/1/src/include/device/azalia_d... File src/include/device/azalia_device.h:
https://review.coreboot.org/c/coreboot/+/45604/1/src/include/device/azalia_d... PS1, Line 141: PIN_CFG_NC Actually, please below `AZALIA_PIN_CFG` and add `AZALIA_` prefix.
Hello build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45604
to look at the new patch set (#2).
Change subject: include/azalia: Add new macro to configure pins as NC ......................................................................
include/azalia: Add new macro to configure pins as NC
Change-Id: I740d0d756599688165458a9c6e925d5d94754bb2 Signed-off-by: Felix Singer felix.singer@secunet.com --- M src/include/device/azalia_device.h 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/45604/2
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45604 )
Change subject: include/azalia: Add new macro to configure pins as NC ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45604/1/src/include/device/azalia_d... File src/include/device/azalia_device.h:
https://review.coreboot.org/c/coreboot/+/45604/1/src/include/device/azalia_d... PS1, Line 141: PIN_CFG_NC
Actually, please below `AZALIA_PIN_CFG` and add `AZALIA_` prefix.
Done
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45604 )
Change subject: include/azalia: Add new macro to configure pins as NC ......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/45604/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45604/2//COMMIT_MSG@7 PS2, Line 7: include/azalia if anything, I'd use `azalia_device.h`
Hello build bot (Jenkins), Nico Huber, Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45604
to look at the new patch set (#3).
Change subject: azalia_device.h: Add new macro to configure pins as NC ......................................................................
azalia_device.h: Add new macro to configure pins as NC
Change-Id: I740d0d756599688165458a9c6e925d5d94754bb2 Signed-off-by: Felix Singer felix.singer@secunet.com --- M src/include/device/azalia_device.h 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/45604/3
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45604 )
Change subject: azalia_device.h: Add new macro to configure pins as NC ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45604/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45604/2//COMMIT_MSG@7 PS2, Line 7: include/azalia
if anything, I'd use `azalia_device. […]
Done
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45604 )
Change subject: azalia_device.h: Add new macro to configure pins as NC ......................................................................
azalia_device.h: Add new macro to configure pins as NC
Change-Id: I740d0d756599688165458a9c6e925d5d94754bb2 Signed-off-by: Felix Singer felix.singer@secunet.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/45604 Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/include/device/azalia_device.h 1 file changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/include/device/azalia_device.h b/src/include/device/azalia_device.h index d510123..9246d4b 100644 --- a/src/include/device/azalia_device.h +++ b/src/include/device/azalia_device.h @@ -128,6 +128,8 @@ (((codec) << 28) | ((pin) << 20) | (0x71f << 8) \ | (((val) >> 24) & 0xff))
+#define AZALIA_PIN_CFG_NC(n) (0x411111f0 | (n & 0xf)) + #define AZALIA_RESET(pin) \ (((pin) << 20) | 0x7ff00), (((pin) << 20) | 0x7ff00), \ (((pin) << 20) | 0x7ff00), (((pin) << 20) | 0x7ff00)
-
Angel Pons (Code Review) -
Felix Singer (Code Review)
-
Nico Huber (Code Review)
-
Patrick Georgi (Code Review)