Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/19781 )
Change subject: drivers/spi/spi-generic: Make spi_setup_slave strong symbol ......................................................................
Patch Set 4:
Looks like there is a board which wants to use spi without support for it in the soc:
/dev/cb-build/coreboot-gerrit.0/GOOGLE_COSMOS/bootblock/drivers/spi/spi-generic.o: In function `spi_setup_slave': /home/coreboot/slave-root/workspace/coreboot-gerrit/src/drivers/spi/spi-generic.c:139: undefined reference to `spi_ctrlr_bus_map_count' /home/coreboot/slave-root/workspace/coreboot-gerrit/src/drivers/spi/spi-generic.c:139: undefined reference to `spi_ctrlr_bus_map' src/arch/arm/Makefile.inc:60: recipe for target '/dev/cb-build/coreboot-gerrit.0/GOOGLE_COSMOS/cbfs/fallback/bootblock.debug' failed make[1]: *** [/dev/cb-build/coreboot-gerrit.0/GOOGLE_COSMOS/cbfs/fallback/bootblock.debug] Error 1 make[1]: Leaving directory '/home/coreboot/slave-root/workspace/coreboot-gerrit'