Attention is currently required from: Martin Roth, Matt DeVillier.
Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55144 )
Change subject: payloads/tianocore: Add Kconfig option to enable cbmem logging
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
Maybe add that it substantially increases the final payload size? As I recall, it's some 300 KB larger with the debug messages.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55144
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idef125235dc7ba885eb22ac69c6f752588a9e295
Gerrit-Change-Number: 55144
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Comment-Date: Thu, 03 Jun 2021 01:10:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment