[L] Change in coreboot[main]: soc/intel/common/block/imc: Add Integrated Memory Controller driver

[Shuo Liu (Code Review)]

Attention is currently required from: [e-mail].

Shuo Liu has posted comments on this change by [e-mail]. ( https://review.coreboot.org/c/coreboot/+/83320?usp=email )

Change subject: soc/intel/common/block/imc: Add Integrated Memory Controller driver
......................................................................

Patch Set 7:

(2 comments)

File src/soc/intel/common/block/imc/Kconfig:

https://review.coreboot.org/c/coreboot/+/83320/comment/65e419e0_187bbc18?usp... :
PS3, Line 4: 	bool
> I guess you are using an IMC with an SMBUS in it? Would it be possible to be more explicit on naming […]

There was an imc.h, but seems no one is using it. soc/intel/common/block/include/intelblocks/imc.h.

I'm not sure if all intel imc is with a smbus controller inside it, or this is indicating a special kind of imc with smbus controller inside. If the former case, maybe to name it generally as SOC_INTEL_COMMON_BLOCK_IMC should be okay, but it would be great to add some comment message to indicate its functionality.

File src/soc/intel/common/block/smbus/smbuslib.c:

https://review.coreboot.org/c/coreboot/+/83320/comment/addb290b_1381597d?usp... :
PS7, Line 38: static void spd_read(u8 *spd, u8 addr)
maybe this can be moved to a generic spd.c, which is implemented either by smbuslib, or the imc/spd.c