Change in coreboot[master]: mainboard,autoport: Do not use others when enabling all ports
Jacob Garber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34918 )
Change subject: mainboard,autoport: Do not use others when enabling all ports ......................................................................
mainboard,autoport: Do not use others when enabling all ports
Port_List is an array of 8 elements, and GCC 9 is warning that there are no 'others' when all 8 elements are explicitly initialized, which is causing the build to fail. Remove the 'others => Disabled' clause to silence this.
Change-Id: Id082e7a76641438f3fb4c4d976dbd254a7053473 Signed-off-by: Jacob Garber jgarber1@ualberta.ca --- M src/mainboard/apple/macbookair4_2/gma-mainboard.ads M src/mainboard/google/butterfly/gma-mainboard.ads M src/mainboard/google/parrot/gma-mainboard.ads M src/mainboard/google/stout/gma-mainboard.ads M src/mainboard/hp/8460p/gma-mainboard.ads M src/mainboard/hp/8470p/gma-mainboard.ads M src/mainboard/hp/folio_9470m/gma-mainboard.ads M src/mainboard/hp/revolve_810_g1/gma-mainboard.ads M src/mainboard/lenovo/l520/gma-mainboard.ads M src/mainboard/lenovo/s230u/gma-mainboard.ads M src/mainboard/lenovo/t420/gma-mainboard.ads M src/mainboard/lenovo/t420s/gma-mainboard.ads M src/mainboard/lenovo/t430/gma-mainboard.ads M src/mainboard/lenovo/t430s/gma-mainboard.ads M src/mainboard/lenovo/t520/gma-mainboard.ads M src/mainboard/lenovo/t530/gma-mainboard.ads M src/mainboard/lenovo/x1_carbon_gen1/gma-mainboard.ads M src/mainboard/lenovo/x220/gma-mainboard.ads M src/mainboard/lenovo/x230/gma-mainboard.ads M src/mainboard/packardbell/ms2290/gma-mainboard.ads M src/mainboard/samsung/lumpy/gma-mainboard.ads M util/autoport/main.go 22 files changed, 22 insertions(+), 44 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/34918/1
diff --git a/src/mainboard/apple/macbookair4_2/gma-mainboard.ads b/src/mainboard/apple/macbookair4_2/gma-mainboard.ads index d4a5d7d..e45320f 100644 --- a/src/mainboard/apple/macbookair4_2/gma-mainboard.ads +++ b/src/mainboard/apple/macbookair4_2/gma-mainboard.ads @@ -28,7 +28,6 @@ HDMI2, HDMI3, Analog, - Internal, - others => Disabled); + Internal);
end GMA.Mainboard; diff --git a/src/mainboard/google/butterfly/gma-mainboard.ads b/src/mainboard/google/butterfly/gma-mainboard.ads index d4a5d7d..e45320f 100644 --- a/src/mainboard/google/butterfly/gma-mainboard.ads +++ b/src/mainboard/google/butterfly/gma-mainboard.ads @@ -28,7 +28,6 @@ HDMI2, HDMI3, Analog, - Internal, - others => Disabled); + Internal);
end GMA.Mainboard; diff --git a/src/mainboard/google/parrot/gma-mainboard.ads b/src/mainboard/google/parrot/gma-mainboard.ads index d4a5d7d..e45320f 100644 --- a/src/mainboard/google/parrot/gma-mainboard.ads +++ b/src/mainboard/google/parrot/gma-mainboard.ads @@ -28,7 +28,6 @@ HDMI2, HDMI3, Analog, - Internal, - others => Disabled); + Internal);
end GMA.Mainboard; diff --git a/src/mainboard/google/stout/gma-mainboard.ads b/src/mainboard/google/stout/gma-mainboard.ads index d4a5d7d..e45320f 100644 --- a/src/mainboard/google/stout/gma-mainboard.ads +++ b/src/mainboard/google/stout/gma-mainboard.ads @@ -28,7 +28,6 @@ HDMI2, HDMI3, Analog, - Internal, - others => Disabled); + Internal);
end GMA.Mainboard; diff --git a/src/mainboard/hp/8460p/gma-mainboard.ads b/src/mainboard/hp/8460p/gma-mainboard.ads index da495f6..01ae99a 100644 --- a/src/mainboard/hp/8460p/gma-mainboard.ads +++ b/src/mainboard/hp/8460p/gma-mainboard.ads @@ -28,7 +28,6 @@ HDMI2, HDMI3, Analog, - Internal, - others => Disabled); + Internal);
end GMA.Mainboard; diff --git a/src/mainboard/hp/8470p/gma-mainboard.ads b/src/mainboard/hp/8470p/gma-mainboard.ads index da495f6..01ae99a 100644 --- a/src/mainboard/hp/8470p/gma-mainboard.ads +++ b/src/mainboard/hp/8470p/gma-mainboard.ads @@ -28,7 +28,6 @@ HDMI2, HDMI3, Analog, - Internal, - others => Disabled); + Internal);
end GMA.Mainboard; diff --git a/src/mainboard/hp/folio_9470m/gma-mainboard.ads b/src/mainboard/hp/folio_9470m/gma-mainboard.ads index d4a5d7d..e45320f 100644 --- a/src/mainboard/hp/folio_9470m/gma-mainboard.ads +++ b/src/mainboard/hp/folio_9470m/gma-mainboard.ads @@ -28,7 +28,6 @@ HDMI2, HDMI3, Analog, - Internal, - others => Disabled); + Internal);
end GMA.Mainboard; diff --git a/src/mainboard/hp/revolve_810_g1/gma-mainboard.ads b/src/mainboard/hp/revolve_810_g1/gma-mainboard.ads index da495f6..01ae99a 100644 --- a/src/mainboard/hp/revolve_810_g1/gma-mainboard.ads +++ b/src/mainboard/hp/revolve_810_g1/gma-mainboard.ads @@ -28,7 +28,6 @@ HDMI2, HDMI3, Analog, - Internal, - others => Disabled); + Internal);
end GMA.Mainboard; diff --git a/src/mainboard/lenovo/l520/gma-mainboard.ads b/src/mainboard/lenovo/l520/gma-mainboard.ads index d4a5d7d..e45320f 100644 --- a/src/mainboard/lenovo/l520/gma-mainboard.ads +++ b/src/mainboard/lenovo/l520/gma-mainboard.ads @@ -28,7 +28,6 @@ HDMI2, HDMI3, Analog, - Internal, - others => Disabled); + Internal);
end GMA.Mainboard; diff --git a/src/mainboard/lenovo/s230u/gma-mainboard.ads b/src/mainboard/lenovo/s230u/gma-mainboard.ads index d4a5d7d..e45320f 100644 --- a/src/mainboard/lenovo/s230u/gma-mainboard.ads +++ b/src/mainboard/lenovo/s230u/gma-mainboard.ads @@ -28,7 +28,6 @@ HDMI2, HDMI3, Analog, - Internal, - others => Disabled); + Internal);
end GMA.Mainboard; diff --git a/src/mainboard/lenovo/t420/gma-mainboard.ads b/src/mainboard/lenovo/t420/gma-mainboard.ads index e9471cb..a19bf33 100644 --- a/src/mainboard/lenovo/t420/gma-mainboard.ads +++ b/src/mainboard/lenovo/t420/gma-mainboard.ads @@ -27,7 +27,6 @@ HDMI2, HDMI3, Analog, - Internal, - others => Disabled); + Internal);
end GMA.Mainboard; diff --git a/src/mainboard/lenovo/t420s/gma-mainboard.ads b/src/mainboard/lenovo/t420s/gma-mainboard.ads index d4a5d7d..e45320f 100644 --- a/src/mainboard/lenovo/t420s/gma-mainboard.ads +++ b/src/mainboard/lenovo/t420s/gma-mainboard.ads @@ -28,7 +28,6 @@ HDMI2, HDMI3, Analog, - Internal, - others => Disabled); + Internal);
end GMA.Mainboard; diff --git a/src/mainboard/lenovo/t430/gma-mainboard.ads b/src/mainboard/lenovo/t430/gma-mainboard.ads index e9471cb..a19bf33 100644 --- a/src/mainboard/lenovo/t430/gma-mainboard.ads +++ b/src/mainboard/lenovo/t430/gma-mainboard.ads @@ -27,7 +27,6 @@ HDMI2, HDMI3, Analog, - Internal, - others => Disabled); + Internal);
end GMA.Mainboard; diff --git a/src/mainboard/lenovo/t430s/gma-mainboard.ads b/src/mainboard/lenovo/t430s/gma-mainboard.ads index d635d88..8cf5d2f 100644 --- a/src/mainboard/lenovo/t430s/gma-mainboard.ads +++ b/src/mainboard/lenovo/t430s/gma-mainboard.ads @@ -28,7 +28,6 @@ HDMI2, HDMI3, Analog, - Internal, - others => Disabled); + Internal);
end GMA.Mainboard; diff --git a/src/mainboard/lenovo/t520/gma-mainboard.ads b/src/mainboard/lenovo/t520/gma-mainboard.ads index d4a5d7d..e45320f 100644 --- a/src/mainboard/lenovo/t520/gma-mainboard.ads +++ b/src/mainboard/lenovo/t520/gma-mainboard.ads @@ -28,7 +28,6 @@ HDMI2, HDMI3, Analog, - Internal, - others => Disabled); + Internal);
end GMA.Mainboard; diff --git a/src/mainboard/lenovo/t530/gma-mainboard.ads b/src/mainboard/lenovo/t530/gma-mainboard.ads index d4a5d7d..e45320f 100644 --- a/src/mainboard/lenovo/t530/gma-mainboard.ads +++ b/src/mainboard/lenovo/t530/gma-mainboard.ads @@ -28,7 +28,6 @@ HDMI2, HDMI3, Analog, - Internal, - others => Disabled); + Internal);
end GMA.Mainboard; diff --git a/src/mainboard/lenovo/x1_carbon_gen1/gma-mainboard.ads b/src/mainboard/lenovo/x1_carbon_gen1/gma-mainboard.ads index 99d0a28..6dca56b 100644 --- a/src/mainboard/lenovo/x1_carbon_gen1/gma-mainboard.ads +++ b/src/mainboard/lenovo/x1_carbon_gen1/gma-mainboard.ads @@ -25,7 +25,6 @@ HDMI1, HDMI2, HDMI3, - Internal, - others => Disabled); + Internal);
end GMA.Mainboard; diff --git a/src/mainboard/lenovo/x220/gma-mainboard.ads b/src/mainboard/lenovo/x220/gma-mainboard.ads index d4a5d7d..e45320f 100644 --- a/src/mainboard/lenovo/x220/gma-mainboard.ads +++ b/src/mainboard/lenovo/x220/gma-mainboard.ads @@ -28,7 +28,6 @@ HDMI2, HDMI3, Analog, - Internal, - others => Disabled); + Internal);
end GMA.Mainboard; diff --git a/src/mainboard/lenovo/x230/gma-mainboard.ads b/src/mainboard/lenovo/x230/gma-mainboard.ads index d4a5d7d..e45320f 100644 --- a/src/mainboard/lenovo/x230/gma-mainboard.ads +++ b/src/mainboard/lenovo/x230/gma-mainboard.ads @@ -28,7 +28,6 @@ HDMI2, HDMI3, Analog, - Internal, - others => Disabled); + Internal);
end GMA.Mainboard; diff --git a/src/mainboard/packardbell/ms2290/gma-mainboard.ads b/src/mainboard/packardbell/ms2290/gma-mainboard.ads index d4a5d7d..e45320f 100644 --- a/src/mainboard/packardbell/ms2290/gma-mainboard.ads +++ b/src/mainboard/packardbell/ms2290/gma-mainboard.ads @@ -28,7 +28,6 @@ HDMI2, HDMI3, Analog, - Internal, - others => Disabled); + Internal);
end GMA.Mainboard; diff --git a/src/mainboard/samsung/lumpy/gma-mainboard.ads b/src/mainboard/samsung/lumpy/gma-mainboard.ads index d4a5d7d..e45320f 100644 --- a/src/mainboard/samsung/lumpy/gma-mainboard.ads +++ b/src/mainboard/samsung/lumpy/gma-mainboard.ads @@ -28,7 +28,6 @@ HDMI2, HDMI3, Analog, - Internal, - others => Disabled); + Internal);
end GMA.Mainboard; diff --git a/util/autoport/main.go b/util/autoport/main.go index ab49a14..03523a2 100644 --- a/util/autoport/main.go +++ b/util/autoport/main.go @@ -925,8 +925,7 @@ HDMI2, HDMI3, Analog, - Internal, - others => Disabled); + Internal);
end GMA.Mainboard; `)
Hello Alexander Couzens, Evgeny Zinoviev, Patrick Rudolph, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34918
to look at the new patch set (#2).
Change subject: mainboard,autoport: Do not use others when enabling all ports ......................................................................
mainboard,autoport: Do not use others when enabling all ports
Port_List is an array of 8 elements, and GCC 9 is warning that there are no 'others' when all 8 elements are explicitly initialized, which is causing the build to fail. Remove the 'others => Disabled' clause to silence this.
Change-Id: Id082e7a76641438f3fb4c4d976dbd254a7053473 Signed-off-by: Jacob Garber jgarber1@ualberta.ca --- M src/mainboard/apple/macbookair4_2/gma-mainboard.ads M src/mainboard/google/butterfly/gma-mainboard.ads M src/mainboard/google/parrot/gma-mainboard.ads M src/mainboard/google/stout/gma-mainboard.ads M src/mainboard/hp/8460p/gma-mainboard.ads M src/mainboard/hp/8470p/gma-mainboard.ads M src/mainboard/hp/folio_9470m/gma-mainboard.ads M src/mainboard/hp/revolve_810_g1/gma-mainboard.ads M src/mainboard/lenovo/l520/gma-mainboard.ads M src/mainboard/lenovo/s230u/gma-mainboard.ads M src/mainboard/lenovo/t420/gma-mainboard.ads M src/mainboard/lenovo/t420s/gma-mainboard.ads M src/mainboard/lenovo/t430/gma-mainboard.ads M src/mainboard/lenovo/t430s/gma-mainboard.ads M src/mainboard/lenovo/t520/gma-mainboard.ads M src/mainboard/lenovo/t530/gma-mainboard.ads M src/mainboard/lenovo/x220/gma-mainboard.ads M src/mainboard/lenovo/x230/gma-mainboard.ads M src/mainboard/packardbell/ms2290/gma-mainboard.ads M src/mainboard/samsung/lumpy/gma-mainboard.ads M util/autoport/main.go 21 files changed, 21 insertions(+), 42 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/34918/2
Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34918 )
Change subject: mb,autoport: Fix GCC 9 Port_List build error ......................................................................
Patch Set 3:
GNAT has become more picky in GCC 9, so we need to tweak a few things for the build to work. You can see the progress of the GCC 9 port in CB:32564.
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34918 )
Change subject: mb,autoport: Fix GCC 9 Port_List build error ......................................................................
Patch Set 3: Code-Review+1
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34918 )
Change subject: mb,autoport: Fix GCC 9 Port_List build error ......................................................................
Patch Set 3: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34918 )
Change subject: mb,autoport: Fix GCC 9 Port_List build error ......................................................................
mb,autoport: Fix GCC 9 Port_List build error
Port_List is an array of 8 elements, and GCC 9 is warning that there are no 'others' when all 8 elements are explicitly initialized, which is causing the build to fail. Remove the 'others => Disabled' clause to silence this.
Change-Id: Id082e7a76641438f3fb4c4d976dbd254a7053473 Signed-off-by: Jacob Garber jgarber1@ualberta.ca Reviewed-on: https://review.coreboot.org/c/coreboot/+/34918 Reviewed-by: HAOUAS Elyes ehaouas@noos.fr Reviewed-by: Patrick Georgi pgeorgi@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/apple/macbookair4_2/gma-mainboard.ads M src/mainboard/google/butterfly/gma-mainboard.ads M src/mainboard/google/parrot/gma-mainboard.ads M src/mainboard/google/stout/gma-mainboard.ads M src/mainboard/hp/8460p/gma-mainboard.ads M src/mainboard/hp/8470p/gma-mainboard.ads M src/mainboard/hp/folio_9470m/gma-mainboard.ads M src/mainboard/hp/revolve_810_g1/gma-mainboard.ads M src/mainboard/lenovo/l520/gma-mainboard.ads M src/mainboard/lenovo/s230u/gma-mainboard.ads M src/mainboard/lenovo/t420/gma-mainboard.ads M src/mainboard/lenovo/t420s/gma-mainboard.ads M src/mainboard/lenovo/t430/gma-mainboard.ads M src/mainboard/lenovo/t430s/gma-mainboard.ads M src/mainboard/lenovo/t520/gma-mainboard.ads M src/mainboard/lenovo/t530/gma-mainboard.ads M src/mainboard/lenovo/x220/gma-mainboard.ads M src/mainboard/lenovo/x230/gma-mainboard.ads M src/mainboard/packardbell/ms2290/gma-mainboard.ads M src/mainboard/samsung/lumpy/gma-mainboard.ads M util/autoport/main.go 21 files changed, 21 insertions(+), 42 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved HAOUAS Elyes: Looks good to me, but someone else must approve
diff --git a/src/mainboard/apple/macbookair4_2/gma-mainboard.ads b/src/mainboard/apple/macbookair4_2/gma-mainboard.ads index d4a5d7d..e45320f 100644 --- a/src/mainboard/apple/macbookair4_2/gma-mainboard.ads +++ b/src/mainboard/apple/macbookair4_2/gma-mainboard.ads @@ -28,7 +28,6 @@ HDMI2, HDMI3, Analog, - Internal, - others => Disabled); + Internal);
end GMA.Mainboard; diff --git a/src/mainboard/google/butterfly/gma-mainboard.ads b/src/mainboard/google/butterfly/gma-mainboard.ads index d4a5d7d..e45320f 100644 --- a/src/mainboard/google/butterfly/gma-mainboard.ads +++ b/src/mainboard/google/butterfly/gma-mainboard.ads @@ -28,7 +28,6 @@ HDMI2, HDMI3, Analog, - Internal, - others => Disabled); + Internal);
end GMA.Mainboard; diff --git a/src/mainboard/google/parrot/gma-mainboard.ads b/src/mainboard/google/parrot/gma-mainboard.ads index d4a5d7d..e45320f 100644 --- a/src/mainboard/google/parrot/gma-mainboard.ads +++ b/src/mainboard/google/parrot/gma-mainboard.ads @@ -28,7 +28,6 @@ HDMI2, HDMI3, Analog, - Internal, - others => Disabled); + Internal);
end GMA.Mainboard; diff --git a/src/mainboard/google/stout/gma-mainboard.ads b/src/mainboard/google/stout/gma-mainboard.ads index d4a5d7d..e45320f 100644 --- a/src/mainboard/google/stout/gma-mainboard.ads +++ b/src/mainboard/google/stout/gma-mainboard.ads @@ -28,7 +28,6 @@ HDMI2, HDMI3, Analog, - Internal, - others => Disabled); + Internal);
end GMA.Mainboard; diff --git a/src/mainboard/hp/8460p/gma-mainboard.ads b/src/mainboard/hp/8460p/gma-mainboard.ads index da495f6..01ae99a 100644 --- a/src/mainboard/hp/8460p/gma-mainboard.ads +++ b/src/mainboard/hp/8460p/gma-mainboard.ads @@ -28,7 +28,6 @@ HDMI2, HDMI3, Analog, - Internal, - others => Disabled); + Internal);
end GMA.Mainboard; diff --git a/src/mainboard/hp/8470p/gma-mainboard.ads b/src/mainboard/hp/8470p/gma-mainboard.ads index da495f6..01ae99a 100644 --- a/src/mainboard/hp/8470p/gma-mainboard.ads +++ b/src/mainboard/hp/8470p/gma-mainboard.ads @@ -28,7 +28,6 @@ HDMI2, HDMI3, Analog, - Internal, - others => Disabled); + Internal);
end GMA.Mainboard; diff --git a/src/mainboard/hp/folio_9470m/gma-mainboard.ads b/src/mainboard/hp/folio_9470m/gma-mainboard.ads index d4a5d7d..e45320f 100644 --- a/src/mainboard/hp/folio_9470m/gma-mainboard.ads +++ b/src/mainboard/hp/folio_9470m/gma-mainboard.ads @@ -28,7 +28,6 @@ HDMI2, HDMI3, Analog, - Internal, - others => Disabled); + Internal);
end GMA.Mainboard; diff --git a/src/mainboard/hp/revolve_810_g1/gma-mainboard.ads b/src/mainboard/hp/revolve_810_g1/gma-mainboard.ads index da495f6..01ae99a 100644 --- a/src/mainboard/hp/revolve_810_g1/gma-mainboard.ads +++ b/src/mainboard/hp/revolve_810_g1/gma-mainboard.ads @@ -28,7 +28,6 @@ HDMI2, HDMI3, Analog, - Internal, - others => Disabled); + Internal);
end GMA.Mainboard; diff --git a/src/mainboard/lenovo/l520/gma-mainboard.ads b/src/mainboard/lenovo/l520/gma-mainboard.ads index d4a5d7d..e45320f 100644 --- a/src/mainboard/lenovo/l520/gma-mainboard.ads +++ b/src/mainboard/lenovo/l520/gma-mainboard.ads @@ -28,7 +28,6 @@ HDMI2, HDMI3, Analog, - Internal, - others => Disabled); + Internal);
end GMA.Mainboard; diff --git a/src/mainboard/lenovo/s230u/gma-mainboard.ads b/src/mainboard/lenovo/s230u/gma-mainboard.ads index d4a5d7d..e45320f 100644 --- a/src/mainboard/lenovo/s230u/gma-mainboard.ads +++ b/src/mainboard/lenovo/s230u/gma-mainboard.ads @@ -28,7 +28,6 @@ HDMI2, HDMI3, Analog, - Internal, - others => Disabled); + Internal);
end GMA.Mainboard; diff --git a/src/mainboard/lenovo/t420/gma-mainboard.ads b/src/mainboard/lenovo/t420/gma-mainboard.ads index e9471cb..a19bf33 100644 --- a/src/mainboard/lenovo/t420/gma-mainboard.ads +++ b/src/mainboard/lenovo/t420/gma-mainboard.ads @@ -27,7 +27,6 @@ HDMI2, HDMI3, Analog, - Internal, - others => Disabled); + Internal);
end GMA.Mainboard; diff --git a/src/mainboard/lenovo/t420s/gma-mainboard.ads b/src/mainboard/lenovo/t420s/gma-mainboard.ads index d4a5d7d..e45320f 100644 --- a/src/mainboard/lenovo/t420s/gma-mainboard.ads +++ b/src/mainboard/lenovo/t420s/gma-mainboard.ads @@ -28,7 +28,6 @@ HDMI2, HDMI3, Analog, - Internal, - others => Disabled); + Internal);
end GMA.Mainboard; diff --git a/src/mainboard/lenovo/t430/gma-mainboard.ads b/src/mainboard/lenovo/t430/gma-mainboard.ads index e9471cb..a19bf33 100644 --- a/src/mainboard/lenovo/t430/gma-mainboard.ads +++ b/src/mainboard/lenovo/t430/gma-mainboard.ads @@ -27,7 +27,6 @@ HDMI2, HDMI3, Analog, - Internal, - others => Disabled); + Internal);
end GMA.Mainboard; diff --git a/src/mainboard/lenovo/t430s/gma-mainboard.ads b/src/mainboard/lenovo/t430s/gma-mainboard.ads index d635d88..8cf5d2f 100644 --- a/src/mainboard/lenovo/t430s/gma-mainboard.ads +++ b/src/mainboard/lenovo/t430s/gma-mainboard.ads @@ -28,7 +28,6 @@ HDMI2, HDMI3, Analog, - Internal, - others => Disabled); + Internal);
end GMA.Mainboard; diff --git a/src/mainboard/lenovo/t520/gma-mainboard.ads b/src/mainboard/lenovo/t520/gma-mainboard.ads index d4a5d7d..e45320f 100644 --- a/src/mainboard/lenovo/t520/gma-mainboard.ads +++ b/src/mainboard/lenovo/t520/gma-mainboard.ads @@ -28,7 +28,6 @@ HDMI2, HDMI3, Analog, - Internal, - others => Disabled); + Internal);
end GMA.Mainboard; diff --git a/src/mainboard/lenovo/t530/gma-mainboard.ads b/src/mainboard/lenovo/t530/gma-mainboard.ads index d4a5d7d..e45320f 100644 --- a/src/mainboard/lenovo/t530/gma-mainboard.ads +++ b/src/mainboard/lenovo/t530/gma-mainboard.ads @@ -28,7 +28,6 @@ HDMI2, HDMI3, Analog, - Internal, - others => Disabled); + Internal);
end GMA.Mainboard; diff --git a/src/mainboard/lenovo/x220/gma-mainboard.ads b/src/mainboard/lenovo/x220/gma-mainboard.ads index d4a5d7d..e45320f 100644 --- a/src/mainboard/lenovo/x220/gma-mainboard.ads +++ b/src/mainboard/lenovo/x220/gma-mainboard.ads @@ -28,7 +28,6 @@ HDMI2, HDMI3, Analog, - Internal, - others => Disabled); + Internal);
end GMA.Mainboard; diff --git a/src/mainboard/lenovo/x230/gma-mainboard.ads b/src/mainboard/lenovo/x230/gma-mainboard.ads index d4a5d7d..e45320f 100644 --- a/src/mainboard/lenovo/x230/gma-mainboard.ads +++ b/src/mainboard/lenovo/x230/gma-mainboard.ads @@ -28,7 +28,6 @@ HDMI2, HDMI3, Analog, - Internal, - others => Disabled); + Internal);
end GMA.Mainboard; diff --git a/src/mainboard/packardbell/ms2290/gma-mainboard.ads b/src/mainboard/packardbell/ms2290/gma-mainboard.ads index d4a5d7d..e45320f 100644 --- a/src/mainboard/packardbell/ms2290/gma-mainboard.ads +++ b/src/mainboard/packardbell/ms2290/gma-mainboard.ads @@ -28,7 +28,6 @@ HDMI2, HDMI3, Analog, - Internal, - others => Disabled); + Internal);
end GMA.Mainboard; diff --git a/src/mainboard/samsung/lumpy/gma-mainboard.ads b/src/mainboard/samsung/lumpy/gma-mainboard.ads index d4a5d7d..e45320f 100644 --- a/src/mainboard/samsung/lumpy/gma-mainboard.ads +++ b/src/mainboard/samsung/lumpy/gma-mainboard.ads @@ -28,7 +28,6 @@ HDMI2, HDMI3, Analog, - Internal, - others => Disabled); + Internal);
end GMA.Mainboard; diff --git a/util/autoport/main.go b/util/autoport/main.go index ab49a14..03523a2 100644 --- a/util/autoport/main.go +++ b/util/autoport/main.go @@ -925,8 +925,7 @@ HDMI2, HDMI3, Analog, - Internal, - others => Disabled); + Internal);
end GMA.Mainboard; `)
-
HAOUAS Elyes (Code Review) -
Jacob Garber (Code Review)
-
Patrick Georgi (Code Review)