Attention is currently required from: Karthik Ramasubramanian, Paul Menzel, Shelley Chen.
Ashish Kumar Mishra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81224?usp=email )
Change subject: mb/google/brox: Select USE_UNIFIED_AP_FIRMWARE_FOR_UFS_AND_NON_UFS ......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81224/comment/7f6e2118_718ad370 : PS3, Line 11: This also adds a warm boot step, only when booting from cold reset : to disable the UFS Controller.
I do not understand the relation regarding to the Kconfig change at hand. […]
Choosing this KConfig handles UFS disable on relevant SKUs and it requires a cold reset, during which the settings will be applied and a warm boot triggered. This is added to clarify the behavior expected due to this Kconfig.
https://review.coreboot.org/c/coreboot/+/81224/comment/4d047b4c_1340af88 : PS3, Line 9: Select USE_UNIFIED_AP_FIRMWARE_FOR_UFS_AND_NON_UFS in brox Kconfig. : This enables a single binary for both SKU1 and SKU2. : This also adds a warm boot step, only when booting from cold reset : to disable the UFS Controller.
Please add a blank line between paragraphs, or do not break lines just because a sentence ends.
Acknowledged