Change in coreboot[master]: soc/intel/tigerlake: fix call to print_spd_info()

[Nick Vaccaro (Code Review)]

Nick Vaccaro has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40496 )

Change subject: soc/intel/tigerlake: fix call to print_spd_info()
......................................................................

soc/intel/tigerlake: fix call to print_spd_info()

Pointer passed to print_spd_info() from meminit.c needed to be
dereferenced first, so this change dereferences it.

BUG=b:154352883
TEST="emerge-volteer coreboot chromeos-bootimage", flash and boot
volteer, login to kernel and execute the following cbmem command:
  localhost ~ # cbmem -c | grep LPDDR4X
and verify it returns "SPD: module type is LPDDR4X"

Change-Id: I5ff64121f0d50947c4946e9e02460dfb7319d01a
Signed-off-by: Nick Vaccaro 
---
M src/soc/intel/tigerlake/meminit.c
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/40496/1

diff --git a/src/soc/intel/tigerlake/meminit.c b/src/soc/intel/tigerlake/meminit.c
index 8664547..4709785 100644
--- a/src/soc/intel/tigerlake/meminit.c
+++ b/src/soc/intel/tigerlake/meminit.c
@@ -222,7 +222,7 @@
    	die("Not a valid location(%d) for Memory-down SPD!\n", info->md_spd_loc);
    }

-	print_spd_info((unsigned char *)data);
+	print_spd_info((unsigned char *) *data);
 }

void meminit_lpddr4x(FSP_M_CONFIG *mem_cfg, const struct lpddr4x_cfg *board_cfg,

[Dossym Nurmukhanov (Code Review)]

Dossym Nurmukhanov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40496 )

Change subject: soc/intel/tigerlake: fix call to print_spd_info()
......................................................................

Patch Set 5: Code-Review+1

[Caveh Jalali (Code Review)]

Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40496 )

Change subject: soc/intel/tigerlake: fix call to print_spd_info()
......................................................................

Patch Set 5: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/40496/5/src/soc/intel/tigerlake/mem... 
File src/soc/intel/tigerlake/meminit.c:

https://review.coreboot.org/c/coreboot/+/40496/5/src/soc/intel/tigerlake/mem... 
PS5, Line 225: unsigned char
uint8_t

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40496 )

Change subject: soc/intel/tigerlake: fix call to print_spd_info()
......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40496/5//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/40496/5//COMMIT_MSG@9 
PS5, Line 9: needed
needs

[Duncan Laurie (Code Review)]

Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40496 )

Change subject: soc/intel/tigerlake: fix call to print_spd_info()
......................................................................

Patch Set 5: Code-Review+2

[Nick Vaccaro (Code Review)]

Hello build bot (Jenkins), Furquan Shaikh, Caveh Jalali, Duncan Laurie, Dossym Nurmukhanov, Srinidhi N Kaushik, Raj Astekar, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40496

to look at the new patch set (#6).

Change subject: soc/intel/tigerlake: fix call to print_spd_info()
......................................................................

soc/intel/tigerlake: fix call to print_spd_info()

Pointer passed to print_spd_info() from meminit.c needs to be
dereferenced first, so this change dereferences it.

BUG=b:154352883
TEST="emerge-volteer coreboot chromeos-bootimage", flash and boot
volteer, login to kernel and execute the following cbmem command:
  localhost ~ # cbmem -c | grep LPDDR4X
and verify it returns "SPD: module type is LPDDR4X"

Change-Id: I5ff64121f0d50947c4946e9e02460dfb7319d01a
Signed-off-by: Nick Vaccaro 
---
M src/soc/intel/tigerlake/meminit.c
1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/40496/6

[Nick Vaccaro (Code Review)]

Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40496 )

Change subject: soc/intel/tigerlake: fix call to print_spd_info()
......................................................................

Patch Set 6:

(2 comments)

https://review.coreboot.org/c/coreboot/+/40496/5//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/40496/5//COMMIT_MSG@9 
PS5, Line 9: needed
> needs

Done

https://review.coreboot.org/c/coreboot/+/40496/5/src/soc/intel/tigerlake/mem... 
File src/soc/intel/tigerlake/meminit.c:

https://review.coreboot.org/c/coreboot/+/40496/5/src/soc/intel/tigerlake/mem... 
PS5, Line 225: unsigned char
> uint8_t

Done

[Duncan Laurie (Code Review)]

Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40496 )

Change subject: soc/intel/tigerlake: fix call to print_spd_info()
......................................................................

Patch Set 6: Code-Review+2

[EricR Lai (Code Review)]

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40496 )

Change subject: soc/intel/tigerlake: fix call to print_spd_info()
......................................................................

Patch Set 7:

I can print SPD by print_spd_info((unsigned char *)blk->spd_array[i]); Any issue you hit here?

[Nick Vaccaro (Code Review)]

Nick Vaccaro has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40496 )

Change subject: soc/intel/tigerlake: fix call to print_spd_info()
......................................................................

soc/intel/tigerlake: fix call to print_spd_info()

Pointer passed to print_spd_info() from meminit.c needs to be
dereferenced first, so this change dereferences it.

BUG=b:154352883
TEST="emerge-volteer coreboot chromeos-bootimage", flash and boot
volteer, login to kernel and execute the following cbmem command:
  localhost ~ # cbmem -c | grep LPDDR4X
and verify it returns "SPD: module type is LPDDR4X"

Change-Id: I5ff64121f0d50947c4946e9e02460dfb7319d01a
Signed-off-by: Nick Vaccaro 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/40496
Tested-by: build bot (Jenkins) 
Reviewed-by: Duncan Laurie 
---
M src/soc/intel/tigerlake/meminit.c
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Duncan Laurie: Looks good to me, approved

diff --git a/src/soc/intel/tigerlake/meminit.c b/src/soc/intel/tigerlake/meminit.c
index d44554a..ebadcff 100644
--- a/src/soc/intel/tigerlake/meminit.c
+++ b/src/soc/intel/tigerlake/meminit.c
@@ -230,7 +230,7 @@
    	die("Not a valid location(%d) for Memory-down SPD!\n", info->md_spd_loc);
    }

-	print_spd_info((unsigned char *)data);
+	print_spd_info((uint8_t *) *data);
 }

void meminit_lpddr4x(FSP_M_CONFIG *mem_cfg, const struct lpddr4x_cfg *board_cfg,
@@ -317,7 +317,7 @@

for (i = 0; i < ARRAY_SIZE(blk->addr_map); i++) {
    	if (blk->addr_map[i])
-			print_spd_info((unsigned char *)blk->spd_array[i]);
+			print_spd_info((uint8_t *)blk->spd_array[i]);
    }
 }