Change in coreboot[master]: mb/supermicro/x11-lga1151v2-series: Add support for X11SCH-F
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37441 )
Change subject: mb/supermicro/x11-lga1151v2-series: Add support for X11SCH-F ......................................................................
Patch Set 60:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37441/60/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151v2-series/memory.c:
https://review.coreboot.org/c/coreboot/+/37441/60/src/mainboard/supermicro/x... PS60, Line 27: .rcomp_resistor = {121, 81, 100},
Where do you got those values from? - Also why CFL-U?
These values often go through me and come from Intel doc #573387.
The Rcomp values are all specific to the chip generation, class (Y/U/H/S), and DRAM topology (e.g. DIMM/SO-DIMM/soldered down this/that way).
For the socketed -S CPUs, it's not board specific at all, as the resistors are on the bottom of the CPU package. IIRC, we confirmed the 121, 75, 100 by measuring once (and it's what the document says for CFL-S).
https://review.coreboot.org/c/coreboot/+/37441/60/src/mainboard/supermicro/x... PS60, Line 30: .rcomp_targets = {100, 40, 20, 20, 26},
Same question? Origin?
Same document, and I can confirm Angel's values.
-
Nico Huber (Code Review)