Attention is currently required from: Joel Linn, Michał Żygowski, MrChromebox, Piotr Król.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81310?usp=email )
Change subject: superio/ite: Add special fan vectors, unify it8722f with common
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
File src/superio/ite/common/early_serial.c:
https://review.coreboot.org/c/coreboot/+/81310/comment/7ab8f023_ef5b777f :
PS1, Line 90: void ite_set_3vsbsw(pnp_devfn_t dev, bool enable)
I am working on a new port that needs this otherwise it will not fully power down when entering S5. […]
you can add one for disable as well now if you want, or later
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81310?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic4d9d5460628e444dc20f620179b39c90dbc28c6
Gerrit-Change-Number: 81310
Gerrit-PatchSet: 3
Gerrit-Owner: Joel Linn
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: MrChromebox
mrchromebox@gmail.com
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Joel Linn
Gerrit-Attention: MrChromebox
mrchromebox@gmail.com
Gerrit-Attention: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Comment-Date: Tue, 19 Mar 2024 20:25:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Comment-In-Reply-To: Joel Linn
Gerrit-MessageType: comment