Peichao Li has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39424 )
Change subject: mb/google/octopus: Add custom SAR values for Foob360 ......................................................................
mb/google/octopus: Add custom SAR values for Foob360
Foob360 would prefer to use different SAR values. Since Foob360 sku id is 9.
BUG=b:149362272 BRANCH=octopus TEST=build
Signed-off-by: peichao.wang peichao.wang@bitland.corp-partner.google.com Change-Id: I8cc5d73629990f19d2c1044debdba4990c54d07e --- M src/mainboard/google/octopus/variants/foob/Makefile.inc A src/mainboard/google/octopus/variants/foob/mainboard.c 2 files changed, 33 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/39424/1
diff --git a/src/mainboard/google/octopus/variants/foob/Makefile.inc b/src/mainboard/google/octopus/variants/foob/Makefile.inc index a291304..a800275 100644 --- a/src/mainboard/google/octopus/variants/foob/Makefile.inc +++ b/src/mainboard/google/octopus/variants/foob/Makefile.inc @@ -1,3 +1,4 @@ bootblock-y += gpio.c ramstage-y += gpio.c ramstage-y += variant.c +ramstage-y += mainboard.c diff --git a/src/mainboard/google/octopus/variants/foob/mainboard.c b/src/mainboard/google/octopus/variants/foob/mainboard.c new file mode 100644 index 0000000..2619162 --- /dev/null +++ b/src/mainboard/google/octopus/variants/foob/mainboard.c @@ -0,0 +1,32 @@ +/* + *thiss file is part of the coreboot project. + * + * Copyright 2020 Google LLC + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <boardid.h> +#include <ec/google/chromeec/ec.h> +#include <sar.h> + +const char *get_wifi_sar_cbfs_filename(void) +{ + const char *filename = NULL; + uint32_t sku_id; + + if (google_chromeec_cbi_get_sku_id(&sku_id)) + return NULL; + + if (sku_id == 9) + filename = "wifi_sar-foob360.hex"; + + return filename; +}
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39424 )
Change subject: mb/google/octopus: Add custom SAR values for Foob360 ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39424/1/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/foob/mainboard.c:
https://review.coreboot.org/c/coreboot/+/39424/1/src/mainboard/google/octopu... PS1, Line 6: * This program is free software; you can redistribute it and/or modify trailing whitespace
Hello build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39424
to look at the new patch set (#2).
Change subject: mb/google/octopus: Add custom SAR values for Foob360 ......................................................................
mb/google/octopus: Add custom SAR values for Foob360
Foob360 would prefer to use different SAR values. Since Foob360 sku id is 9.
BUG=b:149362272 BRANCH=octopus TEST=build
Signed-off-by: peichao.wang peichao.wang@bitland.corp-partner.google.com Change-Id: I8cc5d73629990f19d2c1044debdba4990c54d07e --- M src/mainboard/google/octopus/variants/foob/Makefile.inc A src/mainboard/google/octopus/variants/foob/mainboard.c 2 files changed, 33 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/39424/2
Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39424 )
Change subject: mb/google/octopus: Add custom SAR values for Foob360 ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39424/2/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/foob/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/39424/2/src/mainboard/google/octopu... PS2, Line 4: ramstage-y += mainboard.c Please change the location to variant.c which aligns others variants although phaser did do it in mainboard.c . Thanks.
https://review.coreboot.org/c/coreboot/+/39424/2/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/foob/mainboard.c:
https://review.coreboot.org/c/coreboot/+/39424/2/src/mainboard/google/octopu... PS2, Line 25: if (google_chromeec_cbi_get_sku_id(&sku_id)) Please call get_board_sku() intead. The reason is because there is a cache so no necessary to communicate to EC every time.
Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth, Henry Sun, Justin TerAvest, Marco Chen,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39424
to look at the new patch set (#3).
Change subject: mb/google/octopus: Add custom SAR values for Foob360 ......................................................................
mb/google/octopus: Add custom SAR values for Foob360
Foob360 would prefer to use different SAR values. Since Foob360 sku id is 9.
BUG=b:149362272 BRANCH=octopus TEST=build
Signed-off-by: peichao.wang peichao.wang@bitland.corp-partner.google.com Change-Id: I8cc5d73629990f19d2c1044debdba4990c54d07e --- M src/mainboard/google/octopus/variants/foob/Makefile.inc A src/mainboard/google/octopus/variants/foob/mainboard.c 2 files changed, 35 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/39424/3
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39424 )
Change subject: mb/google/octopus: Add custom SAR values for Foob360 ......................................................................
Patch Set 3:
(1 comment)
Patch Set 2:
(2 comments)
Done
https://review.coreboot.org/c/coreboot/+/39424/2/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/foob/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/39424/2/src/mainboard/google/octopu... PS2, Line 4: ramstage-y += mainboard.c
Please change the location to variant. […]
Done
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39424 )
Change subject: mb/google/octopus: Add custom SAR values for Foob360 ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39424/2/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/foob/mainboard.c:
https://review.coreboot.org/c/coreboot/+/39424/2/src/mainboard/google/octopu... PS2, Line 25: if (google_chromeec_cbi_get_sku_id(&sku_id))
Please call get_board_sku() intead. […]
Done
Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth, Henry Sun, Justin TerAvest, Marco Chen, Marco Chen,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39424
to look at the new patch set (#4).
Change subject: mb/google/octopus: Add custom SAR values for Foob360 ......................................................................
mb/google/octopus: Add custom SAR values for Foob360
Foob360 would prefer to use different SAR values. Since Foob360 sku id is 9.
BUG=b:149362272 BRANCH=octopus TEST=build
Signed-off-by: peichao.wang peichao.wang@bitland.corp-partner.google.com Change-Id: I8cc5d73629990f19d2c1044debdba4990c54d07e --- M src/mainboard/google/octopus/variants/foob/Makefile.inc A src/mainboard/google/octopus/variants/foob/mainboard.c 2 files changed, 36 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/39424/4
Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth, Henry Sun, Justin TerAvest, Marco Chen, Marco Chen,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39424
to look at the new patch set (#5).
Change subject: mb/google/octopus: Add custom SAR values for Foob360 ......................................................................
mb/google/octopus: Add custom SAR values for Foob360
Foob360 would prefer to use different SAR values. Since Foob360 sku id is 9.
BUG=b:149362272 BRANCH=octopus TEST=build
Signed-off-by: peichao.wang peichao.wang@bitland.corp-partner.google.com Change-Id: I8cc5d73629990f19d2c1044debdba4990c54d07e --- M src/mainboard/google/octopus/variants/foob/Makefile.inc A src/mainboard/google/octopus/variants/foob/mainboard.c 2 files changed, 33 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/39424/5
Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth, Henry Sun, Justin TerAvest, Marco Chen, Marco Chen,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39424
to look at the new patch set (#6).
Change subject: mb/google/octopus: Add custom SAR values for Foob360 ......................................................................
mb/google/octopus: Add custom SAR values for Foob360
Foob360 would prefer to use different SAR values. Since Foob360 sku id is 9.
BUG=b:149362272 BRANCH=octopus TEST=build
Signed-off-by: peichao.wang peichao.wang@bitland.corp-partner.google.com Change-Id: I8cc5d73629990f19d2c1044debdba4990c54d07e --- M src/mainboard/google/octopus/variants/foob/Makefile.inc A src/mainboard/google/octopus/variants/foob/mainboard.c 2 files changed, 33 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/39424/6
Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39424 )
Change subject: mb/google/octopus: Add custom SAR values for Foob360 ......................................................................
Patch Set 6:
hmm..I didn't see new patchset addressed comments?
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39424 )
Change subject: mb/google/octopus: Add custom SAR values for Foob360 ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39424/6/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/foob/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/39424/6/src/mainboard/google/octopu... PS6, Line 4: ramstage-y += gpio.c Why not using alphabetical order?
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39424 )
Change subject: mb/google/octopus: Add custom SAR values for Foob360 ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39424/6/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/foob/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/39424/6/src/mainboard/google/octopu... PS6, Line 4: ramstage-y += gpio.c
Why not using alphabetical order?
Because follow Phaser project, that leverage to Phaser.
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39424 )
Change subject: mb/google/octopus: Add custom SAR values for Foob360 ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39424/6/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/foob/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/39424/6/src/mainboard/google/octopu... PS6, Line 4: ramstage-y += gpio.c
Because follow Phaser project, that leverage to Phaser.
Done
Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39424 )
Change subject: mb/google/octopus: Add custom SAR values for Foob360 ......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39424/6/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/foob/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/39424/6/src/mainboard/google/octopu... PS6, Line 5: ramstage-y += mainboard.c Could we just put SAR function into variant.c as I mentioned earlier? I understand phaser is in mainboard.c but almost others are in variant.c actually?
https://review.coreboot.org/c/coreboot/+/39424/6/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/foob/mainboard.c:
https://review.coreboot.org/c/coreboot/+/39424/6/src/mainboard/google/octopu... PS6, Line 24: uint32_t sku_id = google_chromeec_get_board_sku(); Please call get_board_sku() intead. The reason is because there is a cache so no necessary to communicate to EC every time.
Tommie Lin has uploaded a new patch set (#7) to the change originally created by Peichao Li. ( https://review.coreboot.org/c/coreboot/+/39424 )
Change subject: mb/google/octopus: Add custom SAR values for Foob360 ......................................................................
mb/google/octopus: Add custom SAR values for Foob360
Foob360 would prefer to use different SAR values. Since Foob360 sku id is 9.
BUG=b:149362272 BRANCH=octopus TEST=build
Signed-off-by: peichao.wang peichao.wang@bitland.corp-partner.google.com Change-Id: I8cc5d73629990f19d2c1044debdba4990c54d07e --- M src/mainboard/google/octopus/variants/baseboard/include/baseboard/variants.h M src/mainboard/google/octopus/variants/foob/variant.c 2 files changed, 26 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/39424/7
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39424 )
Change subject: mb/google/octopus: Add custom SAR values for Foob360 ......................................................................
Patch Set 7:
(22 comments)
https://review.coreboot.org/c/coreboot/+/39424/7/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/foob/variant.c:
https://review.coreboot.org/c/coreboot/+/39424/7/src/mainboard/google/octopu... PS7, Line 41: const char *filename = NULL; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39424/7/src/mainboard/google/octopu... PS7, Line 41: const char *filename = NULL; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39424/7/src/mainboard/google/octopu... PS7, Line 42: uint32_t sku_id = get_board_sku(); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39424/7/src/mainboard/google/octopu... PS7, Line 42: uint32_t sku_id = get_board_sku(); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39424/7/src/mainboard/google/octopu... PS7, Line 44: if (sku_id == 9) code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39424/7/src/mainboard/google/octopu... PS7, Line 44: if (sku_id == 9) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39424/7/src/mainboard/google/octopu... PS7, Line 45: filename = "wifi_sar-foob360.hex"; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39424/7/src/mainboard/google/octopu... PS7, Line 45: filename = "wifi_sar-foob360.hex"; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39424/7/src/mainboard/google/octopu... PS7, Line 46: return filename; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39424/7/src/mainboard/google/octopu... PS7, Line 46: return filename; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39424/7/src/mainboard/google/octopu... PS7, Line 51: static uint32_t sku_id = SKU_UNKNOWN; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39424/7/src/mainboard/google/octopu... PS7, Line 51: static uint32_t sku_id = SKU_UNKNOWN; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39424/7/src/mainboard/google/octopu... PS7, Line 53: if (sku_id != SKU_UNKNOWN) code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39424/7/src/mainboard/google/octopu... PS7, Line 53: if (sku_id != SKU_UNKNOWN) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39424/7/src/mainboard/google/octopu... PS7, Line 54: return sku_id; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39424/7/src/mainboard/google/octopu... PS7, Line 54: return sku_id; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39424/7/src/mainboard/google/octopu... PS7, Line 56: if (google_chromeec_cbi_get_sku_id(&sku_id)) code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39424/7/src/mainboard/google/octopu... PS7, Line 56: if (google_chromeec_cbi_get_sku_id(&sku_id)) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39424/7/src/mainboard/google/octopu... PS7, Line 57: sku_id = SKU_UNKNOWN; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39424/7/src/mainboard/google/octopu... PS7, Line 57: sku_id = SKU_UNKNOWN; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39424/7/src/mainboard/google/octopu... PS7, Line 59: return sku_id; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39424/7/src/mainboard/google/octopu... PS7, Line 59: return sku_id; please, no spaces at the start of a line
Tommie Lin has uploaded a new patch set (#8) to the change originally created by Peichao Li. ( https://review.coreboot.org/c/coreboot/+/39424 )
Change subject: mb/google/octopus: Add custom SAR values for Foob360 ......................................................................
mb/google/octopus: Add custom SAR values for Foob360
Foob360 would prefer to use different SAR values. Since Foob360 sku id is 9.
BUG=b:149362272 BRANCH=octopus TEST=build
Signed-off-by: peichao.wang peichao.wang@bitland.corp-partner.google.com Change-Id: I8cc5d73629990f19d2c1044debdba4990c54d07e --- M src/mainboard/google/octopus/variants/baseboard/include/baseboard/variants.h M src/mainboard/google/octopus/variants/foob/variant.c 2 files changed, 26 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/39424/8
Tommie Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39424 )
Change subject: mb/google/octopus: Add custom SAR values for Foob360 ......................................................................
Patch Set 8:
(23 comments)
https://review.coreboot.org/c/coreboot/+/39424/6/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/foob/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/39424/6/src/mainboard/google/octopu... PS6, Line 5: ramstage-y += mainboard.c
Could we just put SAR function into variant. […]
Done
https://review.coreboot.org/c/coreboot/+/39424/7/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/foob/variant.c:
https://review.coreboot.org/c/coreboot/+/39424/7/src/mainboard/google/octopu... PS7, Line 41: const char *filename = NULL;
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/39424/7/src/mainboard/google/octopu... PS7, Line 41: const char *filename = NULL;
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/39424/7/src/mainboard/google/octopu... PS7, Line 42: uint32_t sku_id = get_board_sku();
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/39424/7/src/mainboard/google/octopu... PS7, Line 42: uint32_t sku_id = get_board_sku();
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/39424/7/src/mainboard/google/octopu... PS7, Line 44: if (sku_id == 9)
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/39424/7/src/mainboard/google/octopu... PS7, Line 44: if (sku_id == 9)
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/39424/7/src/mainboard/google/octopu... PS7, Line 45: filename = "wifi_sar-foob360.hex";
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/39424/7/src/mainboard/google/octopu... PS7, Line 45: filename = "wifi_sar-foob360.hex";
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/39424/7/src/mainboard/google/octopu... PS7, Line 46: return filename;
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/39424/7/src/mainboard/google/octopu... PS7, Line 46: return filename;
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/39424/7/src/mainboard/google/octopu... PS7, Line 51: static uint32_t sku_id = SKU_UNKNOWN;
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/39424/7/src/mainboard/google/octopu... PS7, Line 51: static uint32_t sku_id = SKU_UNKNOWN;
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/39424/7/src/mainboard/google/octopu... PS7, Line 53: if (sku_id != SKU_UNKNOWN)
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/39424/7/src/mainboard/google/octopu... PS7, Line 53: if (sku_id != SKU_UNKNOWN)
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/39424/7/src/mainboard/google/octopu... PS7, Line 54: return sku_id;
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/39424/7/src/mainboard/google/octopu... PS7, Line 54: return sku_id;
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/39424/7/src/mainboard/google/octopu... PS7, Line 56: if (google_chromeec_cbi_get_sku_id(&sku_id))
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/39424/7/src/mainboard/google/octopu... PS7, Line 56: if (google_chromeec_cbi_get_sku_id(&sku_id))
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/39424/7/src/mainboard/google/octopu... PS7, Line 57: sku_id = SKU_UNKNOWN;
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/39424/7/src/mainboard/google/octopu... PS7, Line 57: sku_id = SKU_UNKNOWN;
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/39424/7/src/mainboard/google/octopu... PS7, Line 59: return sku_id;
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/39424/7/src/mainboard/google/octopu... PS7, Line 59: return sku_id;
code indent should use tabs where possible
Done
Tommie Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39424 )
Change subject: mb/google/octopus: Add custom SAR values for Foob360 ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39424/6/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/foob/mainboard.c:
https://review.coreboot.org/c/coreboot/+/39424/6/src/mainboard/google/octopu... PS6, Line 24: uint32_t sku_id = google_chromeec_get_board_sku();
Please call get_board_sku() intead. […]
@Marco, I found that the function: get_board_sku() actually still uses the function: google_chromeec_cbi_get_sku_id ().
Tommie Lin has uploaded a new patch set (#9) to the change originally created by Peichao Li. ( https://review.coreboot.org/c/coreboot/+/39424 )
Change subject: mb/google/octopus: Add custom SAR values for Foob360 ......................................................................
mb/google/octopus: Add custom SAR values for Foob360
Foob360 would prefer to use different SAR values. Since Foob360 sku id is 9.
BUG=b:149362272 BRANCH=octopus TEST=build
Signed-off-by: peichao.wang peichao.wang@bitland.corp-partner.google.com Change-Id: I8cc5d73629990f19d2c1044debdba4990c54d07e --- M src/mainboard/google/octopus/variants/baseboard/include/baseboard/variants.h M src/mainboard/google/octopus/variants/foob/variant.c 2 files changed, 26 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/39424/9
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39424 )
Change subject: mb/google/octopus: Add custom SAR values for Foob360 ......................................................................
Patch Set 9:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39424/9/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/baseboard/include/baseboard/variants.h:
https://review.coreboot.org/c/coreboot/+/39424/9/src/mainboard/google/octopu... PS9, Line 39: uint32_t get_board_sku(void); No need to re-introduce this function.
https://review.coreboot.org/c/coreboot/+/39424/9/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/foob/variant.c:
https://review.coreboot.org/c/coreboot/+/39424/9/src/mainboard/google/octopu... PS9, Line 55: uint32_t sku_id = get_board_sku(); Please use google_chromeec_get_board_sku() like in line 34 instead of get_board_sku().
Tommie Lin has uploaded a new patch set (#10) to the change originally created by Peichao Li. ( https://review.coreboot.org/c/coreboot/+/39424 )
Change subject: mb/google/octopus: Add custom SAR values for Foob360 ......................................................................
mb/google/octopus: Add custom SAR values for Foob360
Foob360 would prefer to use different SAR values. Since Foob360 sku id is 9.
BUG=b:149362272 BRANCH=octopus TEST=build
Signed-off-by: peichao.wang peichao.wang@bitland.corp-partner.google.com Change-Id: I8cc5d73629990f19d2c1044debdba4990c54d07e --- M src/mainboard/google/octopus/variants/baseboard/include/baseboard/variants.h M src/mainboard/google/octopus/variants/foob/variant.c 2 files changed, 14 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/39424/10
Tommie Lin has uploaded a new patch set (#11) to the change originally created by Peichao Li. ( https://review.coreboot.org/c/coreboot/+/39424 )
Change subject: mb/google/octopus: Add custom SAR values for Foob360 ......................................................................
mb/google/octopus: Add custom SAR values for Foob360
Foob360 would prefer to use different SAR values. Since Foob360 sku id is 9.
BUG=b:149362272 BRANCH=octopus TEST=build
Signed-off-by: peichao.wang peichao.wang@bitland.corp-partner.google.com Change-Id: I8cc5d73629990f19d2c1044debdba4990c54d07e --- M src/mainboard/google/octopus/variants/foob/variant.c 1 file changed, 12 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/39424/11
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39424 )
Change subject: mb/google/octopus: Add custom SAR values for Foob360 ......................................................................
Patch Set 11: Code-Review+2
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39424 )
Change subject: mb/google/octopus: Add custom SAR values for Foob360 ......................................................................
Patch Set 11:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39424/9/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/baseboard/include/baseboard/variants.h:
https://review.coreboot.org/c/coreboot/+/39424/9/src/mainboard/google/octopu... PS9, Line 39: uint32_t get_board_sku(void);
No need to re-introduce this function.
Done
https://review.coreboot.org/c/coreboot/+/39424/6/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/foob/mainboard.c:
https://review.coreboot.org/c/coreboot/+/39424/6/src/mainboard/google/octopu... PS6, Line 24: uint32_t sku_id = google_chromeec_get_board_sku();
@Marco, I found that the function: get_board_sku() actually still uses the function: google_chromeec […]
Done
https://review.coreboot.org/c/coreboot/+/39424/9/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/foob/variant.c:
https://review.coreboot.org/c/coreboot/+/39424/9/src/mainboard/google/octopu... PS9, Line 55: uint32_t sku_id = get_board_sku();
Please use google_chromeec_get_board_sku() like in line 34 instead of get_board_sku().
Done
Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39424 )
Change subject: mb/google/octopus: Add custom SAR values for Foob360 ......................................................................
Patch Set 11: Code-Review+2
looks like get_board_sku() was re-named to google_chromeec_get_board_sku() already.
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39424 )
Change subject: mb/google/octopus: Add custom SAR values for Foob360 ......................................................................
mb/google/octopus: Add custom SAR values for Foob360
Foob360 would prefer to use different SAR values. Since Foob360 sku id is 9.
BUG=b:149362272 BRANCH=octopus TEST=build
Signed-off-by: peichao.wang peichao.wang@bitland.corp-partner.google.com Change-Id: I8cc5d73629990f19d2c1044debdba4990c54d07e Reviewed-on: https://review.coreboot.org/c/coreboot/+/39424 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Marco Chen marcochen@google.com --- M src/mainboard/google/octopus/variants/foob/variant.c 1 file changed, 12 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Marco Chen: Looks good to me, approved Peichao Li: Looks good to me, approved
diff --git a/src/mainboard/google/octopus/variants/foob/variant.c b/src/mainboard/google/octopus/variants/foob/variant.c index 47639f6..d5d7658 100644 --- a/src/mainboard/google/octopus/variants/foob/variant.c +++ b/src/mainboard/google/octopus/variants/foob/variant.c @@ -16,6 +16,7 @@ #include <baseboard/variants.h> #include <soc/pci_devs.h> #include <ec/google/chromeec/ec.h> +#include <sar.h>
#define SKU_UNKNOWN 0xFFFFFFFF
@@ -34,3 +35,14 @@ if (no_touchscreen_sku(sku_id)) touchscreen_i2c_host->enabled = 0; } + +const char *get_wifi_sar_cbfs_filename(void) +{ + const char *filename = NULL; + uint32_t sku_id = SKU_UNKNOWN; + + sku_id = google_chromeec_get_board_sku(); + if (sku_id == 9) + filename = "wifi_sar-foob360.hex"; + return filename; +}
-
build bot (Jenkins) (Code Review) -
Frans Hendriks (Code Review)
-
Karthik Ramasubramanian (Code Review)
-
Marco Chen (Code Review)
-
Patrick Georgi (Code Review)
-
Peichao Li (Code Review)
-
Tommie Lin (Code Review)