Attention is currently required from: Zoey Wu, Zhuohao Lee, Felix Held.
Raihow Shi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62314 )
Change subject: mb/google/brask/variants/moli: set up gpio
......................................................................
Patch Set 9:
(3 comments)
File src/mainboard/google/brya/variants/moli/gpio.c:
https://review.coreboot.org/c/coreboot/+/62314/comment/b1b45955_98744311
PS7, Line 26: PAD_CFG_GPI(GPP_B23, NONE, DEEP),
Why is this an input? It's the same signal as the baseboard, PCHHOT# which we are not currently usin […]
done
https://review.coreboot.org/c/coreboot/+/62314/comment/545cfbf0_cd57b9ae
PS7, Line 48: /* E6 : THC0_SPI1_RST# ==> GPPE6_STRAP */
: PAD_CFG_GPO(GPP_E6, 1, DEEP),
I think the baseboard setting is OK here?
done
File src/mainboard/google/brya/variants/moli/ramstage.c:
https://review.coreboot.org/c/coreboot/+/62314/comment/8ec65459_7ed68c48
PS1, Line 1: /* SPDX-License-Identifier: GPL-2.0-or-later */
Adding this file should be a separate patch
Hi Tim!
I will add this file to a separate patch
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62314
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7ec41cb843419c32337b66f3877eda5d730cea35
Gerrit-Change-Number: 62314
Gerrit-PatchSet: 9
Gerrit-Owner: Raihow Shi
raihow_shi@wistron.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: YH Lin
yueherngl@google.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Anfernee Chen
anfernee_chen@wistron.corp-partner.google.com
Gerrit-CC: Ariel Fang
ariel_fang@wistron.corp-partner.google.com
Gerrit-CC: Casper Chang
casper_chang@wistron.corp-partner.google.com
Gerrit-CC: Malik Hsu
malik_hsu@wistron.com
Gerrit-CC: Mark Hsieh
mark_hsieh@wistron.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Peter Chi
peter_chi@wistron.corp-partner.google.com
Gerrit-CC: Scott Chao
scott_chao@wistron.corp-partner.google.com
Gerrit-CC: Terry Chen
terry_chen@wistron.corp-partner.google.com
Gerrit-CC: Will Tsai
will_tsai@wistron.corp-partner.google.com
Gerrit-CC: Zoey Wu
zoey_wu@wistron.corp-partner.google.com
Gerrit-Attention: Zoey Wu
zoey_wu@wistron.corp-partner.google.com
Gerrit-Attention: Zhuohao Lee
zhuohao@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 03 Mar 2022 05:54:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment