build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25382 )
Change subject: soc/cavium: Apply additional devicetree fixups ......................................................................
Patch Set 36:
(4 comments)
https://review.coreboot.org/#/c/25382/36/src/soc/cavium/cn81xx/soc.c File src/soc/cavium/cn81xx/soc.c:
https://review.coreboot.org/#/c/25382/36/src/soc/cavium/cn81xx/soc.c@82 PS36, Line 82: Remove 'phy-handle' if this option is not availble */ 'availble' may be misspelled - perhaps 'available'?
https://review.coreboot.org/#/c/25382/36/src/soc/cavium/cn81xx/soc.c@140 PS36, Line 140: /* Extract our MAC address info so we can assign them in the device tree */ line over 80 characters
https://review.coreboot.org/#/c/25382/36/src/soc/cavium/cn81xx/soc.c@172 PS36, Line 172: if (!strcmp(name, prop->prop.name)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/25382/36/src/soc/cavium/cn81xx/soc.c@268 PS36, Line 268: BDK_BGXX_CMRX_RX_DMAC_CTL(bgx_interface, bgx_index)); line over 80 characters