[XL] Change in coreboot[main]: DNS: Example of clang format

[Martin L Roth (Code Review)]

Attention is currently required from: Angel Pons, Boris Mittelberg, Caveh Jalali, Cliff Huang, Felix Held, Hung-Te Lin, Jérémy Compostella, Lance Zhao, Philipp Hug, Sean Rhodes, Tim Wawrzynczak, Yidi Lin, Yu-Ping Wu, ron minnich.

Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78833?usp=email )

Change subject: DNS: Example of clang format
......................................................................

Patch Set 4:

(4 comments)

File src/drivers/intel/gma/i915_reg.h:

PS4:
> the removed 2 space indentations make this more difficult to read

Right, unfortunately that's just a coreboot convention. We might be able to add a change to indent macros  that are the format (X << Y) or BIT(Y), but things like `#define   GEN6_MBC_SNPCR_SHIFT	21` are going to be more problematic.

File src/drivers/pc80/vga/vga_font_8x16.c:

PS4:
> this makes this file much worse than before. […]

This is probably related to the trailing comma issue as well. If we removed the final comma of each section, I think it would be better, but I suspect that's some sort of bug in clang-format.

File src/include/device/pci_ids.h:

PS4:
> i'd say that this looked better before the change

We can fix that by enabling alignment over blank lines, but that might break things in other places.

File src/northbridge/intel/gm45/raminit.c:

https://review.coreboot.org/c/coreboot/+/78833/comment/5d4729dc_e53a582e :
PS4, Line 942:  /* VCO 3200 */
> would moving the comments after the array elements make things to work better?

Yes, i tested that and it did.