Change in coreboot[master]: md/ocp/tiogapass: move local *.h to include dir

[Maxim Polyakov (Code Review)]

Maxim Polyakov has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40733 )

Change subject: md/ocp/tiogapass: move local *.h to include dir
......................................................................

md/ocp/tiogapass: move local *.h to include dir

Change-Id: I4e3ef5882d6cb0ddbcb8357b54106ff2f47e4c51
Signed-off-by: Maxim Polyakov 
---
M src/mainboard/ocp/tiogapass/bootblock.c
R src/mainboard/ocp/tiogapass/include/gpio.h
R src/mainboard/ocp/tiogapass/include/skxsp_tp_iio.h
M src/mainboard/ocp/tiogapass/ramstage.c
M src/mainboard/ocp/tiogapass/romstage.c
5 files changed, 3 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/40733/1

diff --git a/src/mainboard/ocp/tiogapass/bootblock.c b/src/mainboard/ocp/tiogapass/bootblock.c
index 1fee5e5..bb884c0 100644
--- a/src/mainboard/ocp/tiogapass/bootblock.c
+++ b/src/mainboard/ocp/tiogapass/bootblock.c
@@ -9,7 +9,7 @@
 #include <soc/pcr_ids.h>
 #include <superio/aspeed/ast2400/ast2400.h>
 #include <superio/aspeed/common/aspeed.h>
-#include "gpio.h"
+#include "include/gpio.h"

/* these are defined in intelblocks/lpc_lib.h but we can't use them yet */
 #define PCR_DMI_LPCIOD 0x2770
diff --git a/src/mainboard/ocp/tiogapass/gpio.h b/src/mainboard/ocp/tiogapass/include/gpio.h
similarity index 100%
rename from src/mainboard/ocp/tiogapass/gpio.h
rename to src/mainboard/ocp/tiogapass/include/gpio.h
diff --git a/src/mainboard/ocp/tiogapass/skxsp_tp_iio.h b/src/mainboard/ocp/tiogapass/include/skxsp_tp_iio.h
similarity index 100%
rename from src/mainboard/ocp/tiogapass/skxsp_tp_iio.h
rename to src/mainboard/ocp/tiogapass/include/skxsp_tp_iio.h
diff --git a/src/mainboard/ocp/tiogapass/ramstage.c b/src/mainboard/ocp/tiogapass/ramstage.c
index fba1d80..637f709 100644
--- a/src/mainboard/ocp/tiogapass/ramstage.c
+++ b/src/mainboard/ocp/tiogapass/ramstage.c
@@ -14,7 +14,7 @@
  */
 #include <soc/ramstage.h>
 #include <bootstate.h>
-#include "gpio.h"
+#include "include/gpio.h"

void mainboard_silicon_init_params(FSPS_UPD *params)
 {
diff --git a/src/mainboard/ocp/tiogapass/romstage.c b/src/mainboard/ocp/tiogapass/romstage.c
index 818bbcf..ab27df3 100644
--- a/src/mainboard/ocp/tiogapass/romstage.c
+++ b/src/mainboard/ocp/tiogapass/romstage.c
@@ -16,8 +16,7 @@
 #include <fsp/api.h>
 #include <FspmUpd.h>
 #include <soc/romstage.h>
-
-#include "skxsp_tp_iio.h"
+#include "include/skxsp_tp_iio.h"

static void mainboard_config_iio(FSPM_UPD *mupd)
 {

[Maxim Polyakov (Code Review)]

Maxim Polyakov has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/40733 )

Change subject: md/ocp/tiogapass: move local *.h to include dir
......................................................................

md/ocp/tiogapass: move local *.h to include dir

Change-Id: I4e3ef5882d6cb0ddbcb8357b54106ff2f47e4c51
Signed-off-by: Maxim Polyakov 
---
M src/mainboard/ocp/tiogapass/bootblock.c
R src/mainboard/ocp/tiogapass/include/gpio.h
R src/mainboard/ocp/tiogapass/include/skxsp_tp_iio.h
M src/mainboard/ocp/tiogapass/ramstage.c
M src/mainboard/ocp/tiogapass/romstage.c
5 files changed, 3 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/40733/2

[Maxim Polyakov (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40733

to look at the new patch set (#3).

Change subject: md/ocp/tiogapass: move local *.h to include dir
......................................................................

md/ocp/tiogapass: move local *.h to include dir

Change-Id: I4e3ef5882d6cb0ddbcb8357b54106ff2f47e4c51
Signed-off-by: Maxim Polyakov 
---
M src/mainboard/ocp/tiogapass/bootblock.c
R src/mainboard/ocp/tiogapass/include/gpio.h
R src/mainboard/ocp/tiogapass/include/skxsp_tp_iio.h
M src/mainboard/ocp/tiogapass/ramstage.c
M src/mainboard/ocp/tiogapass/romstage.c
5 files changed, 3 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/40733/3

[Maxim Polyakov (Code Review)]

Hello build bot (Jenkins), Paul Menzel,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40733

to look at the new patch set (#4).

Change subject: md/ocp/tiogapass: move local *.h to include dir
......................................................................

md/ocp/tiogapass: move local *.h to include dir

Change-Id: I4e3ef5882d6cb0ddbcb8357b54106ff2f47e4c51
Signed-off-by: Maxim Polyakov 
---
M src/mainboard/ocp/tiogapass/bootblock.c
R src/mainboard/ocp/tiogapass/include/gpio.h
R src/mainboard/ocp/tiogapass/include/skxsp_tp_iio.h
M src/mainboard/ocp/tiogapass/ramstage.c
M src/mainboard/ocp/tiogapass/romstage.c
5 files changed, 3 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/40733/4

[Andrey Petrov (Code Review)]

Andrey Petrov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40733 )

Change subject: md/ocp/tiogapass: move local *.h to include dir
......................................................................

Patch Set 4:

could you please elaborate what we are trying to achieve here and why ?

[Maxim Polyakov (Code Review)]

Hello build bot (Jenkins), Paul Menzel,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40733

to look at the new patch set (#5).

Change subject: md/ocp/tiogapass: move local *.h to include dir
......................................................................

md/ocp/tiogapass: move local *.h to include dir

Change-Id: I4e3ef5882d6cb0ddbcb8357b54106ff2f47e4c51
Signed-off-by: Maxim Polyakov 
---
M src/mainboard/ocp/tiogapass/bootblock.c
R src/mainboard/ocp/tiogapass/include/gpio.h
R src/mainboard/ocp/tiogapass/include/skxsp_tp_iio.h
M src/mainboard/ocp/tiogapass/romstage.c
4 files changed, 2 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/40733/5

[Andrey Petrov (Code Review)]

Andrey Petrov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40733 )

Change subject: md/ocp/tiogapass: move local *.h to include dir
......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40733/6/src/mainboard/ocp/tiogapass... 
File src/mainboard/ocp/tiogapass/romstage.c:

https://review.coreboot.org/c/coreboot/+/40733/6/src/mainboard/ocp/tiogapass... 
PS6, Line 19: include/skxsp_tp_iio.h"
I think we usually just add -Ifoo in the makefiles to avoid "" include

Change in coreboot[master]: md/tiogapass: move all *.h to dir and make them global

[Maxim Polyakov (Code Review)]

Hello build bot (Jenkins), Paul Menzel,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40733

to look at the new patch set (#7).

Change subject: md/tiogapass: move all *.h to dir and make them global
......................................................................

md/tiogapass: move all *.h to dir and make them global

It is necessary to rename the file gpio.h so that there are no conflict
with another file (src/include/gpio.h)

Change-Id: I4e3ef5882d6cb0ddbcb8357b54106ff2f47e4c51
Signed-off-by: Maxim Polyakov 
---
M src/mainboard/ocp/tiogapass/Makefile.inc
M src/mainboard/ocp/tiogapass/bootblock.c
D src/mainboard/ocp/tiogapass/gpio.h
R src/mainboard/ocp/tiogapass/include/skxsp_tp_iio.h
M src/mainboard/ocp/tiogapass/romstage.c
5 files changed, 3 insertions(+), 548 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/40733/7

Change in coreboot[master]: md/tiogapass: move all *.h to dir and make them global

[Maxim Polyakov (Code Review)]

Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Paul Menzel,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40733

to look at the new patch set (#8).

Change subject: md/tiogapass: move all *.h to dir and make them global
......................................................................

md/tiogapass: move all *.h to dir and make them global

It is necessary to rename the file gpio.h so that there are no conflict
with another file (src/include/gpio.h)

Change-Id: I4e3ef5882d6cb0ddbcb8357b54106ff2f47e4c51
Signed-off-by: Maxim Polyakov 
---
M src/mainboard/ocp/tiogapass/Makefile.inc
M src/mainboard/ocp/tiogapass/bootblock.c
R src/mainboard/ocp/tiogapass/include/skxsp_tp_iio.h
R src/mainboard/ocp/tiogapass/include/tp_pch_gpio.h
M src/mainboard/ocp/tiogapass/romstage.c
5 files changed, 3 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/40733/8

Change in coreboot[master]: md/tiogapass: move all *.h to dir and make them global

[Maxim Polyakov (Code Review)]

Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40733 )

Change subject: md/tiogapass: move all *.h to dir and make them global
......................................................................

Patch Set 8:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40733/6/src/mainboard/ocp/tiogapass... 
File src/mainboard/ocp/tiogapass/romstage.c:

https://review.coreboot.org/c/coreboot/+/40733/6/src/mainboard/ocp/tiogapass... 
PS6, Line 19: include/skxsp_tp_iio.h"
> I think we usually just add -Ifoo in the makefiles to avoid "" include

Done

Change in coreboot[master]: md/tiogapass: move all *.h to dir and make them global

[Andrey Petrov (Code Review)]

Andrey Petrov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40733 )

Change subject: md/tiogapass: move all *.h to dir and make them global
......................................................................

Patch Set 8: Code-Review+2

Change in coreboot[master]: md/tiogapass: move all *.h to dir and make them global

[Maxim Polyakov (Code Review)]

Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Paul Menzel, Andrey Petrov,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40733

to look at the new patch set (#9).

Change subject: md/tiogapass: move all *.h to dir and make them global
......................................................................

md/tiogapass: move all *.h to dir and make them global

It is necessary to rename the file gpio.h so that there are no conflict
with another file (src/include/gpio.h)

Change-Id: I4e3ef5882d6cb0ddbcb8357b54106ff2f47e4c51
Signed-off-by: Maxim Polyakov 
---
M src/mainboard/ocp/tiogapass/Makefile.inc
M src/mainboard/ocp/tiogapass/bootblock.c
R src/mainboard/ocp/tiogapass/include/skxsp_tp_iio.h
R src/mainboard/ocp/tiogapass/include/tp_pch_gpio.h
M src/mainboard/ocp/tiogapass/romstage.c
5 files changed, 3 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/40733/9

Change in coreboot[master]: md/tiogapass: move all *.h to dir and make them global

[Andrey Petrov (Code Review)]

Andrey Petrov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40733 )

Change subject: md/tiogapass: move all *.h to dir and make them global
......................................................................

Patch Set 9: Code-Review+2

Change in coreboot[master]: md/tiogapass: move all *.h to dir and make them global

[Maxim Polyakov (Code Review)]

Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Paul Menzel, Andrey Petrov,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40733

to look at the new patch set (#10).

Change subject: md/tiogapass: move all *.h to dir and make them global
......................................................................

md/tiogapass: move all *.h to dir and make them global

It is necessary to rename the file gpio.h so that there are no conflict
with another file (src/include/gpio.h)

Change-Id: I4e3ef5882d6cb0ddbcb8357b54106ff2f47e4c51
Signed-off-by: Maxim Polyakov 
---
M src/mainboard/ocp/tiogapass/Makefile.inc
M src/mainboard/ocp/tiogapass/bootblock.c
R src/mainboard/ocp/tiogapass/include/skxsp_tp_iio.h
R src/mainboard/ocp/tiogapass/include/tp_pch_gpio.h
M src/mainboard/ocp/tiogapass/romstage.c
5 files changed, 3 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/40733/10

Change in coreboot[master]: md/tiogapass: move all *.h to dir and make them global

[Maxim Polyakov (Code Review)]

Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Paul Menzel, Andrey Petrov,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40733

to look at the new patch set (#11).

Change subject: md/tiogapass: move all *.h to dir and make them global
......................................................................

md/tiogapass: move all *.h to dir and make them global

It is necessary to rename the file gpio.h so that there are no conflict
with another file (src/include/gpio.h)

Change-Id: I4e3ef5882d6cb0ddbcb8357b54106ff2f47e4c51
Signed-off-by: Maxim Polyakov 
---
M src/mainboard/ocp/tiogapass/Makefile.inc
M src/mainboard/ocp/tiogapass/bootblock.c
R src/mainboard/ocp/tiogapass/include/skxsp_tp_iio.h
R src/mainboard/ocp/tiogapass/include/tp_pch_gpio.h
M src/mainboard/ocp/tiogapass/romstage.c
5 files changed, 3 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/40733/11

Change in coreboot[master]: md/tiogapass: move all *.h to dir and make them global

[Andrey Petrov (Code Review)]

Andrey Petrov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40733 )

Change subject: md/tiogapass: move all *.h to dir and make them global
......................................................................

Patch Set 11: Code-Review+2

Change in coreboot[master]: md/tiogapass: move all *.h to dir and make them global

[Andrey Petrov (Code Review)]

Andrey Petrov has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40733 )

Change subject: md/tiogapass: move all *.h to dir and make them global
......................................................................

md/tiogapass: move all *.h to dir and make them global

It is necessary to rename the file gpio.h so that there are no conflict
with another file (src/include/gpio.h)

Change-Id: I4e3ef5882d6cb0ddbcb8357b54106ff2f47e4c51
Signed-off-by: Maxim Polyakov 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/40733
Reviewed-by: Andrey Petrov 
Tested-by: build bot (Jenkins) 
---
M src/mainboard/ocp/tiogapass/Makefile.inc
M src/mainboard/ocp/tiogapass/bootblock.c
R src/mainboard/ocp/tiogapass/include/skxsp_tp_iio.h
R src/mainboard/ocp/tiogapass/include/tp_pch_gpio.h
M src/mainboard/ocp/tiogapass/romstage.c
5 files changed, 3 insertions(+), 4 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Andrey Petrov: Looks good to me, approved

diff --git a/src/mainboard/ocp/tiogapass/Makefile.inc b/src/mainboard/ocp/tiogapass/Makefile.inc
index 27370fd..e80a594 100644
--- a/src/mainboard/ocp/tiogapass/Makefile.inc
+++ b/src/mainboard/ocp/tiogapass/Makefile.inc
@@ -17,5 +17,5 @@
 ramstage-y += ramstage.c
 ramstage-$(CONFIG_HAVE_ACPI_TABLES) += fadt.c

-CPPFLAGS_common += -Isrc/mainboard/$(MAINBOARDDIR)/
+CPPFLAGS_common += -I$(src)/mainboard/$(MAINBOARDDIR)/include
 CPPFLAGS_common += -I$(CONFIG_FSP_HEADER_PATH)
diff --git a/src/mainboard/ocp/tiogapass/bootblock.c b/src/mainboard/ocp/tiogapass/bootblock.c
index dbb3b6a..4ca4ca5 100644
--- a/src/mainboard/ocp/tiogapass/bootblock.c
+++ b/src/mainboard/ocp/tiogapass/bootblock.c
@@ -10,7 +10,7 @@
 #include <soc/pcr_ids.h>
 #include <superio/aspeed/ast2400/ast2400.h>
 #include <superio/aspeed/common/aspeed.h>
-#include "gpio.h"
+#include <tp_pch_gpio.h>

/* these are defined in intelblocks/lpc_lib.h but we can't use them yet */
 #define PCR_DMI_LPCIOD 0x2770
diff --git a/src/mainboard/ocp/tiogapass/skxsp_tp_iio.h b/src/mainboard/ocp/tiogapass/include/skxsp_tp_iio.h
similarity index 100%
rename from src/mainboard/ocp/tiogapass/skxsp_tp_iio.h
rename to src/mainboard/ocp/tiogapass/include/skxsp_tp_iio.h
diff --git a/src/mainboard/ocp/tiogapass/gpio.h b/src/mainboard/ocp/tiogapass/include/tp_pch_gpio.h
similarity index 100%
rename from src/mainboard/ocp/tiogapass/gpio.h
rename to src/mainboard/ocp/tiogapass/include/tp_pch_gpio.h
diff --git a/src/mainboard/ocp/tiogapass/romstage.c b/src/mainboard/ocp/tiogapass/romstage.c
index 41f7856..dcd198d 100644
--- a/src/mainboard/ocp/tiogapass/romstage.c
+++ b/src/mainboard/ocp/tiogapass/romstage.c
@@ -19,8 +19,7 @@
 #include <string.h>
 #include <gpio.h>
 #include <soc/lewisburg_pch_gpio_defs.h>
-
-#include "skxsp_tp_iio.h"
+#include <skxsp_tp_iio.h>

static uint8_t iio_table_buf[sizeof(tp_iio_bifur_table)];

Change in coreboot[master]: md/tiogapass: move all *.h to dir and make them global

[9elements QA (Code Review)]

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40733 )

Change subject: md/tiogapass: move all *.h to dir and make them global
......................................................................

Patch Set 12:

Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4
Emulation targets:
"QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/3082
"QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/3081
"QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/3080
"QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/3079

Please note: This test is under development and might not be accurate at all!