Change in coreboot[master]: intel/commonblocks/tcss: Add API for Type-C port orientation - coreboot-gerrit

14 May 2021


      Attention is currently required from: Caveh Jalali, Nick Vaccaro, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54294 )
Change subject: intel/commonblocks/tcss: Add API for Type-C port orientation
......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/common/block/include/intelblocks/tcss.h:
https://review.coreboot.org/c/coreboot/+/54294/comment/fda8ed3f_db098299 
PS1, Line 102: ori, ena)
suggestion: an enum or #define for these values would be very helpful
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/54294
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id5510d1c9e97bd104c89cde7dd38ad791f859d7c
Gerrit-Change-Number: 54294
Gerrit-PatchSet: 1
Gerrit-Owner: Caveh Jalali caveh@chromium.org
Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Caveh Jalali caveh@chromium.org
Gerrit-Attention: Nick Vaccaro nvaccaro@google.com
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Comment-Date: Fri, 14 May 2021 17:14:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment