HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37743 )
Change subject: [try] mb/amd/thatcher: switch away from ROMCC_BOOTBLOCK ......................................................................
[try] mb/amd/thatcher: switch away from ROMCC_BOOTBLOCK
Untested.
Change-Id: I0c5148fa014ac960c6b6950394a76aac6f45819c Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/amd/thatcher/Kconfig M src/mainboard/amd/thatcher/Makefile.inc A src/mainboard/amd/thatcher/bootblock.c M src/mainboard/amd/thatcher/romstage.c 4 files changed, 44 insertions(+), 25 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/37743/1
diff --git a/src/mainboard/amd/thatcher/Kconfig b/src/mainboard/amd/thatcher/Kconfig index 2c0939c..e1c5aee 100644 --- a/src/mainboard/amd/thatcher/Kconfig +++ b/src/mainboard/amd/thatcher/Kconfig @@ -17,7 +17,6 @@
config BOARD_SPECIFIC_OPTIONS def_bool y - select ROMCC_BOOTBLOCK select CPU_AMD_AGESA_FAMILY15_TN select NORTHBRIDGE_AMD_AGESA_FAMILY15_TN select SOUTHBRIDGE_AMD_AGESA_HUDSON diff --git a/src/mainboard/amd/thatcher/Makefile.inc b/src/mainboard/amd/thatcher/Makefile.inc index f8895fa..4dde2cf 100644 --- a/src/mainboard/amd/thatcher/Makefile.inc +++ b/src/mainboard/amd/thatcher/Makefile.inc @@ -13,6 +13,8 @@ # GNU General Public License for more details. #
+bootblock-y += bootblock.c + romstage-y += buildOpts.c romstage-y += BiosCallOuts.c romstage-y += OemCustomize.c diff --git a/src/mainboard/amd/thatcher/bootblock.c b/src/mainboard/amd/thatcher/bootblock.c new file mode 100644 index 0000000..d4f7c8f --- /dev/null +++ b/src/mainboard/amd/thatcher/bootblock.c @@ -0,0 +1,42 @@ +/* + * This file is part of the coreboot project. + * + * Copyright (C) 2012 Advanced Micro Devices, Inc. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <bootblock_common.h> +#include <stdint.h> +#include <device/pci_ops.h> +#include <superio/smsc/lpc47n217/lpc47n217.h> + +#define SERIAL_DEV PNP_DEV(0x2e, LPC47N217_SP1) + +void bootblock_mainboard_early_init(void) +{ + u8 byte; + pci_devfn_t dev; + + /* Set LPC decode enables. */ + dev = PCI_DEV(0, 0x14, 3); + + byte = pci_read_config8(dev, 0x48); + byte |= 3; /* 2e, 2f */ + pci_write_config8(dev, 0x48, byte); + + /* For serial port. */ + pci_write_config32(dev, 0x44, 0xff03ffd5); + byte = pci_read_config8(dev, 0x48); + byte |= 3; /* 2e, 2f */ + pci_write_config8(dev, 0x48, byte); + + lpc47n217_enable_serial(SERIAL_DEV, CONFIG_TTYS0_BASE); +} diff --git a/src/mainboard/amd/thatcher/romstage.c b/src/mainboard/amd/thatcher/romstage.c index 5678021..1c64281 100644 --- a/src/mainboard/amd/thatcher/romstage.c +++ b/src/mainboard/amd/thatcher/romstage.c @@ -14,37 +14,13 @@ */
#include <stdint.h> -#include <device/pci_def.h> #include <arch/io.h> -#include <console/console.h> -#include <device/pci_ops.h> #include <northbridge/amd/agesa/state_machine.h> -#include <southbridge/amd/agesa/hudson/hudson.h> -#include <superio/smsc/lpc47n217/lpc47n217.h> - -#define SERIAL_DEV PNP_DEV(0x2e, LPC47N217_SP1)
void board_BeforeAgesa(struct sysinfo *cb) { - u8 byte; - pci_devfn_t dev; - - /* Set LPC decode enables. */ - dev = PCI_DEV(0, 0x14, 3); - - byte = pci_read_config8(dev, 0x48); - byte |= 3; /* 2e, 2f */ - pci_write_config8(dev, 0x48, byte); - post_code(0x30); - /* For serial port. */ - pci_write_config32(dev, 0x44, 0xff03ffd5); - byte = pci_read_config8(dev, 0x48); - byte |= 3; /* 2e, 2f */ - pci_write_config8(dev, 0x48, byte); - post_code(0x31); - lpc47n217_enable_serial(SERIAL_DEV, CONFIG_TTYS0_BASE);
outb(0x24, 0xcd6); outb(0x1, 0xcd7);
Hello build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37743
to look at the new patch set (#2).
Change subject: mb/amd/thatcher: switch away from ROMCC_BOOTBLOCK ......................................................................
mb/amd/thatcher: switch away from ROMCC_BOOTBLOCK
Untested.
Change-Id: I0c5148fa014ac960c6b6950394a76aac6f45819c Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/amd/thatcher/Kconfig M src/mainboard/amd/thatcher/Kconfig.name M src/mainboard/amd/thatcher/Makefile.inc A src/mainboard/amd/thatcher/bootblock.c M src/mainboard/amd/thatcher/romstage.c 5 files changed, 46 insertions(+), 30 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/37743/2
Hello build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37743
to look at the new patch set (#3).
Change subject: mb/amd/thatcher: Switch away from ROMCC_BOOTBLOCK ......................................................................
mb/amd/thatcher: Switch away from ROMCC_BOOTBLOCK
Untested.
Change-Id: I0c5148fa014ac960c6b6950394a76aac6f45819c Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/amd/thatcher/Kconfig M src/mainboard/amd/thatcher/Kconfig.name M src/mainboard/amd/thatcher/Makefile.inc A src/mainboard/amd/thatcher/bootblock.c M src/mainboard/amd/thatcher/romstage.c 5 files changed, 46 insertions(+), 30 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/37743/3
Hello build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37743
to look at the new patch set (#4).
Change subject: mb/amd/thatcher: Switch away from ROMCC_BOOTBLOCK ......................................................................
mb/amd/thatcher: Switch away from ROMCC_BOOTBLOCK
Warning: Not tested on hardware. To test, please fix the mainbord's Kconfig and Kconfig.name
Change-Id: I0c5148fa014ac960c6b6950394a76aac6f45819c Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/amd/thatcher/Makefile.inc A src/mainboard/amd/thatcher/bootblock.c M src/mainboard/amd/thatcher/romstage.c 3 files changed, 44 insertions(+), 24 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/37743/4
Mike Banon has uploaded a new patch set (#5) to the change originally created by HAOUAS Elyes. ( https://review.coreboot.org/c/coreboot/+/37743 )
Change subject: mb/amd/thatcher: Switch away from ROMCC_BOOTBLOCK ......................................................................
mb/amd/thatcher: Switch away from ROMCC_BOOTBLOCK
Warning: Not tested on hardware.
Change-Id: I0c5148fa014ac960c6b6950394a76aac6f45819c Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/amd/thatcher/Kconfig M src/mainboard/amd/thatcher/Kconfig.name M src/mainboard/amd/thatcher/Makefile.inc A src/mainboard/amd/thatcher/bootblock.c M src/mainboard/amd/thatcher/romstage.c 5 files changed, 46 insertions(+), 30 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/37743/5
Hello build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37743
to look at the new patch set (#10).
Change subject: [TESTME]mb/amd/thatcher: Switch away from ROMCC_BOOTBLOCK ......................................................................
[TESTME]mb/amd/thatcher: Switch away from ROMCC_BOOTBLOCK
Warning: Not tested on hardware.
Change-Id: I0c5148fa014ac960c6b6950394a76aac6f45819c Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/amd/thatcher/Kconfig M src/mainboard/amd/thatcher/Kconfig.name M src/mainboard/amd/thatcher/Makefile.inc A src/mainboard/amd/thatcher/bootblock.c M src/mainboard/amd/thatcher/romstage.c 5 files changed, 46 insertions(+), 30 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/37743/10
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37743 )
Change subject: [TESTME]mb/amd/thatcher: Switch away from ROMCC_BOOTBLOCK ......................................................................
Patch Set 11:
There is no real value rebasing these over and over again, specially unchanged. Every rebase just eats up hour or so of jenkins ecosystem time.
Mike Banon has uploaded a new patch set (#12) to the change originally created by HAOUAS Elyes. ( https://review.coreboot.org/c/coreboot/+/37743 )
Change subject: [TESTME]mb/amd/thatcher: Switch away from ROMCC_BOOTBLOCK ......................................................................
[TESTME]mb/amd/thatcher: Switch away from ROMCC_BOOTBLOCK
Warning: Not tested on hardware.
Change-Id: I0c5148fa014ac960c6b6950394a76aac6f45819c Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/amd/thatcher/Kconfig M src/mainboard/amd/thatcher/Kconfig.name M src/mainboard/amd/thatcher/Makefile.inc A src/mainboard/amd/thatcher/bootblock.c D src/mainboard/amd/thatcher/romstage.c 5 files changed, 39 insertions(+), 60 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/37743/12
Mike Banon has uploaded a new patch set (#13) to the change originally created by HAOUAS Elyes. ( https://review.coreboot.org/c/coreboot/+/37743 )
Change subject: [TESTME]mb/amd/thatcher: Switch away from ROMCC_BOOTBLOCK ......................................................................
[TESTME]mb/amd/thatcher: Switch away from ROMCC_BOOTBLOCK
Warning: Not tested on hardware.
Change-Id: I0c5148fa014ac960c6b6950394a76aac6f45819c Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/amd/thatcher/Kconfig M src/mainboard/amd/thatcher/Kconfig.name M src/mainboard/amd/thatcher/Makefile.inc A src/mainboard/amd/thatcher/bootblock.c D src/mainboard/amd/thatcher/romstage.c 5 files changed, 38 insertions(+), 60 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/37743/13
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/37743 )
Change subject: [TESTME]mb/amd/thatcher: Switch away from ROMCC_BOOTBLOCK ......................................................................
Abandoned
not tested
HAOUAS Elyes has restored this change. ( https://review.coreboot.org/c/coreboot/+/37743 )
Change subject: [TESTME]mb/amd/thatcher: Switch away from ROMCC_BOOTBLOCK ......................................................................
Restored
Mike Banon has uploaded a new patch set (#16) to the change originally created by HAOUAS Elyes. ( https://review.coreboot.org/c/coreboot/+/37743 )
Change subject: [TESTME]mb/amd/thatcher: Switch away from ROMCC_BOOTBLOCK ......................................................................
[TESTME]mb/amd/thatcher: Switch away from ROMCC_BOOTBLOCK
Warning: Not tested on hardware.
Change-Id: I0c5148fa014ac960c6b6950394a76aac6f45819c Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/amd/thatcher/Kconfig M src/mainboard/amd/thatcher/Kconfig.name M src/mainboard/amd/thatcher/Makefile.inc A src/mainboard/amd/thatcher/bootblock.c D src/mainboard/amd/thatcher/romstage.c 5 files changed, 38 insertions(+), 60 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/37743/16
Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37743 )
Change subject: [TESTME]mb/amd/thatcher: Switch away from ROMCC_BOOTBLOCK ......................................................................
Patch Set 16:
I'm a bit lost, why Gerrit tells "Merge Conflict" while local git rebases on master OK. Need a good sleep perhaps...
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37743 )
Change subject: [TESTME]mb/amd/thatcher: Switch away from ROMCC_BOOTBLOCK ......................................................................
Patch Set 16:
Patch Set 16:
I'm a bit lost, why Gerrit tells "Merge Conflict" while local git rebases on master OK. Need a good sleep perhaps...
Make, you have to "fix" missing 'include <device/pci_def.h> in this file 'src/mainboard/amd/thatcher/irq_tables.c' then rebase current patch on it.
Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37743 )
Change subject: [TESTME]mb/amd/thatcher: Switch away from ROMCC_BOOTBLOCK ......................................................................
Patch Set 16:
Patch Set 16:
Patch Set 16:
I'm a bit lost, why Gerrit tells "Merge Conflict" while local git rebases on master OK. Need a good sleep perhaps...
Make, you have to "fix" missing 'include <device/pci_def.h> in this file 'src/mainboard/amd/thatcher/irq_tables.c' then rebase current patch on it.
Perhaps it would be easier to just create a new change and abandon this one (sorry for being a noob when it comes to resolving these gerrit conflicts :P). I'm going to create a new change soon, if you accept this idea.
Hello build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37743
to look at the new patch set (#17).
Change subject: [TESTME]mb/amd/thatcher: Switch away from ROMCC_BOOTBLOCK ......................................................................
[TESTME]mb/amd/thatcher: Switch away from ROMCC_BOOTBLOCK
Warning: Not tested on hardware.
Change-Id: I0c5148fa014ac960c6b6950394a76aac6f45819c Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/amd/thatcher/Kconfig M src/mainboard/amd/thatcher/Kconfig.name M src/mainboard/amd/thatcher/Makefile.inc A src/mainboard/amd/thatcher/bootblock.c D src/mainboard/amd/thatcher/romstage.c 5 files changed, 38 insertions(+), 60 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/37743/17
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/37743 )
Change subject: [TESTME]mb/amd/thatcher: Switch away from ROMCC_BOOTBLOCK ......................................................................
Abandoned
no one will test ... so drop unmaintained board
-
HAOUAS Elyes (Code Review) -
Kyösti Mälkki (Code Review)
-
Mike Banon (Code Review)