Attention is currently required from: Stefan Reinauer.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/2725 )
Change subject: Add Intel Whitetip Mountain 2 mainboard
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/intel/wtm2/romstage.c:
https://review.coreboot.org/c/coreboot/+/2725/comment/58e544c6_45c1ac74
PS4, Line 121: spd_addresses: { 0xa2, 0x00, 0xa2, 0x00 },
These SPD addresses look wrong
Slippy has memory down, and may or may not be derived from this. Maybe this
really is 1 EEPROM for 2 channels with the same config? Also, the line changed
on purpose from WTM1 to WTM2. Can't be sure without the hardware at hand ofc.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/2725
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I999452d86f00a2c245fa39b1b76080f6a3b1e352
Gerrit-Change-Number: 2725
Gerrit-PatchSet: 4
Gerrit-Owner: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Duncan Laurie
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Comment-Date: Mon, 05 Sep 2022 21:54:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment