HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/20463
Change subject: smbios: Correct the system enclosure types ......................................................................
smbios: Correct the system enclosure types
Regarding the "System Management BIOS Reference Specification" Version: 3.1.1, Date: 2017-01-12 the Laptop is set to 0x09 and Notebook to 0x0a
Change-Id: I5538be0b434eed20d76aef6f26247e46d1225feb Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/arch/x86/smbios.c M src/include/smbios.h 2 files changed, 37 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/20463/1
diff --git a/src/arch/x86/smbios.c b/src/arch/x86/smbios.c index 97c5881..79279fa 100644 --- a/src/arch/x86/smbios.c +++ b/src/arch/x86/smbios.c @@ -426,7 +426,7 @@ t->power_supply_state = SMBIOS_STATE_SAFE; t->thermal_state = SMBIOS_STATE_SAFE; if (IS_ENABLED(CONFIG_SYSTEM_TYPE_LAPTOP)) - t->_type = SMBIOS_ENCLOSURE_NOTEBOOK; + t->_type = SMBIOS_ENCLOSURE_LAPTOP; else t->_type = SMBIOS_ENCLOSURE_DESKTOP; t->security_status = SMBIOS_STATE_SAFE; diff --git a/src/include/smbios.h b/src/include/smbios.h index 5a9ef37..0310344 100644 --- a/src/include/smbios.h +++ b/src/include/smbios.h @@ -278,8 +278,42 @@ } __attribute__((packed));
enum { - SMBIOS_ENCLOSURE_DESKTOP = 3, - SMBIOS_ENCLOSURE_NOTEBOOK = 9, + SMBIOS_ENCLOSURE_OTHER = 0x01, + SMBIOS_ENCLOSURE_UNKNOWN = 0x02, + SMBIOS_ENCLOSURE_DESKTOP = 0x03, + SMBIOS_ENCLOSURE_LOW_PROFILE_DESKTOP = 0x04, + SMBIOS_ENCLOSURE_PIZZA_BOX = 0x05, + SMBIOS_ENCLOSURE_MINI_TOWER = 0x06, + SMBIOS_ENCLOSURE_TOWER = 0x07, + SMBIOS_ENCLOSURE_PORTABLE = 0x08, + SMBIOS_ENCLOSURE_LAPTOP = 0x09, + SMBIOS_ENCLOSURE_NOTEBOOK = 0x0a, + SMBIOS_ENCLOSURE_HAND_HELD = 0x0b, + SMBIOS_ENCLOSURE_DOCKING_STATION = 0x0c, + SMBIOS_ENCLOSURE_ALL_IN_ONE = 0x0d, + SMBIOS_ENCLOSURE_SUB_NOTEBOOK = 0x0e, + SMBIOS_ENCLOSURE_SPACE-SAVING = 0x0f, + SMBIOS_ENCLOSURE_LUNCH_BOX = 0x10, + SMBIOS_ENCLOSURE_MAIN_SERVER_CHASSIS = 0x11, + SMBIOS_ENCLOSURE_EXPANSION_CHASSIS = 0x12, + SMBIOS_ENCLOSURE_SUBCHASSIS = 0x13, + SMBIOS_ENCLOSURE_BUS_EXPANSION_CHASSIS = 0x14, + SMBIOS_ENCLOSURE_PERIPHERAL_CHASSIS = 0x15, + SMBIOS_ENCLOSURE_RAID_CHASSIS = 0x16, + SMBIOS_ENCLOSURE_RACK_MOUNT_CHASSIS = 0x17, + SMBIOS_ENCLOSURE_SEALED-CASE_PC = 0x18, + SMBIOS_ENCLOSURE_MULTI-SYSTEM_CHASSIS = 0x19, + SMBIOS_ENCLOSURE_COMPACT_PCI = 0x1a, + SMBIOS_ENCLOSURE_ADVANCED_TCA = 0x1b, + SMBIOS_ENCLOSURE_BLADE = 0x1c, + SMBIOS_ENCLOSURE_BLADE_ENCLOSURE = 0x1d, + SMBIOS_ENCLOSURE_TABLET = 0x1e, + SMBIOS_ENCLOSURE_CONVERTIBLE = 0x1f, + SMBIOS_ENCLOSURE_DETACHABLE = 0x20, + SMBIOS_ENCLOSURE_IOT_GATEWAY = 0x21, + SMBIOS_ENCLOSURE_EMBEDDED_PC = 0x22, + SMBIOS_ENCLOSURE_MINI_PC = 0x23, + SMBIOS_ENCLOSURE_STICK_PC = 0x24, };
struct smbios_type3 {