Anand Vaikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79243?usp=email )
Change subject: src/mainboard/amd/birman: Add a new board variant for Phoenix SOC
......................................................................
Patch Set 4:
(2 comments)
Patchset:
PS4:
Why was it abandoned?
sorry for the confusion, I will upload the changes in a new PR with more description.
File src/mainboard/amd/birman/variants/birmanplus/port_descriptors.c:
https://review.coreboot.org/c/coreboot/+/79243/comment/abc7e7d0_268f3eee :
PS4, Line 182: const fsp_dxio_descriptor **dxio_descs, size_t *dxio_num,
`need consistent spacing around '*' (ctx:WxO)`
Please fix.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79243?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iabe38b1de33aad4c7ee165bec8eb1d617a4d8cba
Gerrit-Change-Number: 79243
Gerrit-PatchSet: 4
Gerrit-Owner: Anand Vaikar
a.vaikar2021@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: ritul guru
ritul.bits@gmail.com
Gerrit-Comment-Date: Wed, 22 Nov 2023 10:11:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment