Peter Lemenkov has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38709 )
Change subject: mb/lenovo/t530/devicetree: Drop unnecessary initialization ......................................................................
mb/lenovo/t530/devicetree: Drop unnecessary initialization
These two variables are initialized to zero by default.
Change-Id: I590f601b5297a9bfa93607442d7e0b8d79f1ab51 Signed-off-by: Peter Lemenkov lemenkov@gmail.com --- M src/mainboard/lenovo/t530/variants/w530/devicetree.cb 1 file changed, 0 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/38709/1
diff --git a/src/mainboard/lenovo/t530/variants/w530/devicetree.cb b/src/mainboard/lenovo/t530/variants/w530/devicetree.cb index c2e32e3..17b0b41 100644 --- a/src/mainboard/lenovo/t530/variants/w530/devicetree.cb +++ b/src/mainboard/lenovo/t530/variants/w530/devicetree.cb @@ -6,9 +6,6 @@ # Enable DisplayPort Hotplug with 6ms pulse register "gpu_dp_d_hotplug" = "0x06"
- register "gpu_dp_b_hotplug" = "0" - register "gpu_dp_c_hotplug" = "0" - # Enable Panel as LVDS and configure power delays register "gpu_panel_port_select" = "0" # LVDS register "gpu_panel_power_cycle_delay" = "6" # T7: 500ms
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38709 )
Change subject: mb/lenovo/t530/devicetree: Drop unnecessary initialization ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38709 )
Change subject: mb/lenovo/t530/devicetree: Drop unnecessary initialization ......................................................................
mb/lenovo/t530/devicetree: Drop unnecessary initialization
These two variables are initialized to zero by default.
Change-Id: I590f601b5297a9bfa93607442d7e0b8d79f1ab51 Signed-off-by: Peter Lemenkov lemenkov@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/38709 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Georgi pgeorgi@google.com --- M src/mainboard/lenovo/t530/variants/w530/devicetree.cb 1 file changed, 0 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved
diff --git a/src/mainboard/lenovo/t530/variants/w530/devicetree.cb b/src/mainboard/lenovo/t530/variants/w530/devicetree.cb index c2e32e3..17b0b41 100644 --- a/src/mainboard/lenovo/t530/variants/w530/devicetree.cb +++ b/src/mainboard/lenovo/t530/variants/w530/devicetree.cb @@ -6,9 +6,6 @@ # Enable DisplayPort Hotplug with 6ms pulse register "gpu_dp_d_hotplug" = "0x06"
- register "gpu_dp_b_hotplug" = "0" - register "gpu_dp_c_hotplug" = "0" - # Enable Panel as LVDS and configure power delays register "gpu_panel_port_select" = "0" # LVDS register "gpu_panel_power_cycle_delay" = "6" # T7: 500ms
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38709 )
Change subject: mb/lenovo/t530/devicetree: Drop unnecessary initialization ......................................................................
Patch Set 2:
Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3 Emulation targets: EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/1105 EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/1104 EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/1103
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Patrick Georgi (Code Review)
-
Peter Lemenkov (Code Review)