Change in coreboot[master]: TESTONLY: Link pagetables into programs instead of using a cbfs file - coreboot-gerrit

6 Jul 2021


      Attention is currently required from: Arthur Heymans.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56096 )
Change subject: TESTONLY: Link pagetables into programs instead of using a cbfs file
......................................................................
Patch Set 1:
(1 comment)
File src/cpu/x86/64bit/pt.S:
https://review.coreboot.org/c/coreboot/+/56096/comment/1f697318_f3e876de 
PS1, Line 14: .align 32
This is the alignment relative to _program. Shouldn't all CBFS files using this assembly code then be aligned to 4096 as well?
Does it work for bootblock where _eprogram is aligned to 4GiB instead of _program?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/56096
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ice4fd15d131b8c91bc98afad7f459ce3485b786d
Gerrit-Change-Number: 56096
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Comment-Date: Tue, 06 Jul 2021 07:48:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment