Attention is currently required from: Nico Huber, Patrick Georgi, Julius Werner, Kyösti Mälkki.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61307 )
Change subject: console: Add ANSI escape sequences for highlighting
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/61307/comment/09655650_b55e94e5
PS3, Line 17: minicom
picocom FTW!
File src/commonlib/include/commonlib/loglevel.h:
https://review.coreboot.org/c/coreboot/+/61307/comment/56505c39_b1f8dc01
PS3, Line 190: BIOS_LOG_ESCAPE_PATTERN
Looks like this isn't used.
If we did this in printk.c we could use `vtxprintf(wrap_putchar, BIOS_LOG_ESCAPE_PATTERN, args, NULL);`
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61307
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I868f4026918bc0e967c32e14bcf3ac05816415e8
Gerrit-Change-Number: 61307
Gerrit-PatchSet: 3
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
patrick@coreboot.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Patrick Georgi
patrick@coreboot.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Wed, 02 Feb 2022 23:19:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment