Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36636 )
Change subject: [WIP] arch/x86/smm: Move GNVS prototypes ......................................................................
[WIP] arch/x86/smm: Move GNVS prototypes
Change-Id: Ic8eac39e09d1c36044cb2e2a96edd5c7098b8259 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/soc/intel/baytrail/include/soc/nvs.h M src/soc/intel/broadwell/include/soc/nvs.h M src/soc/intel/denverton_ns/include/soc/nvs.h M src/soc/intel/fsp_baytrail/include/soc/nvs.h M src/southbridge/intel/bd82x6x/nvs.h M src/southbridge/intel/fsp_rangeley/nvs.h M src/southbridge/intel/ibexpeak/nvs.h M src/southbridge/intel/lynxpoint/nvs.h 8 files changed, 5 insertions(+), 16 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/36636/1
diff --git a/src/soc/intel/baytrail/include/soc/nvs.h b/src/soc/intel/baytrail/include/soc/nvs.h index 08ccbf4..4a89eb9 100644 --- a/src/soc/intel/baytrail/include/soc/nvs.h +++ b/src/soc/intel/baytrail/include/soc/nvs.h @@ -104,9 +104,8 @@ check_member(global_nvs_t, chromeos, GNVS_CHROMEOS_ACPI_OFFSET);
void acpi_create_gnvs(global_nvs_t *gnvs); -#ifdef __SMM__ + /* Used in SMM to find the ACPI GNVS address */ global_nvs_t *smm_get_gnvs(void); -#endif
#endif /* _BAYTRAIL_NVS_H_ */ diff --git a/src/soc/intel/broadwell/include/soc/nvs.h b/src/soc/intel/broadwell/include/soc/nvs.h index 63c7bde..456fda6 100644 --- a/src/soc/intel/broadwell/include/soc/nvs.h +++ b/src/soc/intel/broadwell/include/soc/nvs.h @@ -96,9 +96,8 @@ check_member(global_nvs_t, chromeos, GNVS_CHROMEOS_ACPI_OFFSET);
void acpi_create_gnvs(global_nvs_t *gnvs); -#ifdef __SMM__ + /* Used in SMM to find the ACPI GNVS address */ global_nvs_t *smm_get_gnvs(void); -#endif
#endif diff --git a/src/soc/intel/denverton_ns/include/soc/nvs.h b/src/soc/intel/denverton_ns/include/soc/nvs.h index 5a94b24..8d1bc6a 100644 --- a/src/soc/intel/denverton_ns/include/soc/nvs.h +++ b/src/soc/intel/denverton_ns/include/soc/nvs.h @@ -65,9 +65,7 @@
} __packed global_nvs_t;
-#ifdef __SMM__ /* Used in SMM to find the ACPI GNVS address */ global_nvs_t *smm_get_gnvs(void); -#endif
#endif /* _DENVERTON_NS_NVS_H_ */ diff --git a/src/soc/intel/fsp_baytrail/include/soc/nvs.h b/src/soc/intel/fsp_baytrail/include/soc/nvs.h index d42763a..df2fc60 100644 --- a/src/soc/intel/fsp_baytrail/include/soc/nvs.h +++ b/src/soc/intel/fsp_baytrail/include/soc/nvs.h @@ -65,9 +65,8 @@ } __packed global_nvs_t;
void acpi_create_gnvs(global_nvs_t *gnvs); -#ifdef __SMM__ + /* Used in SMM to find the ACPI GNVS address */ global_nvs_t *smm_get_gnvs(void); -#endif
#endif /* _BAYTRAIL_NVS_H_ */ diff --git a/src/southbridge/intel/bd82x6x/nvs.h b/src/southbridge/intel/bd82x6x/nvs.h index 6558511..a6b0bdb 100644 --- a/src/southbridge/intel/bd82x6x/nvs.h +++ b/src/southbridge/intel/bd82x6x/nvs.h @@ -155,8 +155,6 @@ } __packed global_nvs_t; check_member(global_nvs_t, chromeos, GNVS_CHROMEOS_ACPI_OFFSET);
-#ifdef __SMM__ /* Used in SMM to find the ACPI GNVS address */ global_nvs_t *smm_get_gnvs(void); -#endif void acpi_create_gnvs(global_nvs_t *gnvs); diff --git a/src/southbridge/intel/fsp_rangeley/nvs.h b/src/southbridge/intel/fsp_rangeley/nvs.h index 12de769..47fca68 100644 --- a/src/southbridge/intel/fsp_rangeley/nvs.h +++ b/src/southbridge/intel/fsp_rangeley/nvs.h @@ -146,7 +146,6 @@ } __packed global_nvs_t;
void acpi_create_gnvs(global_nvs_t *gnvs); -#ifdef __SMM__ + /* Used in SMM to find the ACPI GNVS address */ global_nvs_t *smm_get_gnvs(void); -#endif diff --git a/src/southbridge/intel/ibexpeak/nvs.h b/src/southbridge/intel/ibexpeak/nvs.h index 36db12c..a956398 100644 --- a/src/southbridge/intel/ibexpeak/nvs.h +++ b/src/southbridge/intel/ibexpeak/nvs.h @@ -153,8 +153,7 @@ } __packed global_nvs_t; check_member(global_nvs_t, chromeos, GNVS_CHROMEOS_ACPI_OFFSET);
-#ifdef __SMM__ /* Used in SMM to find the ACPI GNVS address */ global_nvs_t *smm_get_gnvs(void); -#endif + void acpi_create_gnvs(global_nvs_t *gnvs); diff --git a/src/southbridge/intel/lynxpoint/nvs.h b/src/southbridge/intel/lynxpoint/nvs.h index a8f0dea..3aca7bb 100644 --- a/src/southbridge/intel/lynxpoint/nvs.h +++ b/src/southbridge/intel/lynxpoint/nvs.h @@ -130,9 +130,7 @@ } __packed global_nvs_t; check_member(global_nvs_t, chromeos, GNVS_CHROMEOS_ACPI_OFFSET);
-#ifdef __SMM__ /* Used in SMM to find the ACPI GNVS address */ global_nvs_t *smm_get_gnvs(void); -#endif
void acpi_create_gnvs(global_nvs_t * gnvs);
Hello Patrick Rudolph, Vanessa Eusebio, Huang Jin, Philipp Deppenwiese, build bot (Jenkins), David Guckian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36636
to look at the new patch set (#2).
Change subject: [WIP] arch/x86/smm: Move GNVS prototypes ......................................................................
[WIP] arch/x86/smm: Move GNVS prototypes
Change-Id: Ic8eac39e09d1c36044cb2e2a96edd5c7098b8259 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/soc/intel/baytrail/include/soc/nvs.h M src/soc/intel/braswell/include/soc/nvs.h M src/soc/intel/broadwell/include/soc/nvs.h M src/soc/intel/denverton_ns/include/soc/nvs.h M src/soc/intel/fsp_baytrail/include/soc/nvs.h M src/southbridge/intel/bd82x6x/nvs.h M src/southbridge/intel/fsp_rangeley/nvs.h M src/southbridge/intel/ibexpeak/nvs.h M src/southbridge/intel/lynxpoint/nvs.h 9 files changed, 5 insertions(+), 18 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/36636/2
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36636 )
Change subject: [WIP] arch/x86/smm: Move GNVS prototypes ......................................................................
Patch Set 2:
We can move these GNVS prototypes to x86/smm.h or arch/acpi.h ?
Kyösti Mälkki has removed David Guckian from this change. ( https://review.coreboot.org/c/coreboot/+/36636 )
Change subject: [WIP] arch/x86/smm: Move GNVS prototypes ......................................................................
Removed reviewer David Guckian.
Kyösti Mälkki has removed Vanessa Eusebio from this change. ( https://review.coreboot.org/c/coreboot/+/36636 )
Change subject: [WIP] arch/x86/smm: Move GNVS prototypes ......................................................................
Removed reviewer Vanessa Eusebio.
Kyösti Mälkki has removed Huang Jin from this change. ( https://review.coreboot.org/c/coreboot/+/36636 )
Change subject: [WIP] arch/x86/smm: Move GNVS prototypes ......................................................................
Removed reviewer Huang Jin.
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36636 )
Change subject: [WIP] arch/x86/smm: Move GNVS prototypes ......................................................................
Patch Set 2:
Patch Set 2:
We can move these GNVS prototypes to x86/smm.h or arch/acpi.h ?
One needs a typedef for global_nvs_t for that work, and that creates a dependency on chipset headers (where should they be? here we have soc/ and southbridge/ paths) where we would need consistent names and #include path to pull it.
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36636 )
Change subject: [WIP] arch/x86/smm: Move GNVS prototypes ......................................................................
Patch Set 2: Code-Review+1
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36636 )
Change subject: [WIP] arch/x86/smm: Move GNVS prototypes ......................................................................
Patch Set 2:
Patch Set 2:
Patch Set 2:
We can move these GNVS prototypes to x86/smm.h or arch/acpi.h ?
One needs a typedef for global_nvs_t for that work, and that creates a dependency on chipset headers (where should they be? here we have soc/ and southbridge/ paths) where we would need consistent names and #include path to pull it.
I leave the scope to __SMM__ here then and squash this with another commit.
Kyösti Mälkki has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/36636 )
Change subject: [WIP] arch/x86/smm: Move GNVS prototypes ......................................................................
Abandoned
Squashed with CB:36637
-
Aaron Durbin (Code Review) -
Kyösti Mälkki (Code Review)