Attention is currently required from: Bill XIE. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54335 )
Change subject: mb/asus/p8x7x: Turn P8Z77-M PRO into a variant of P8x7x baseboard ......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/54335/comment/cb5de1e6_28693718 PS3, Line 7: mb/asus/p8x7x: Turn P8Z77-M PRO into a variant of P8x7x baseboard Is this verified in any way? I don't think so, which is why I made this patch series: https://review.coreboot.org/q/topic:%22unify-asus-p8z77-boards%22+status:ope...
I'd *much* prefer my approach over this. The commits in this patch train are either reproducible (coreboot.rom is identical before and after) or very small and easy to review.
https://review.coreboot.org/c/coreboot/+/54335/comment/122f2477_e752cc0d PS3, Line 11: MAINBOARD_HAS_TPM1 should not be selected, since the module is This change deserves a separate commit.