Karthik Ramasubramanian has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39709 )
Change subject: mb/google/dedede: Update SPD index for waddledee ......................................................................
mb/google/dedede: Update SPD index for waddledee
Micron memory part uses SPD Index 0.
BUG=b:152005386 TEST=Build the mainboard.
Change-Id: I990a95b13d636148f0f922fd5c6d4e489d35ed2c Signed-off-by: Karthikeyan Ramasubramanian kramasub@google.com --- M src/mainboard/google/dedede/variants/waddledee/Makefile.inc 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/39709/1
diff --git a/src/mainboard/google/dedede/variants/waddledee/Makefile.inc b/src/mainboard/google/dedede/variants/waddledee/Makefile.inc index 3e06d73..b1aba0e 100644 --- a/src/mainboard/google/dedede/variants/waddledee/Makefile.inc +++ b/src/mainboard/google/dedede/variants/waddledee/Makefile.inc @@ -5,6 +5,6 @@ ## SPDX-License-Identifier: GPL-2.0-or-later ##
-SPD_SOURCES = empty #0b0000 -SPD_SOURCES += Micron_MT53E512M32D2NP_2GB #0b0001 +SPD_SOURCES = Micron_MT53E512M32D2NP_2GB #0b0000 +SPD_SOURCES += empty #0b0001 SPD_SOURCES += samsung-K4U6E3S4AA-MGCL #0b0010
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39709 )
Change subject: mb/google/dedede: Update SPD index for waddledee ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39709 )
Change subject: mb/google/dedede: Update SPD index for waddledee ......................................................................
mb/google/dedede: Update SPD index for waddledee
Micron memory part uses SPD Index 0.
BUG=b:152005386 TEST=Build the mainboard.
Change-Id: I990a95b13d636148f0f922fd5c6d4e489d35ed2c Signed-off-by: Karthikeyan Ramasubramanian kramasub@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/39709 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/mainboard/google/dedede/variants/waddledee/Makefile.inc 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved
diff --git a/src/mainboard/google/dedede/variants/waddledee/Makefile.inc b/src/mainboard/google/dedede/variants/waddledee/Makefile.inc index 3e06d73..b1aba0e 100644 --- a/src/mainboard/google/dedede/variants/waddledee/Makefile.inc +++ b/src/mainboard/google/dedede/variants/waddledee/Makefile.inc @@ -5,6 +5,6 @@ ## SPDX-License-Identifier: GPL-2.0-or-later ##
-SPD_SOURCES = empty #0b0000 -SPD_SOURCES += Micron_MT53E512M32D2NP_2GB #0b0001 +SPD_SOURCES = Micron_MT53E512M32D2NP_2GB #0b0000 +SPD_SOURCES += empty #0b0001 SPD_SOURCES += samsung-K4U6E3S4AA-MGCL #0b0010
-
Furquan Shaikh (Code Review) -
Karthik Ramasubramanian (Code Review)
-
Patrick Georgi (Code Review)