Attention is currently required from: Marshall Dawson, Felix Held. ritul guru has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51674 )
Change subject: mb/amd/bilby: enable boot from NVMe SSD ......................................................................
Patch Set 10: Code-Review+1
(4 comments)
File src/mainboard/amd/bilby/early_gpio.c:
https://review.coreboot.org/c/coreboot/+/51674/comment/72c9dfd4_b40b13dd PS7, Line 22:
nit: remove this extra whitespace here
Ack
https://review.coreboot.org/c/coreboot/+/51674/comment/42ad3382_8c005fd9 PS7, Line 22:
nit: remove this extra whitespace here
Ack
File src/mainboard/amd/bilby/port_descriptors.c:
https://review.coreboot.org/c/coreboot/+/51674/comment/db7f4ac4_454f6cc3 PS7, Line 73: const fsp_ddi_descriptor **ddi_descs, size_t *ddi_num)
I would leave lines 72 and 73 as-is and put the tabs back in. […]
Ack
https://review.coreboot.org/c/coreboot/+/51674/comment/cec69f7c_1de54123 PS7, Line 73: const fsp_ddi_descriptor **ddi_descs, size_t *ddi_num)
I would leave lines 72 and 73 as-is and put the tabs back in. […]
Ack
-
ritul guru (Code Review)