EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40415 )
Change subject: mb/google/puff: add a region to cache SPD data
......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40415/7/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/Kconfig:
https://review.coreboot.org/c/coreboot/+/40415/7/src/mainboard/google/hatch/...
PS7, Line 82: if ROMSTAGE_SPD_CBFS
Add something like USE_SPD_CACHE config should be better.
https://review.coreboot.org/c/coreboot/+/40415/7/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/romstage_spd_smbus.c:
https://review.coreboot.org/c/coreboot/+/40415/7/src/mainboard/google/hatch/...
PS7, Line 20: uint8_t *spd_cache;
maybe use the if CONFIG_USE_SPD_CACHE to guard this? So you won't check this for the unsupported project.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40415
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8d07fddf113a767d62394cb31e33b56f22f74351
Gerrit-Change-Number: 40415
Gerrit-PatchSet: 7
Gerrit-Owner: Jamie Chen
jamie.chen@intel.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 07 May 2020 05:50:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment