Change in coreboot[master]: mb/intel/adlrvp: Replace if-else-if ladder with switch construct
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47054 )
Change subject: mb/intel/adlrvp: Replace if-else-if ladder with switch construct ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47054/2/src/mainboard/intel/adlrvp/... File src/mainboard/intel/adlrvp/variants/adlrvp_p/memory.c:
https://review.coreboot.org/c/coreboot/+/47054/2/src/mainboard/intel/adlrvp/... PS2, Line 76: case ADL_P_LP4_1:
I would agree in other cases, but I'd say this case is pretty self-explanatory already. […]
It's an old habit of mine that would give you a heuristic to catch unintended fallthroughs. This case isn't too bad, but I will also note that C++17 added support for a [[fallthrough]] attribute, which I think you can finagle into an error if the compiler catches an unmarked one. I guess code review is our tool to make sure things like this are correct here.
-
Tim Wawrzynczak (Code Review)